Re: [PATCH 08/10] huge pagecache: extend mremap pmd rmap lockout to files

Kirill A. Shutemov
2016-04-11T10:32:26Z

On Tue, Apr 05, 2016 at 01:52:48PM -0700, Hugh Dickins wrote:
> Whatever huge pagecache implementation we go with, file rmap locking
> must be added to anon rmap locking, when mremap's move_page_tables()
> finds a pmd_trans_huge pmd entry: a simple change, let's do it now.
>
> Factor out take_rmap_locks() and drop_rmap_locks() to handle the
> locking for make move_ptes() and move_page_tables(), and delete
> the VM_BUG_ON_VMA which rejected vm_file and required anon_vma.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>

Yeah, it's cleaner than my variant.

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

--
Kirill A. Shutemov