Re: [PATCH 10/10] arch: fix has_transparent_hugepage()

Ingo Molnar
2016-04-06T21:58:24Z

* Chris Metcalf <cmetcalf@mellanox.com> wrote:

> On 4/6/2016 2:58 AM, Ingo Molnar wrote:
> >* Hugh Dickins <hughd@google.com> wrote:
> >
> >>--- a/arch/x86/include/asm/pgtable.h
> >>+++ b/arch/x86/include/asm/pgtable.h
> >>@@ -181,6 +181,7 @@ static inline int pmd_trans_huge(pmd_t p
> >> return (pmd_val(pmd) & (_PAGE_PSE|_PAGE_DEVMAP)) == _PAGE_PSE;
> >> }
> >>+#define has_transparent_hugepage has_transparent_hugepage
> >> static inline int has_transparent_hugepage(void)
> >> {
> >> return cpu_has_pse;
> >Small nit, just writing:
> >
> > #define has_transparent_hugepage
> >
> >ought to be enough, right?
>
> No, since then in hugepage_init() the has_transparent_hugepage() call site
> would be left with just a stray pair of parentheses instead of a call.

Yes, indeed ...

Thanks,

Ingo