[PATCH] mm: add three more cond_resched() in swapoff

[PATCH] mm: add three more cond_resched() in swapoff

[Hugh Dickins]

Add a cond_resched() in the unuse_pmd_range() loop (so as to call
it even when pmd none or trans_huge, like zap_pmd_range() does);
and in the unuse_mm() loop (since that might skip over many vmas).
shmem_unuse() and radix_tree_locate_item() look good enough already.

Those were the obvious places, but in fact the stalls came from
find_next_to_unuse(), which sometimes scans through many unused
entries.  Apply scan_swap_map()'s LATENCY_LIMIT of 256 there too;
and only go off to test frontswap_map when a used entry is found.

Reported-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Hugh Dickins <hughd@google.com>
---

 mm/swapfile.c |   13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

--- 4.9-rc8/mm/swapfile.c	2016-11-13 11:44:43.056622549 -0800
+++ linux/mm/swapfile.c	2016-12-05 20:03:04.937152051 -0800
@@ -1234,6 +1234,7 @@ static inline int unuse_pmd_range(struct
 
 	pmd = pmd_offset(pud, addr);
 	do {
+		cond_resched();
 		next = pmd_addr_end(addr, end);
 		if (pmd_none_or_trans_huge_or_clear_bad(pmd))
 			continue;
@@ -1313,6 +1314,7 @@ static int unuse_mm(struct mm_struct *mm
 	for (vma = mm->mmap; vma; vma = vma->vm_next) {
 		if (vma->anon_vma && (ret = unuse_vma(vma, entry, page)))
 			break;
+		cond_resched();
 	}
 	up_read(&mm->mmap_sem);
 	return (ret < 0)? ret: 0;
@@ -1350,15 +1352,12 @@ static unsigned int find_next_to_unuse(s
 			prev = 0;
 			i = 1;
 		}
-		if (frontswap) {
-			if (frontswap_test(si, i))
-				break;
-			else
-				continue;
-		}
 		count = READ_ONCE(si->swap_map[i]);
 		if (count && swap_count(count) != SWAP_MAP_BAD)
-			break;
+			if (!frontswap || frontswap_test(si, i))
+				break;
+		if ((i % LATENCY_LIMIT) == 0)
+			cond_resched();
 	}
 	return i;
 }

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>