From: Hugh Dickins <hughd@google.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Hugh Dickins <hughd@google.com>,
syzbot <syzbot+b8e0dfee3fd8c9012771@syzkaller.appspotmail.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
syzkaller-bugs@googlegroups.com
Subject: Re: kernel BUG at mm/shmem.c:LINE!
Date: Thu, 26 Jul 2018 09:40:20 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.11.1807260936040.1101@eggly.anvils> (raw)
In-Reply-To: <20180726143353.GA27612@bombadil.infradead.org>
On Thu, 26 Jul 2018, Matthew Wilcox wrote:
> On Wed, Jul 25, 2018 at 11:53:15PM -0700, Hugh Dickins wrote:
>
> and fixing the bug differently ;-) But many thanks for spotting it!
I thought you might :)
>
> I'll look into the next bug you reported ...
No need: that idea now works a lot better when I use the initialized
"start", instead of the uninitialized "index".
Hugh
--- mmotm/mm/khugepaged.c 2018-07-20 17:54:41.978805312 -0700
+++ linux/mm/khugepaged.c 2018-07-26 09:20:22.416949014 -0700
@@ -1352,6 +1352,7 @@ static void collapse_shmem(struct mm_str
goto out;
} while (1);
+ xas_set(&xas, start);
for (index = start; index < end; index++) {
struct page *page = xas_next(&xas);
next prev parent reply other threads:[~2018-07-26 16:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-07 1:19 kernel BUG at mm/shmem.c:LINE! syzbot
2018-07-07 2:57 ` Matthew Wilcox
2018-07-09 14:36 ` Matthew Wilcox
2018-07-23 2:28 ` Hugh Dickins
2018-07-23 14:01 ` Matthew Wilcox
2018-07-23 19:14 ` Hugh Dickins
2018-07-23 20:36 ` Matthew Wilcox
2018-07-23 22:42 ` Hugh Dickins
2018-07-23 22:54 ` Matthew Wilcox
2018-07-24 9:12 ` Hugh Dickins
2018-07-26 6:53 ` Hugh Dickins
2018-07-26 14:33 ` Matthew Wilcox
2018-07-26 16:40 ` Hugh Dickins [this message]
2018-07-26 19:32 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1807260936040.1101@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=syzbot+b8e0dfee3fd8c9012771@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox