From: Hugh Dickins <hughd@google.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Hugh Dickins <hughd@google.com>,
Chris Down <chris@chrisdown.name>
Subject: Re: [PATCH] tmpfs: fix Documentation nits
Date: Wed, 2 Dec 2020 14:41:18 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.11.2012021437570.4989@eggly.anvils> (raw)
In-Reply-To: <20201202010934.18566-1-rdunlap@infradead.org>
On Tue, 1 Dec 2020, Randy Dunlap wrote:
> Fix a typo, punctuation, use uppercase for CPUs, and limit
> tmpfs to keeping only its files in virtual memory (phrasing).
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: Hugh Dickins <hughd@google.com>
Acked-by: Hugh Dickins <hughd@google.com>
Thanks Randy: not so much for these nits,
but for keeping your eyes open and helping generally.
> Cc: Chris Down <chris@chrisdown.name>
> ---
> Documentation/filesystems/tmpfs.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> --- linux-next-20201201.orig/Documentation/filesystems/tmpfs.rst
> +++ linux-next-20201201/Documentation/filesystems/tmpfs.rst
> @@ -4,7 +4,7 @@
> Tmpfs
> =====
>
> -Tmpfs is a file system which keeps all files in virtual memory.
> +Tmpfs is a file system which keeps all of its files in virtual memory.
>
>
> Everything in tmpfs is temporary in the sense that no files will be
> @@ -35,7 +35,7 @@ tmpfs has the following uses:
> memory.
>
> This mount does not depend on CONFIG_TMPFS. If CONFIG_TMPFS is not
> - set, the user visible part of tmpfs is not build. But the internal
> + set, the user visible part of tmpfs is not built. But the internal
> mechanisms are always present.
>
> 2) glibc 2.2 and above expects tmpfs to be mounted at /dev/shm for
> @@ -50,7 +50,7 @@ tmpfs has the following uses:
> This mount is _not_ needed for SYSV shared memory. The internal
> mount is used for that. (In the 2.3 kernel versions it was
> necessary to mount the predecessor of tmpfs (shm fs) to use SYSV
> - shared memory)
> + shared memory.)
>
> 3) Some people (including me) find it very convenient to mount it
> e.g. on /tmp and /var/tmp and have a big swap partition. And now
> @@ -83,7 +83,7 @@ If nr_blocks=0 (or size=0), blocks will
> if nr_inodes=0, inodes will not be limited. It is generally unwise to
> mount with such options, since it allows any user with write access to
> use up all the memory on the machine; but enhances the scalability of
> -that instance in a system with many cpus making intensive use of it.
> +that instance in a system with many CPUs making intensive use of it.
>
>
> tmpfs has a mount option to set the NUMA memory allocation policy for
prev parent reply other threads:[~2020-12-02 22:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 1:09 [PATCH] tmpfs: fix Documentation nits Randy Dunlap
2020-12-02 22:41 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.2012021437570.4989@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=chris@chrisdown.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).