From: Matthew Wilcox <willy@infradead.org>
To: Hongfu Li <hongfu.li@linux.dev>
Cc: akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org,
liam@infradead.org, vbabka@kernel.org, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Hongfu Li <lihongfu@kylinos.cn>
Subject: Re: [PATCH] mm/folio-compat: Drop superfluous return statements in void compat wrappers
Date: Fri, 17 Jul 2026 18:29:20 +0100 [thread overview]
Message-ID: <alpmcNoufw0T2EU5@casper.infradead.org> (raw)
In-Reply-To: <20260717072054.74260-1-hongfu.li@linux.dev>
On Fri, Jul 17, 2026 at 03:20:54PM +0800, Hongfu Li wrote:
> From: Hongfu Li <lihongfu@kylinos.cn>
>
> unlock_page(), end_page_writeback() and wait_on_page_writeback()
> are void wrappers forwarding to folio-based functions which also
> return void. Explicit return statements here are syntactically valid
> but unnecessary, and inconsistent with other nearby compat helpers
> such as mark_page_accessed() and set_page_writeback().
>
> Drop all these superfluous return keywords.
why bother? this file is temporary scaffolding. if they offend you so
much, work on removing the need for them.
prev parent reply other threads:[~2026-07-17 17:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 7:20 [PATCH] mm/folio-compat: Drop superfluous return statements in void compat wrappers Hongfu Li
2026-07-17 17:29 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpmcNoufw0T2EU5@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=hongfu.li@linux.dev \
--cc=liam@infradead.org \
--cc=lihongfu@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox