From: Breno Leitao <leitao@debian.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
puranjay@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH] mm/kmemleak: report RCU-tasks quiescent states during the scan
Date: Mon, 27 Jul 2026 09:02:12 -0700 [thread overview]
Message-ID: <ameA03TahRgsWoz5@gmail.com> (raw)
In-Reply-To: <amdWVTs0WKOxguxP@gmail.com>
On Mon, Jul 27, 2026 at 06:04:37AM -0700, Breno Leitao wrote:
> > > The document was not a waste of time. it helped people like me to
> > > understand what the issue is, and what are the decisions we have ahead
> > > of us.
> > >
> > > Back to what is the best decision/design, I honestly don't have an
> > > opinion, but I am happy to get more data about Meta production servers
> > > to help with the decision.
> >
> > Looking forward to seeing what you come up with!
>
> I found 3 different cases on Meta fleet, where rcu task stalls show up:
>
> 1) kmemleak -> This patch solves it
> 2) KVM / kcompactd
> * Holdout: kcompactd0 (pid 1216), state:R, nvcsw frozen at
> 716336/716336 across three reports 10 min apart (stuck ≥20 min in
> one compaction pass)
> * This is coming from: migrate_pages ->
> kvm_mmu_notifier_invalidate_range_start ->
> tdp_mmu_next_root -> tdp_mmu_zap_leafs
>
> 3) Nvidia driver
> * stuck in nv_procfs_read_lock_params
>
> Given we can't do much about 3) and 1) is now closed, I will spend some
> time geting more data and possible a fix for 2.
Quick update about item number 2), I've investigated and found that
migrate_pages_batch() unmaps each folio before moving it, and every
unmap runs the mmu_notifier invalidate callbacks. On KVM hosts
try_to_migrate() ends up in kvm_mmu_notifier_invalidate_range_start() ->
tdp_mmu_zap_leafs(), which is expensive. Patch at:
https://lore.kernel.org/all/20260727-kcompact-v1-1-bdfefddd6874@debian.org/
next prev parent reply other threads:[~2026-07-27 16:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 13:23 [PATCH] mm/kmemleak: report RCU-tasks quiescent states during the scan Breno Leitao
2026-07-20 15:25 ` Paul E. McKenney
2026-07-20 22:39 ` Andrew Morton
2026-07-21 4:21 ` Paul E. McKenney
2026-07-23 13:26 ` Breno Leitao
2026-07-23 15:56 ` Paul E. McKenney
2026-07-24 9:58 ` Breno Leitao
2026-07-24 17:29 ` Paul E. McKenney
2026-07-27 13:04 ` Breno Leitao
2026-07-27 16:02 ` Breno Leitao [this message]
2026-07-21 0:00 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ameA03TahRgsWoz5@gmail.com \
--to=leitao@debian.org \
--cc=akpm@linux-foundation.org \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paulmck@kernel.org \
--cc=puranjay@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox