From: Michal Hocko <mhocko@suse.com>
To: Barry Song <baohua@kernel.org>
Cc: Ridong <ridong.chen@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
David Hildenbrand <david@kernel.org>,
Qi Zheng <qi.zheng@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Lorenzo Stoakes <ljs@kernel.org>,
Kairui Song <kasong@tencent.com>,
Axel Rasmussen <axelrasmussen@google.com>,
Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
Zhongkun He <hezhongkun.hzk@bytedance.com>,
Muchun Song <muchun.song@linux.dev>,
Davidlohr Bueso <dave@stgolabs.net>,
Roman Gushchin <roman.gushchin@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Ridong Chen <chenridong@xiaomi.com>
Subject: Re: [PATCH -v4 1/4] mm/vmscan: fix anon-only reclaim evicting file pages when swappiness=max
Date: Tue, 28 Jul 2026 13:53:41 +0200 [thread overview]
Message-ID: <amiYRZLAMwMjb0fy@tiehlicka> (raw)
In-Reply-To: <CAGsJ_4xLPpf82CoS=ZNNP6nZoU+k=69oJFL3-YT9zibop78TnA@mail.gmail.com>
On Tue 28-07-26 18:03:24, Barry Song wrote:
[...]
> I understand your point. I just find
>
> if (swappiness == SWAPPINESS_ANON_ONLY && sc->proactive)
>
> a bit odd, since `swappiness == SWAPPINESS_ANON_ONLY`
> already implies `sc->proactive`.
It does so very implicitely and you need to look around to learn about
that. That is my biggest concen here. WARN on is just a very poor
annotation to remind us about that assumption.
I would much rather have get_scan_count more self explanatory as it is
quite heavy already.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2026-07-28 11:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 3:34 [PATCH -v4 0/4] mm/vmscan: fix swappiness=max and clean up per-node proactive reclaim Ridong
2026-07-24 3:34 ` [PATCH -v4 1/4] mm/vmscan: fix anon-only reclaim evicting file pages when swappiness=max Ridong
2026-07-27 8:19 ` Michal Hocko
2026-07-27 10:56 ` Barry Song
2026-07-27 11:07 ` Michal Hocko
2026-07-28 1:02 ` Ridong Chen
2026-07-27 11:37 ` Michal Hocko
2026-07-27 22:35 ` Barry Song
2026-07-28 7:18 ` Michal Hocko
2026-07-28 10:03 ` Barry Song
2026-07-28 11:53 ` Michal Hocko [this message]
2026-07-28 12:18 ` Barry Song
2026-07-24 3:34 ` [PATCH -v4 2/4] mm: vmscan: propagate real error code from per-node proactive reclaim Ridong
2026-07-24 3:34 ` [PATCH -v4 3/4] mm: vmscan: drop unused gfp_mask parameter from __node_reclaim() Ridong
2026-07-24 3:34 ` [PATCH -v4 4/4] mm/mglru: fix anon-only reclaim evicting file pages when swappiness=max Ridong
2026-07-24 7:18 ` Kairui Song
2026-07-24 8:29 ` Barry Song
2026-07-27 6:37 ` Baolin Wang
2026-07-24 5:37 ` [PATCH -v4 0/4] mm/vmscan: fix swappiness=max and clean up per-node proactive reclaim Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amiYRZLAMwMjb0fy@tiehlicka \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=chenridong@xiaomi.com \
--cc=dave@stgolabs.net \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hezhongkun.hzk@bytedance.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=muchun.song@linux.dev \
--cc=qi.zheng@linux.dev \
--cc=ridong.chen@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox