Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Pratyush Yadav <pratyush@kernel.org>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>,
	Alexander Graf <graf@amazon.com>,
	Muchun Song <muchun.song@linux.dev>,
	Oscar Salvador <osalvador@suse.de>,
	David Hildenbrand <david@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jason Miu <jasonmiu@google.com>,
	Jork Loeser <jloeser@linux.microsoft.com>,
	kexec@lists.infradead.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 00/21] kho: make boot time huge page allocation work nicely with KHO
Date: Tue, 28 Jul 2026 16:35:41 +0300	[thread overview]
Message-ID: <amiwLSEi8cczamP1@kernel.org> (raw)
In-Reply-To: <20260725172133.4018491-1-pratyush@kernel.org>

On Sat, Jul 25, 2026 at 07:21:00PM +0200, Pratyush Yadav wrote:
> From: "Pratyush Yadav (Google)" <pratyush@kernel.org>
> 
> Hi,
> 
> Gigantic huge page allocation is somewhat broken currently with KHO.
> 
> First, they break scratch size accounting. Since they are allocated
> using the memblock alloc APIs, they count towards RSRV_KERN, and this
> scratch size when using scratch_scale. This means if huge pages take a
> large enough chunk of system memory scratch size will blow up and fail
> to allocate.
> 
> Second, scratch can not contain preserved memory, and if hugepages are
> allocated from scratch, they will fail to be preserved with the upcoming
> hugetlb preservation series [0].
> 
> Fix this by introducing the concept of extended scratch areas. They are
> areas that the kernel discovers on boot by walking the radix tree and
> finding free memory ranges. See patch 10 for more details.
> 
> Muchun Song (1):
>   mm/mm_init: simplify deferred_free_pages() migratetype init
> 
> Pratyush Yadav (Google) (20):
>   kho: generalize radix tree APIs
>   kho: make radix max key width more obvious
>   kho: disallow wide keys in radix tree
>   kho: return virtual address of mem_map from kho_get_mem_map()
>   kho: store incoming radix tree in kho_in
>   kho: move all memory retrieval logic to kho_mem_retrieve()
>   kho: add a struct for radix callbacks
>   kho: add callback for table pages
>   kho: add data argument to radix walk callback
>   kho: allow early-boot usage of the KHO radix tree
>   kho: allow destroying KHO radix tree
>   kho: add kho_radix_init_tree()
>   kho: expose kho_scratch_overlap() to kexec_handover.h
>   kho: initialize kho_scratch pointer earlier in boot
>   kho: initialize preserved memory map radix tree earlier
>   mm/mm_init: don't rely on memblock to get KHO scratch migratetype
>   kho: extend scratch
>   memblock: make HugeTLB bootmem allocation work with KHO
>   memblock: add memblock_reserved_hugetlb_size()
>   kho: exclude hugetlb memory from scratch size calculation

I added it to the liveupdate tree.

Please take a look at Sashiko comments, we might need v5 if it has valid
(not pre-existing) points.

-- 
Sincerely yours,
Mike.


  parent reply	other threads:[~2026-07-28 13:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-25 17:21 [PATCH v4 00/21] kho: make boot time huge page allocation work nicely with KHO Pratyush Yadav
2026-07-25 17:21 ` [PATCH v4 02/21] kho: make radix max key width more obvious Pratyush Yadav
2026-07-25 17:21 ` [PATCH v4 04/21] kho: return virtual address of mem_map from kho_get_mem_map() Pratyush Yadav
2026-07-25 17:21 ` [PATCH v4 12/21] kho: add kho_radix_init_tree() Pratyush Yadav
2026-07-25 17:21 ` [PATCH v4 14/21] kho: initialize kho_scratch pointer earlier in boot Pratyush Yadav
2026-07-25 17:21 ` [PATCH v4 17/21] mm/mm_init: don't rely on memblock to get KHO scratch migratetype Pratyush Yadav
2026-07-25 17:21 ` [PATCH v4 19/21] memblock: make HugeTLB bootmem allocation work with KHO Pratyush Yadav
2026-07-28 17:45   ` Mike Rapoport
     [not found] ` <20260725172133.4018491-17-pratyush@kernel.org>
2026-07-26 10:16   ` [PATCH v4 16/21] mm/mm_init: simplify deferred_free_pages() migratetype init Mike Rapoport
2026-07-27  3:25     ` Andrew Morton
2026-07-27  3:43       ` Muchun Song
2026-07-27 10:08         ` Mike Rapoport
2026-07-27 22:53           ` Andrew Morton
2026-07-28 13:35 ` Mike Rapoport [this message]
2026-07-28 14:37   ` [PATCH v4 00/21] kho: make boot time huge page allocation work nicely with KHO Pratyush Yadav
2026-07-28 16:07     ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amiwLSEi8cczamP1@kernel.org \
    --to=rppt@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=graf@amazon.com \
    --cc=jasonmiu@google.com \
    --cc=jloeser@linux.microsoft.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=muchun.song@linux.dev \
    --cc=osalvador@suse.de \
    --cc=pasha.tatashin@soleen.com \
    --cc=pratyush@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox