From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Richard Chang <richardycc@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Martin Liu <liumartin@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/zsmalloc: fix release order of locks in zs_page_migrate()
Date: Wed, 29 Jul 2026 13:52:53 +0900 [thread overview]
Message-ID: <ammG560TO_J3USz0@google.com> (raw)
In-Reply-To: <CALC_0q-RwrfxiMypoKRQWUkUzRwkt2KoXN_GbWLxXX+4xx0WPA@mail.gmail.com>
On (26/07/29 12:46), Richard Chang wrote:
> On Wed, Jul 29, 2026 at 2:15 AM Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > Thanks.
> >
> > Does this actually fix a lockdep splat? If so, is a link available?
> >
>
> No, this does not fix an active lockdep splat or a reported runtime deadlock.
> It is just a code hygiene to release locks in LIFO order.
Right, surprisingly enough lockdep was never unhappy with the original
code (I run tests with CONFIG_PROVE_LOCKING=y.)
prev parent reply other threads:[~2026-07-29 4:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 5:53 [PATCH] mm/zsmalloc: fix release order of locks in zs_page_migrate() Richard Chang
2026-07-28 6:39 ` Sergey Senozhatsky
2026-07-28 18:15 ` Andrew Morton
2026-07-29 4:46 ` Richard Chang
2026-07-29 4:52 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ammG560TO_J3USz0@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liumartin@google.com \
--cc=minchan@kernel.org \
--cc=richardycc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox