Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Song Hu <husong@kylinos.cn>,
	linux-mm@kvack.org,  akpm@linux-foundation.org, david@kernel.org,
	ziy@nvidia.com, liam@infradead.org,  nico.pache@linux.dev,
	ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org,
	 lance.yang@linux.dev, usama.arif@linux.dev, vbabka@kernel.org,
	rppt@kernel.org,  surenb@google.com, mhocko@suse.com,
	corbet@lwn.net, skhan@linuxfoundation.org,
	 rdunlap@infradead.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Docs/mm: fix THP policy counts in transhuge
Date: Wed, 12 Aug 2026 11:55:29 +0100	[thread overview]
Message-ID: <anxRGxcLRplmYr2r@lucifer> (raw)
In-Reply-To: <6e4aae7b-2c71-4109-945c-6481efde3636@linux.alibaba.com>

On Wed, Aug 12, 2026 at 06:52:30PM +0800, Baolin Wang wrote:
>
>
> On 8/12/26 5:27 PM, Lorenzo Stoakes (ARM) wrote:
> > On Wed, Aug 12, 2026 at 04:03:13PM +0800, Song Hu wrote:
> > > transhuge.rst claims seven policies for transparent_hugepage_shmem= and
> > > four for transparent_hugepage_tmpfs=.  Both boot parameters are parsed by
> > > shmem_parse_huge(), which accepts six: always, within_size, advise, never,
> > > deny and force.  The "four" applies only to the per-mount huge= option
> > > (shmem_param_enums_huge).  Fix both counts to six.
> > >
> > > Signed-off-by: Song Hu <husong@kylinos.cn>
> > > ---
> > >   Documentation/admin-guide/mm/transhuge.rst | 6 +++---
> > >   1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst
> > > index b187d618452f..72e944f49da5 100644
> > > --- a/Documentation/admin-guide/mm/transhuge.rst
> > > +++ b/Documentation/admin-guide/mm/transhuge.rst
> > > @@ -389,14 +389,14 @@ is not defined within a valid ``thp_anon``, its policy will default to
> > >   Similarly to ``transparent_hugepage``, you can control the hugepage
> > >   allocation policy for the internal shmem mount by using the kernel parameter
> > >   ``transparent_hugepage_shmem=<policy>``, where ``<policy>`` is one of the
> > > -seven valid policies for shmem (``always``, ``within_size``, ``advise``,
> > > +six valid policies for shmem (``always``, ``within_size``, ``advise``,
> > >   ``never``, ``deny``, and ``force``).
> >
> > I'm not sure we really want to advertise 'special' testing modes like this,
> > sorry. These are not modes anybody should be using in practice especially at
> > kernel boot. We should probably stop people doing that...!
>
> Yes, 'deny' and 'force' are testing-only configurations and really shouldn't
> be exposed via the kernel command line. I'll clean them up.

Thanks!

--
Cheers, Lorenzo


      reply	other threads:[~2026-08-12 10:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12  8:03 [PATCH 0/2] Docs: THP documentation fixes Song Hu
2026-08-12  8:03 ` [PATCH 1/2] Docs/ABI: document transparent_hugepage/shrink_underused Song Hu
2026-08-12  8:58   ` Lorenzo Stoakes (ARM)
2026-08-12  8:03 ` [PATCH 2/2] Docs/mm: fix THP policy counts in transhuge Song Hu
2026-08-12  8:41   ` Baolin Wang
2026-08-12  9:27   ` Lorenzo Stoakes (ARM)
2026-08-12 10:52     ` Baolin Wang
2026-08-12 10:55       ` Lorenzo Stoakes (ARM) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anxRGxcLRplmYr2r@lucifer \
    --to=ljs@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=corbet@lwn.net \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=husong@kylinos.cn \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=nico.pache@linux.dev \
    --cc=rdunlap@infradead.org \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=skhan@linuxfoundation.org \
    --cc=surenb@google.com \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox