From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Eric Kim <seohyun.kim@outlook.kr>
Cc: akpm@linux-foundation.org, david@kernel.org, riel@surriel.com,
liam@infradead.org, vbabka@kernel.org, harry@kernel.org,
jannh@google.com, lance.yang@linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Barry Song <baohua@kernel.org>
Subject: Re: [PATCH v4] mm/rmap: synchronize lock and unlock target in anon_vma_clone
Date: Mon, 17 Aug 2026 08:48:32 +0100 [thread overview]
Message-ID: <aoK8o0zmbKcDVDD9@lucifer> (raw)
In-Reply-To: <aoK7Ko9O8cGz2iTF@lucifer>
On Mon, Aug 17, 2026 at 08:43:30AM +0100, Lorenzo Stoakes (ARM) wrote:
> On Mon, Aug 17, 2026 at 02:25:11PM +0900, Eric Kim wrote:
> > ---
> > v2:
> > - Clarify the commit message to explain that src->anon_vma and
> > active_anon_vma refer to the same anon_vma.
> > v3:
> > - Carry over review tags from v2.
> > v4:
> > - Clarify ctive_anon_vma and src->anon_vma refer to the same
> > anon_vma.
>
> Extremely petty nit - and you don't have to do anything this is just for the
> future:
>
> - Prefer a reverse order, so latest revision at the top.
> - Nice to have lore links to previous revisions.
Oh and also - nice to attribute the changes to the person who requested them,
e.g. 'Clarify xxx as per Barry Song', etc. thanks! :)
--
Cheers, Lorenzo
prev parent reply other threads:[~2026-08-17 7:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 5:25 [PATCH v4] mm/rmap: synchronize lock and unlock target in anon_vma_clone Eric Kim
2026-08-17 7:43 ` Lorenzo Stoakes (ARM)
2026-08-17 7:48 ` Lorenzo Stoakes (ARM) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoK8o0zmbKcDVDD9@lucifer \
--to=ljs@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=david@kernel.org \
--cc=harry@kernel.org \
--cc=jannh@google.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@surriel.com \
--cc=seohyun.kim@outlook.kr \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox