From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Lance Yang <lance.yang@linux.dev>
Cc: Eric Kim <seohyun.kim@outlook.kr>,
david@kernel.org, riel@surriel.com, liam@infradead.org,
vbabka@kernel.org, harry@kernel.org, jannh@google.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH v2] mm/rmap: synchronize lock and unlock target in anon_vma_clone
Date: Mon, 17 Aug 2026 18:27:32 +0100 [thread overview]
Message-ID: <aoND15MPOJcfykwN@gremlin> (raw)
In-Reply-To: <a2ec5fd7-fe7c-40ce-a78e-029b2fefcb84@linux.dev>
On Mon, Aug 17, 2026 at 11:07:49AM +0800, Lance Yang wrote:
>
>
> On 2026/8/17 10:34, Eric Kim wrote:
> > Currently, in anon_vma_clone(), active_anon_vma is assigned from
> > src->anon_vma and is used when unlocking anon_vma after linking
> > new AVCs. However, the corresponding lock operation uses
> > src->anon_vma directly.
> >
> > Use active_anon_vma consistently to make the lock/unlock pair explicit.
> >
> > Signed-off-by: Eric Kim <seohyun.kim@outlook.kr>
> > ---
> > v2:
> > - Clarify the commit message to explain that src->anon_vma and
> > active_anon_vma refer to the same anon_vma.
>
> Just a heads-up... since only the commit message changed, the Reviewed-by
> tags from v1 still apply, so please carry them over ...
Yup, if you're not fundamentally changing the patch you should retain all
existing tags like this.
FWIW:
Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
--
Cheers, Lorenzo
prev parent reply other threads:[~2026-08-17 17:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 2:34 [PATCH v2] mm/rmap: synchronize lock and unlock target in anon_vma_clone Eric Kim
2026-08-17 2:37 ` Rik van Riel
2026-08-17 3:07 ` Lance Yang
2026-08-17 17:27 ` Lorenzo Stoakes (ARM) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoND15MPOJcfykwN@gremlin \
--to=ljs@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=harry@kernel.org \
--cc=jannh@google.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@surriel.com \
--cc=seohyun.kim@outlook.kr \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox