Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Lance Yang <lance.yang@linux.dev>,
	david@kernel.org, mhocko@suse.com, leon.hwang@linux.dev,
	linux-mm@kvack.org, muchun.song@linux.dev, osalvador@suse.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hugetlb: add cond_resched() to __unmap_hugepage_range()
Date: Wed, 19 Aug 2026 00:46:09 +0100	[thread overview]
Message-ID: <aoTuwV76Sd0ahBEC@casper.infradead.org> (raw)
In-Reply-To: <20260818162430.0a51522ac9bd671cce62650f@linux-foundation.org>

On Tue, Aug 18, 2026 at 04:24:30PM -0700, Andrew Morton wrote:
> On Wed, 19 Aug 2026 06:18:58 +0800 Lance Yang <lance.yang@linux.dev> wrote:
> 
> > >> > 
> > >> > That's pretty bad behavior and we might want to fix it in earlier
> > >> > kernels.  Is PREEMPT_NONE effectively dead in 6.18.x and its
> > >> > existing users?
> > >> > 
> > >> > If yes, we do want to fix older kernels then we should merge this.
> > >> > 
> > >> 
> > >> Okay, but that would be stable-only fixes?
> > >
> > >Not understanding.
> > >
> > >Maybe you refer to adding a patch to -stable but not to -linus?  That's
> > >against the -stable rules
> > >(Documentation/process/stable-kernel-rules.rst).
> > 
> > Since cond_resched() is a scheduling no-op under LAZY/FULL anyway (only
> > the __might_resched() debug check remains), why not take this upstream
> > with Cc: stable?
> 
> I think so - as long as PREEPMT_NONE exists we should support it as
> well as we can.  If the day comes that PREEMPT_NONE is removed, then we
> get to remove lots of cond_resched()s.  mm/ has 200 of the things.
> 
> > Mainline scheduling stays unchanged, and stable can pick it up for old
> > PREEMPT_NONE kernels. wdyt?
> 
> Addressing this issue in older kernels is another reason.

That is not the direction that the scheduler developers wish us to take.


  reply	other threads:[~2026-08-18 23:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 13:50 [PATCH] hugetlb: add cond_resched() to __unmap_hugepage_range() Leon Hwang
2026-08-18 14:23 ` David Hildenbrand (Arm)
2026-08-18 18:17   ` Andrew Morton
2026-08-18 18:21     ` David Hildenbrand (Arm)
2026-08-18 18:55       ` Andrew Morton
2026-08-18 22:18         ` Lance Yang
2026-08-18 23:24           ` Andrew Morton
2026-08-18 23:46             ` Matthew Wilcox [this message]
2026-08-18 23:59               ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoTuwV76Sd0ahBEC@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=lance.yang@linux.dev \
    --cc=leon.hwang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=osalvador@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox