From: Kiryl Shutsemau <kirill@shutemov.name>
To: Zi Yan <ziy@nvidia.com>
Cc: Qi Xi <xiqi2@huawei.com>,
akpm@linux-foundation.org, vbabka@kernel.org,
longli@microsoft.com, kotaranov@microsoft.com,
jan.kiszka@siemens.com, kbingham@kernel.org, surenb@google.com,
mhocko@suse.com, brendan.jackman@linux.dev, hannes@cmpxchg.org,
linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, sunnanyong@huawei.com,
wangkefeng.wang@huawei.com
Subject: Re: [PATCH] mm: drop stale MAX_ORDER references
Date: Thu, 20 Aug 2026 16:00:31 +0100 [thread overview]
Message-ID: <aocWWrK_K1iCtq4P@thinkstation> (raw)
In-Reply-To: <AF9812A4-550F-4E3A-B67C-EAF6F9F56982@nvidia.com>
On Thu, Aug 20, 2026 at 09:52:03AM -0400, Zi Yan wrote:
> On 20 Aug 2026, at 9:27, Kiryl Shutsemau wrote:
>
> > On Tue, Aug 18, 2026 at 08:24:08PM +0800, Qi Xi wrote:
> >> The treewide rename in commit 5e0a760b4441 ("mm, treewide: rename
> >> MAX_ORDER to MAX_PAGE_ORDER") left a few spots still using the old
> >> name:
> >>
> >> - two comments in include/net/mana/mana.h and mm/page_alloc.c;
> >> - the gdb helper scripts/gdb/linux/mm.py, where self.MAX_ORDER is
> >> a local mirror of the kernel's MAX_ORDER define.
> >>
> >> Rename the leftover instances to MAX_PAGE_ORDER so the tree is
> >> consistent.
> >>
> >> No functional changes.
> >>
> >> Signed-off-by: Qi Xi <xiqi2@huawei.com>
> >> ---
> >> include/net/mana/mana.h | 4 ++--
> >> mm/page_alloc.c | 2 +-
> >> scripts/gdb/linux/mm.py | 8 ++++----
> >> 3 files changed, 7 insertions(+), 7 deletions(-)
> >>
> >> diff --git a/include/net/mana/mana.h b/include/net/mana/mana.h
> >> index 04acb6791dbd..1d5bed71d6a7 100644
> >> --- a/include/net/mana/mana.h
> >> +++ b/include/net/mana/mana.h
> >> @@ -40,8 +40,8 @@ enum TRI_STATE {
> >> #define COMP_ENTRY_SIZE 64
> >>
> >> /* This Max value for RX buffers is derived from __alloc_page()'s max page
> >> - * allocation calculation. It allows maximum 2^(MAX_ORDER -1) pages. RX buffer
> >> - * size beyond this value gets rejected by __alloc_page() call.
> >> + * allocation calculation. It allows maximum 2^(MAX_PAGE_ORDER -1) pages. RX
> >
> > Should it reference MAX_ORDER_NR_PAGES instead?
>
> It is fixed in v2[1].
It is not :)
My point is that 2^MAX_PAGE_ORDER is MAX_ORDER_NR_PAGES.
But v2 is good enough.
--
Kiryl Shutsemau / Kirill A. Shutemov
prev parent reply other threads:[~2026-08-20 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 12:24 [PATCH] mm: drop stale MAX_ORDER references Qi Xi
2026-08-18 19:19 ` Zi Yan
2026-08-20 13:27 ` Kiryl Shutsemau
2026-08-20 13:52 ` Zi Yan
2026-08-20 15:00 ` Kiryl Shutsemau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aocWWrK_K1iCtq4P@thinkstation \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=brendan.jackman@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=jan.kiszka@siemens.com \
--cc=kbingham@kernel.org \
--cc=kotaranov@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mhocko@suse.com \
--cc=netdev@vger.kernel.org \
--cc=sunnanyong@huawei.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=xiqi2@huawei.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox