From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E61AC5DF9B for ; Mon, 24 Aug 2026 12:36:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 555366B0092; Mon, 24 Aug 2026 08:36:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5067D6B0096; Mon, 24 Aug 2026 08:36:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CDEE6B00A1; Mon, 24 Aug 2026 08:36:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 185D66B0092 for ; Mon, 24 Aug 2026 08:36:10 -0400 (EDT) Received: from smtpin03.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 979DDA00F1 for ; Mon, 24 Aug 2026 12:36:09 +0000 (UTC) X-FDA: 85136110458.03.78CB1A8 Received: from flow-a2-smtp.messagingengine.com (flow-a2-smtp.messagingengine.com [103.168.172.137]) by imf09.hostedemail.com (Postfix) with ESMTP id 9CD34140003 for ; Mon, 24 Aug 2026 12:36:07 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="X NwaLhE"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=lAaqQiL6; spf=pass (imf09.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.137 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1787574967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Halq/ghpcpjzwRr3hDl5BiBIUuH+KlXyRVEyX5gTykY=; b=f71ji4mLllnX7CrS394DRi35PfkgTEJ4SjAwI3WxHgGsSYX7ChQbEunyETKgjFDGRknZHZ PRyr8rqxgkOFIycAsv1oGb9epAJiZE/Hb/4ewKX1EFC25lnSbtvFW+od4atZlFIv15RHiR sdrvKimgRgqwvglviWQ8rPpNY/DiKnQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="X NwaLhE"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=lAaqQiL6; spf=pass (imf09.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.137 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1787574967; b=3GzDWSd3AkoHCc56AObASSXRrbOTZsh9SqcsnNjpVO8ur2KUgwZHquRn2ZK11aRyxr9jQT F3Ptl38lVaEw9qjFf1/j5n1P1ZV9jsPE2PsSrWkXtCzgmD0sld2hEhZnLNoh3UblgydZ5r yfeauLM6J9AqauTkuxi22xqkQDoKdrw= Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailflow.phl.internal (Postfix) with ESMTP id E7350138016E; Mon, 24 Aug 2026 08:36:06 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Mon, 24 Aug 2026 08:36:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1787574966; x= 1787582166; bh=Halq/ghpcpjzwRr3hDl5BiBIUuH+KlXyRVEyX5gTykY=; b=X NwaLhEt6lreAhnuNhuYe63yeUnz+8ExWqYEdcHnZCISOYS8/qXsSqpifilTYi1DI 8zo2jldWxtdl4pD8CJlIWfW9CG/NLLGislyFEzxc3gzE9Yf9vKZSoWATbHtVUMxQ pivnCFwCWoYAl1Kpqp9SO79QylBp6KTbJlexw+k2icgNKIdtoG8AMZmQvEEVak7X JRDIwY0ypINns7AT7bbRaSwSxfEBKxeXJJ8Q6sMLS/8QluI+Lwkriup7kOIe6fb8 58GK2W8pKO+y7ajxH7O/eM8O8EaWbu9GYQnEFaSjLPOgpGhdzTs6S6cgOOwcPVV9 aNDMMTqSAif9XoQFllo4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1787574966; x=1787582166; bh=Halq/ghpcpjzwRr3hDl5BiBIUuH+KlXyRVE yX5gTykY=; b=lAaqQiL6lDNBiMyO3Z7e08OKXhMvrp5xhkZoYhMTbb/j8K7Q329 myZFj4BjPqbhIsI3djhffaIuvqkSsnJ8wXjKI7dH98N6En7feIz1tXfLNQmVmJd6 nJ21tQdjsbSYIyWbYWDiSmCK7iw/M0dtpn4CwgiBH8okjUQ3bbmk7f9ecL34EiN+ 8bxghrtPFKX5rXtR3ph4tfwUWzA1IZ1XnHFYLoVV25mbsCuw6r/boNFnBbMwYEXX 8dZSpP1c5BnbPIPoAf3KxbAHMTz74Rj7HAqwKRiU8WNXfuH9jBlI2IuPSO4rI0Fd qZsLujEYC79xHlTreIQjbkgjfdpoYzJR2IA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTF5asgg6APcHCRRNjBCQ9gXGuK668V8MVNtl2aHA4haIibMMp4f3mU+yDh2HpFJDp VGKvyfsEX1iisUN0oqJLUZfcpBudESliKqaFOjN29FGcLMQCGn8WzCD04M2gPcqh2jOXxq TWnruryoiEaOIooipC/o5/MDxXkEEbgRERWfvB3dt8tPQpH9AFStR2lQR4bB9O3re0vryU 7C3LwMzGnKw6zBjJF0G+xJ+GRjs7okbNLLc8dp5YQcQK5Six3viX2tWrqs2p/aeuTnIIcM Q8+LtpYicGcP7U1JC54V/izDp1hRw8aC/tlX4mikhZ5SOri7gblL2enAiIAFgJxVoWjAYY Rfval5jE8DZcqhBmfu0ydqxPIOi/NiYqlAU11QhGJpMeHrURgNFF2OA0S8Ysz6Jwt9ats/ B4EHeVDTOLRJebKUiFqIyvIcqp04ZI0LJ32DM0NNSWN1L+XUHuXgFR98hTlXAVgUsCZk/n eq8r//W+ksz63YcYPzIZ9w+9KtMOse/d+yVYekz7F0doIARM/tnzGwBbW+SJVbcaaVmUx+ qe8/cKpSB64Vme+mQdTDfUZmVf8g7sD0N5nZvbxzExcHVwh2xL2wdI2WJw6LjYdDcsn+ct Cu+PTZpzEPcBo00oDOWorqPCg/9nbFDNRZH4MoaEEgLwR5PdW4ACMKPIzUbg X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 Aug 2026 08:36:04 -0400 (EDT) Date: Mon, 24 Aug 2026 13:36:03 +0100 From: Kiryl Shutsemau To: "David Hildenbrand (Arm)" Cc: akpm@linux-foundation.org, ljs@kernel.org, nico.pache@linux.dev, baolin.wang@linux.alibaba.com, baohua@kernel.org, dev.jain@arm.com, hughd@google.com, lance.yang@linux.dev, liam@infradead.org, mhocko@suse.com, rppt@kernel.org, ryan.roberts@arm.com, shuah@kernel.org, surenb@google.com, usama.arif@linux.dev, vbabka@kernel.org, ziy@nvidia.com, usama.anjum@arm.com, agordeev@linux.ibm.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, jannh@google.com, willy@infradead.org, pfalcato@suse.de, rostedt@goodmis.org, mhiramat@kernel.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [RFC PATCH 03/57] mm/collapse: add collapse.h for the shared collapse state Message-ID: References: <20260816224609.308019-1-kirill@shutemov.name> <20260816224609.308019-4-kirill@shutemov.name> <3113ac8b-c1ce-4577-9e93-449b70818918@kernel.org> <65433d1e-95ca-4434-828e-8f381d3384b1@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9CD34140003 X-Stat-Signature: tx367k98gdcf5j3mct7mjjdn7aaj67u7 X-Rspam-User: X-HE-Tag: 1787574967-816188 X-HE-Meta: U2FsdGVkX1+arZTPKXl3pkX779jtMth19/RCR4GxI25m1SV36Q3OCzpFrqSQUxzKpJPT//6T+SFtUUl4FKt5vb0jZENd7FTgjtihxK80ozFc5O6awkMPKQ9/mpKYyol6XA7zN9nauz2vvn1a+laDLT6b/IkFMpWQ1eNKGX+CpCqrQdacW1/QOAawOJezNez3T9MHxGHT6uKArSidxFG0GkzSKwR2QQYXUxJB52i3SGBXPoYfypKXnRNITYGjRlgxjgCbwU0I1Ea3L8ZLEa8GeRLHdj1No4wwNFh0z9oNPWNpaqnL/jGGCrgniIzmVr96+vB9pPZLmKa5yuxXq1ijVJjqcbKpdA6q6FUm12F3mqmiDPbBtEOAL4VTBBZyAu8pu6YU3l89+aypvnlFx/g26mVD2FMSAUuixUsZZP5p0z4WNV0ss19+ckDDbN+/bjV2cfUcPlSBYviifew5T4S8U5cQBSxphahcabJDUH3dHskTUl4HaUdw2UaOJHqLFh+VwRPI/98sl3edgK8YOahB9PIP4CtnJl1Sd/+e/FVNpGzv7fyEc6sbusr2xbyS4KxTwKE9WhtIwqYdgr9kgbCLusCqHNERT2fJxh76EyEObYRYMS1LWrjTTWetL2BarXkX0Tg8tYlzU4c1YM1/k+hnvHNaPB8PBGXINxBf+aBuz1PEpBbizbGtMWaW5Fs/gsIfOpy9XqvjL9XGo0vX03XqhPfCvChakJdSQJlEtJA++7qMs3OTJSdcFrpUeFmX8QTyENw2QBdCqlEXJjYKnAJX2a4ybI8d7+fxxSH/MNyvbaTXizqjrOeVuYrehWUELvdJ+bto+ZyrIxU1shU9pR3Ru4mKCX85jQb/6hzFi8wmXseVsRAcjdh7hd9hXElwll+FwsmfuYFoYQUle+eW9gSlUhtwH+xb3H2qkIUlmUkXN4hjWjFQjLWiORLbEbVNpwZi2w9GWenMbni0d/NdLCl 5upHtYQj 4NhuTg2N18+8aN051K6ovCUehN9U6UDskEK11QKIv+KQSMX6j1AlxYwzcpBKC2eVZ7MKeg6rKzZa1MGvANuLnrJq2ljIw/kIigalcuohk3iVZAOjSBCliAp8xaIapyIYX/w6jOYy2Rf1MwZrRXN0Y5+BFnGex5ae/6vbFCDEQKm6TkJ4VLVSxs9qW7YOkWq4Tsjs9aIN8YA/NTMkKSW3aCRmvUig5zlbhjm2AJWxOIXPYy8MH4NoPj5TvQg9F7kvZJJlni2vU1z2GZ1gaXsBY1ILrLi+Piqr0TO43Ad43sscW4svlDbqosKEHC5h9j2YCogWL6Fsua3KxpQ2KO7aN2Wrjlwr6/2uH/Ib6ILGdxabcOxS8iA2Ax17LersWHLp4rhM0G3n29EsojC1HvOX5/iuMrT9ahH37Z7kRFYUxltAwP8z37JFZ66OZ/axiFW6fuWyY Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 24, 2026 at 02:28:39PM +0200, David Hildenbrand (Arm) wrote: > On 8/24/26 14:10, Kiryl Shutsemau wrote: > > On Mon, Aug 24, 2026 at 01:47:54PM +0200, David Hildenbrand (Arm) wrote: > >> On 8/20/26 13:11, Kiryl Shutsemau wrote: > >>> > >>> I went for a clean collapse.c on purpose: the engine is new code, and a > >>> new file keeps it readable while both mechanisms are in the tree, with 28 > >>> as a plain delete from khugepaged.c. > >>> > >>> Your shape is less churn, though, and it keeps blame: 29-35 move about > >>> 1700 lines as add-and-delete today, and most of that would stay put, with > >>> only the daemon -- mm_slot, the scan loop, sysfs -- extracted into a new > >>> khugepaged.c. > >>> > >>> If you prefer it that way, I can give it a try for v2. > >>> > >>> The rename has to open the series, so it will collide with anything in > >>> flight that touches khugepaged.c. > >>> > >> > >> Kiryl, I have to ask, are you using AI to write your replies? > > > > Yes. I use it check my claims and fix my grammar. > > > > Why? > > > > It doesn't read the way you would usually write. In a bad way. > > E.g., "Your shape", "has to open the series" > > Consider telling the LLM to not change your writing style and focus only on > fixing grammar. Right. Asking for rewrite with proper grammar was a bad move on my part. -- Kiryl Shutsemau / Kirill A. Shutemov