Re: [PATCH] mm/secretmem: Fix the enable parameter description

[Mike Rapoport <rppt@kernel.org>]

On Sun, Sep 06, 2026 at 07:15:23PM +0200, Karl Mehltretter wrote:
> The module parameter is enable, but its MODULE_PARM_DESC() names the
> variable behind it, secretmem_enable, so modinfo describes a parameter
> that does not exist and shows no description for the real one.

Hmm, does modinfo show secretmem description at all?
 
> Use the parameter name in the description.
> 
> Fixes: 1507f51255c9 ("mm: introduce memfd_secret system call to create "secret" memory areas")
> Assisted-by: LLM

Please use the form described in 

https://docs.kernel.org/process/coding-assistants.html#attribution

> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>

Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

> ---
>  mm/secretmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/secretmem.c b/mm/secretmem.c
> index 384f5cfc457f..4e32bf55a599 100644
> --- a/mm/secretmem.c
> +++ b/mm/secretmem.c
> @@ -39,7 +39,7 @@
>  
>  static bool secretmem_enable __ro_after_init = 1;
>  module_param_named(enable, secretmem_enable, bool, 0400);
> -MODULE_PARM_DESC(secretmem_enable,
> +MODULE_PARM_DESC(enable,
>  		 "Enable secretmem and memfd_secret(2) system call");
>  
>  static atomic_t secretmem_users;
> 
> base-commit: 986c24e0fe44f844b44d365b71ce831947f50298
> -- 
> 2.53.0
> 

-- 
Sincerely yours,
Mike.