Re: [PATCH v4] selftests/mm: hugetlb_madv_vs_map: add underflow test

[Breno Leitao <leitao@debian.org>]

On Fri, Sep 04, 2026 at 09:34:19PM +0200, Guillaume Morin wrote:
> Add a test that checks for underflows when a parent unmaps the page
> first. Also check that when the child exits the reserve count is
> correct.
> 
> Link: https://lore.kernel.org/all/alEJkwn5VlTTH_ZX@bender.morinfr.org/
> Signed-off-by: Guillaume Morin <guillaume@morinfr.org

it seems you are missing a > at the end of your email.

> Cc: Breno Leitao <leitao@debian.org>
> Cc: Mike Rapoport <rppt@kernel.org>

Reviewed-by: Breno Leitao <leitao@debian.org>

> diff --git a/tools/testing/selftests/mm/hugetlb_madv_vs_map.c b/tools/testing/selftests/mm/hugetlb_madv_vs_map.c
> index f94549efcc6f..d89b2c27c2ae 100644
> --- a/tools/testing/selftests/mm/hugetlb_madv_vs_map.c
> +++ b/tools/testing/selftests/mm/hugetlb_madv_vs_map.c
> @@ -3,25 +3,16 @@
>   * A test case that must run on a system with one and only one huge page available.
>   *	# echo 1 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages
>   *
> - * During setup, the test allocates the only available page, and starts three threads:
> - *  - thread1:
> - *	* madvise(MADV_DONTNEED) on the allocated huge page
> - *  - thread 2:
> - *	* Write to the allocated huge page
> - *  - thread 3:
> - *	* Try to allocated an extra huge page (which must not available)
> - *
> - *  The test fails if thread3 is able to allocate a page.
> - *
> - *  Touching the first page after thread3's allocation will raise a SIGBUS
> - *
>   *  Author: Breno Leitao <leitao@debian.org>
>   */
> +#include <limits.h>
>  #include <pthread.h>
> +#include <signal.h>

nit: Are limits.h and signal.h ever used by yor new code?