From: Mike Rapoport <rppt@kernel.org>
To: Muchun Song <muchun.song@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
sashiko-reviews@lists.linux.dev, Sashiko <sashiko-bot@kernel.org>,
Muchun Song <songmuchun@bytedance.com>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Chris Down <chris@chrisdown.name>,
David Hildenbrand <david@kernel.org>,
"Liam R . Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Brendan Jackman <brendan.jackman@linux.dev>,
Zi Yan <ziy@nvidia.com>, Joerg Roedel <joerg.roedel@amd.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Pranjal Shrivastava <praan@google.com>,
Ketan <ketan.kishore@oss.qualcomm.com>,
Mostafa Saleh <smostafa@google.com>,
Sang-Heon Jeon <ekffu200098@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
kasan-dev@googlegroups.com, linux-mm@kvack.org
Subject: Re: [PATCH v2 2/7] mm/page_ext: fix client data alignment
Date: Wed, 18 Nov 2026 15:40:49 +0200 [thread overview]
Message-ID: <av2q4RAESvKh0chV@kernel.org> (raw)
In-Reply-To: <11DE08A1-5F83-4BE2-B8C0-B426441A957A@linux.dev>
On Wed, Nov 18, 2026 at 01:39:04PM +0800, Muchun Song wrote:
>
>
> > On Nov 18, 2026, at 12:21, Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > On Wed, 18 Nov 2026 11:49:58 +0800 Muchun Song <muchun.song@linux.dev> wrote:
> >
> >>
> >>
> >>>>> +}
> >>>>
> >>>> [blah blah]
> >>>>
> >>>
> >>> Yeah, but the whole expression is quite reader-hostile, as min/max
> >>> things often are.
> >>>
> >>> How about doing
> >>>
> >>> /* comment */
> >>> if (this1)
> >>> return that1;
> >>> /* comment */
> >>> if (this2)
> >>> return that2;
> >>> /* comment */
> >>> if (this3)
> >>> return that3;
> >>>
> >>> ?
> >>>
> >>> The code generation will probably be just as good and it's __init-time
> >>> stuff anyway.
> >>
> >> Something like?
> >>
> >> static inline size_t page_ext_data_alignment(size_t size)
> >> {
> >> /* No client data means no alignment requirement. */
> >> if (!size)
> >> return 1;
> >>
> >> /* u64 has the strictest alignment required by page_ext clients. */
> >> if (IS_ALIGNED(size, __alignof__(u64)))
> >> return __alignof__(u64);
Maybe add a const local for __alignof__(u64)?
No strong feelings about it.
> >>
> >> /*
> >> * A type's size is a multiple of its natural alignment, so its
> >> * lowest set bit is at least that alignment.
> >> */
> >> return 1UL << __ffs(size);
> >> }
> >
> > Well I prefer it!
> >
> > The final bit-twiddle could be (size & ~size) but I'm not sure that's
> > any clearer.
> >
> > We should have a handy helper for this operation but I can't find one.
> > max_pow_of_two_factor() is close, but only works on uint.
>
> How about changing the helper to
>
> #define max_pow_of_two_factor(n) ({ \
> typeof(n) __n = (n); \
> static_assert(__same_type(__n, 0U) || __same_type(__n, 0UL)); \
> __n & -__n; \
> })
>
> ?
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-11-18 13:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 12:06 [PATCH v2 0/7] KMSAN: Move per-page metadata out of struct page Muchun Song
2026-11-17 12:06 ` [PATCH v2 1/7] kmsan: encapsulate per-page metadata access Muchun Song
2026-11-17 12:06 ` [PATCH v2 2/7] mm/page_ext: fix client data alignment Muchun Song
2026-11-17 19:36 ` sashiko-bot
2026-11-17 19:46 ` Andrew Morton
2026-11-18 3:49 ` Muchun Song
2026-11-18 4:21 ` Andrew Morton
2026-11-18 5:39 ` Muchun Song
2026-11-18 5:51 ` Andrew Morton
2026-11-18 5:57 ` Muchun Song
2026-11-18 13:40 ` Mike Rapoport [this message]
2026-11-17 12:06 ` [PATCH v2 3/7] mm/page_ext: always use vmalloc for section page extensions Muchun Song
2026-11-18 13:43 ` Mike Rapoport
2026-11-17 12:06 ` [PATCH v2 4/7] mm/page_ext: use common allocation and initialization entry points Muchun Song
2026-11-18 14:18 ` Mike Rapoport
2026-11-17 12:06 ` [PATCH v2 5/7] mm/page_ext: allocate page extensions early for SPARSEMEM Muchun Song
2026-11-18 0:06 ` Chris Down
2026-11-18 3:11 ` Muchun Song
2026-11-18 7:00 ` Chris Down
2026-11-18 14:17 ` Mike Rapoport
2026-11-18 14:22 ` Mike Rapoport
2026-11-17 12:06 ` [PATCH v2 6/7] mm/page_ext: inline unchecked page extension lookup Muchun Song
2026-11-17 12:06 ` [PATCH v2 7/7] kmsan: fix metadata loss during HugeTLB struct page reinitialization Muchun Song
2026-11-18 0:06 ` [PATCH v2 0/7] KMSAN: Move per-page metadata out of struct page Chris Down
2026-11-18 3:12 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av2q4RAESvKh0chV@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baolu.lu@linux.intel.com \
--cc=brendan.jackman@linux.dev \
--cc=chris@chrisdown.name \
--cc=corbet@lwn.net \
--cc=david@kernel.org \
--cc=dvyukov@google.com \
--cc=ekffu200098@gmail.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=hannes@cmpxchg.org \
--cc=joerg.roedel@amd.com \
--cc=kasan-dev@googlegroups.com \
--cc=ketan.kishore@oss.qualcomm.com \
--cc=liam@infradead.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=praan@google.com \
--cc=rdunlap@infradead.org \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
--cc=smostafa@google.com \
--cc=songmuchun@bytedance.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox