Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Shivank Garg <shivankg@amd.com>,
	David Hildenbrand <david@kernel.org>,
	Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Brendan Jackman <brendan.jackman@linux.dev>,
	Zi Yan <ziy@nvidia.com>, Luiz Capitulino <luizcap@redhat.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/page_ext: remove unused page_ext_iter_get()
Date: Wed, 18 Nov 2026 15:39:36 +0200	[thread overview]
Message-ID: <av2qmOfuu9QMny5o@kernel.org> (raw)
In-Reply-To: <5541ef01-f9c0-4ce1-b77a-5bb81c6cfdd4@kernel.org>

On Wed, Nov 18, 2026 at 11:10:45AM +0100, Vlastimil Babka (SUSE) wrote:
> On 11/17/26 20:13, Andrew Morton wrote:
> > On Tue, 17 Nov 2026 19:50:09 +0100 "Vlastimil Babka (SUSE)" <vbabka@kernel.org> wrote:
> > 
> >> On 11/17/26 17:26, Shivank Garg wrote:
> >> > It was added in commit 9039b9096ea2 ("mm: page_ext: add an iteration API
> >> > for page extensions") but has never had a caller.
> >> > 
> >> > Signed-off-by: Shivank Garg <shivankg@amd.com>
> >> 
> >> Added to page_alloc.git for-next, thanks!
> > 
> > Thanks.  Helps.
> > 
> >> Hm page_ext.h should be added to the PAGE ALLOCATOR section. Wonder if
> >> Andrew's patches adding various missing bits included that too.
> > 
> > Nope.  I'll add the below.
> > 
> > A few things under mm/ include page_ext.h so perhaps more mentions are
> > needed.
> 
> Thanks! Stuff that includes it are its users and not necessarily page
> allocator itself. Nothing jumped at me.

The whole initialization part is in a way mm_init ;-)
 
> > I'm presently carrying no patches which alter page_ext.h or page_ext.c
> > 
> > 
> > 
> > From: Andrew Morton <akpm@linux-foundation.org>
> > Subject: MAINTAINERS: add page_ext.h to MEMORY MANAGEMENT - PAGE ALLOCATOR
> > Date: Tue Nov 17 11:05:44 AM PST 2026
> > 
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > Cc: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
> 
> Acked-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>
> 
> > 
> >  MAINTAINERS |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > --- a/MAINTAINERS~a
> > +++ a/MAINTAINERS
> > @@ -17779,6 +17779,7 @@ F:	include/linux/compaction.h
> >  F:	include/linux/gfp.h
> >  F:	include/linux/page-isolation.h
> >  F:	include/linux/pageblock-flags.h
> > +F:	include/linux/page_ext.h
> >  F:	include/trace/events/compaction.h
> >  F:	include/trace/events/page_isolation.h
> >  F:	include/trace/events/page_ref.h
> > _
> > 
> 

-- 
Sincerely yours,
Mike.


  reply	other threads:[~2026-11-18 13:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 16:26 [PATCH v2] mm/page_ext: remove unused page_ext_iter_get() Shivank Garg
2026-11-17 17:04 ` Zi Yan
2026-11-17 18:50 ` Vlastimil Babka (SUSE)
2026-11-17 19:13   ` Andrew Morton
2026-11-18 10:10     ` Vlastimil Babka (SUSE)
2026-11-18 13:39       ` Mike Rapoport [this message]
2026-11-18  2:19 ` Luiz Capitulino
2026-11-18 12:15 ` Lorenzo Stoakes (ARM)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av2qmOfuu9QMny5o@kernel.org \
    --to=rppt@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=brendan.jackman@linux.dev \
    --cc=david@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=luizcap@redhat.com \
    --cc=mhocko@suse.com \
    --cc=shivankg@amd.com \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox