Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alistair Popple <apopple@nvidia.com>
To: Zenghui Yu <zenghui.yu@linux.dev>
Cc: linux-mm@kvack.org, jgg@ziepe.ca, leon@kernel.org,
	 akpm@linux-foundation.org, david@kernel.org, liam@infradead.org,
	vbabka@kernel.org,  rppt@kernel.org, mhocko@suse.com,
	balbirs@nvidia.com
Subject: Re: [PATCH] selftests/mm: hmm: give migrate_remap_fault a longer timeout
Date: Fri, 20 Nov 2026 09:31:23 +1100	[thread overview]
Message-ID: <av94SXo6ZAU7Z5TR@nvdebian.thelocal> (raw)
In-Reply-To: <20261119133955.54001-1-zenghui.yu@linux.dev>

On 2026-11-20 at 00:39 +1100, Zenghui Yu <zenghui.yu@linux.dev> wrote...
> From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
> 
> migrate_remap_fault sizes its working set from the PMD page size and runs
> 24 combinations of migration/mremap parameters.  On arm64 with 64K base
> pages the PMD size is 512MB, so the test churns through tens of gigabytes
> of memory and takes ~32 seconds on my test machine.  This just exceeds the
> kselftest harness's 30s default per-test timeout (TEST_TIMEOUT_DEFAULT),
> and the test gets killed with "Test terminated by timeout" even though it
> is making steady progress.
> 
> Raise the timeout to 120 seconds via TEST_F_TIMEOUT, so that the test can
> run to completion on configurations with large PMD sizes.

I guess the alternative is to reduce the number of test combinations, but that
seems like it would reduce coverage so this seems reasonable. Adding Balbir to
CC in case he has thoughts though.

Reviewed-by: Alistair Popple <apopple@nvidia.com>

> Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>
> ---
>  tools/testing/selftests/mm/hmm-tests.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/hmm-tests.c b/tools/testing/selftests/mm/hmm-tests.c
> index e5f273ca84c1..840015cdd209 100644
> --- a/tools/testing/selftests/mm/hmm-tests.c
> +++ b/tools/testing/selftests/mm/hmm-tests.c
> @@ -2221,7 +2221,7 @@ TEST_F(hmm, migrate_partial_unmap_fault)
>  	}
>  }
>  
> -TEST_F(hmm, migrate_remap_fault)
> +TEST_F_TIMEOUT(hmm, migrate_remap_fault, 120)
>  {
>  	struct hmm_buffer *buffer;
>  	unsigned long npages;
> -- 
> 2.56.0
> 
> 


      parent reply	other threads:[~2026-11-19 22:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 13:39 [PATCH] selftests/mm: hmm: give migrate_remap_fault a longer timeout Zenghui Yu
2026-11-19 13:54 ` Zenghui Yu
2026-11-19 22:31 ` Alistair Popple [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av94SXo6ZAU7Z5TR@nvdebian.thelocal \
    --to=apopple@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbirs@nvidia.com \
    --cc=david@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=vbabka@kernel.org \
    --cc=zenghui.yu@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox