From: Kiryl Shutsemau <kirill@shutemov.name>
To: Pedro Falcato <pfalcato@suse.de>
Cc: "David Hildenbrand (Arm)" <david@kernel.org>,
sashiko-reviews@lists.linux.dev,
Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Hugh Dickins <hughd@google.com>, Chris Mason <mason@kernel.org>,
linux-mm@kvack.org, kernel-team@meta.com
Subject: Re: [PATCH] mm/memory: refuse to map page cache folios that are not uptodate
Date: Mon, 9 Nov 2026 11:58:18 +0000 [thread overview]
Message-ID: <avG1Rg8OyP74VIFV@thinkstation> (raw)
In-Reply-To: <avGwAfK4I31KAPHl@pedro-suse.tail5790ac.ts.net>
On Mon, Nov 09, 2026 at 11:37:42AM +0000, Pedro Falcato wrote:
> On Mon, Nov 09, 2026 at 11:32:44AM +0000, Kiryl Shutsemau wrote:
> > On Sat, Nov 07, 2026 at 07:17:52PM +0100, David Hildenbrand (Arm) wrote:
> > > > - [Medium] mm: missing folio_test_uptodate() recheck in
> > > > do_shared_fault() mkwrite path
> > >
> > > Kiryl, can you look into that?
> >
> > Yeah, that's legit. Will fix in v2.
>
> Related: https://lore.kernel.org/linux-mm/as-fqjiGj5T5NLOe@casper.infradead.org/
>
> At some point, if filesystems can randomly clear uptodate as a way to signal
> writeback failure (even without the folio lock!!), these kinds of checks can
> become a bit too error prone.
>
> Perhaps we need to address this problem first?
The clearers Sashiko pointed at (ext4, ecryptfs, ntfs) hold the folio
lock. Which one does it without?
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2026-11-09 11:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 14:43 [PATCH] mm/memory: refuse to map page cache folios that are not uptodate Kiryl Shutsemau
2026-11-07 14:43 ` sashiko-bot
2026-11-07 18:17 ` David Hildenbrand (Arm)
2026-11-09 11:32 ` Kiryl Shutsemau
2026-11-09 11:37 ` Pedro Falcato
2026-11-09 11:50 ` David Hildenbrand (Arm)
2026-11-09 11:58 ` Kiryl Shutsemau [this message]
2026-11-09 12:18 ` Pedro Falcato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avG1Rg8OyP74VIFV@thinkstation \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=hughd@google.com \
--cc=kernel-team@meta.com \
--cc=liam@infradead.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mason@kernel.org \
--cc=mhocko@suse.com \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox