From: Joshua Hahn <joshua.hahnjy@gmail.com>
To: Chris Down <chris@chrisdown.name>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@kernel.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <brendan.jackman@linux.dev>,
Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>,
Qi Zheng <qi.zheng@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH 2/3] mm/page_alloc: move the kswapd node skip check into a helper
Date: Mon, 16 Nov 2026 14:59:22 -0800 [thread overview]
Message-ID: <avuKTaBpfAmiR7Mu@devbig011.atn3.facebook.com> (raw)
In-Reply-To: <avt2RrtFc-G04JiJ@chrisdown.name>
On Mon, Nov 16, 2026 at 01:31:50PM -0800, Chris Down wrote:
> Hi Joshua,
>
> Joshua Hahn writes:
> >+ /* Lockless check, a stale result only affects zone selection */
> >+ if (waitqueue_active(&zone->zone_pgdat->kswapd_wait))
> >+ return false;
>
> Not a big deal, but now that the test is the other way round, this reads
> backwards against "If kswapd is already active on a node" in the comment
> above the function, because waitqueue_active() being true here means
> kswapd is asleep on kswapd_wait. Maybe say something like that
> kswapd is asleep, so nothing is reclaiming this? It needn't hold the patch
> up though.
Hi Chris,
Yeah, I agree that it's pretty confusing. I need to correct a typo in
3/3 anyways, and I think it would be best to spin up a new version in
this branch management transition time (instead of asking for a fixlet),
so I'll go ahead and spin up a v3 that addresses this.
> I've tested that this works well, so either way please feel free to add:
>
> Reviewed-by: Chris Down <chris@chrisdown.name>
> Tested-by: Chris Down <chris@chrisdown.name>
Thanks a lot for yor time in reviewing and testing this series. It means
a lot to me! Have a great day Chris,
Joshua
> Thanks!
>
> Chris
next prev parent reply other threads:[~2026-11-16 22:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 23:52 [PATCH 0/3] mm/page_alloc, vmscan: get_page_from_freelist cleanups Joshua Hahn
2026-11-13 23:52 ` [PATCH 1/3] mm/page_alloc: drop unused gfp_mask from zone_watermark_fast() Joshua Hahn
2026-11-14 1:17 ` SJ Park
2026-11-16 21:31 ` Chris Down
2026-11-16 21:59 ` Zi Yan
2026-11-16 23:36 ` Gregory Price (Meta)
2026-11-13 23:52 ` [PATCH 2/3] mm/page_alloc: move the kswapd node skip check into a helper Joshua Hahn
2026-11-14 1:45 ` SJ Park
2026-11-16 21:31 ` Chris Down
2026-11-16 22:59 ` Joshua Hahn [this message]
2026-11-16 22:08 ` Zi Yan
2026-11-16 23:36 ` Gregory Price (Meta)
2026-11-13 23:52 ` [PATCH 3/3] mm/vmscan: consolidate promo vs. high watermark checks Joshua Hahn
2026-11-14 1:49 ` SJ Park
2026-11-16 17:22 ` Joshua Hahn
2026-11-16 21:31 ` Chris Down
2026-11-16 22:10 ` Zi Yan
2026-11-16 23:37 ` Gregory Price (Meta)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avuKTaBpfAmiR7Mu@devbig011.atn3.facebook.com \
--to=joshua.hahnjy@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=brendan.jackman@linux.dev \
--cc=chris@chrisdown.name \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=qi.zheng@linux.dev \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox