Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Rik van Riel <riel@surriel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	 David Hildenbrand <david@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	 Suren Baghdasaryan <surenb@google.com>,
	Christoph Hellwig <hch@infradead.org>,
	 Yuan-Hao Hsu <aa9736195201@gmail.com>,
	John Hubbard <jhubbard@nvidia.com>,
	 Jason Gunthorpe <jgg@ziepe.ca>, Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH v5 5/8] mm/gup: break out gup_lookup_pte() helper
Date: Fri, 20 Nov 2026 17:33:28 +0000	[thread overview]
Message-ID: <awCD56Ncl5_Tjrl6@gremlin> (raw)
In-Reply-To: <89e41824f1371b5880029f264e19b5d0589ae22c.camel@surriel.com>

On Thu, Nov 19, 2026 at 10:04:04PM -0500, Rik van Riel wrote:
> On Tue, 2026-11-17 at 13:48 +0000, Lorenzo Stoakes (ARM) wrote:
> >
> > > +		need_no_page_table = true;
> >
> > This is set true but not used anywhere? This is dead code no? Am I
> > missing
> > something?
> >
> > Patches should be incremental but adding completely useless locals
> > incrementally
> > seems silly?
> >
> > > +	}
> > > +
> > >  	pte_unmap_unlock(ptep, ptl);
> > >  	return ret;
> >
> > I'm guessing you forgot to include the code that works with
> > need_no_page_table here?
>
> That code is in patch 7. The check isn't needed
> yet in patch 5, and it got shuffled wrong during
> some refactoring.
>
> In v6 the need_no_page_table thing will be in
> patch 7.

Right, I think I need to see it in context to judge really :) but obviously we
can't be introducing completely dead code like that, even incrementally.

>
> >
> > 'need_no_page_table' isn't a great name either. Maybe is_none or
> > something?
> >
> Maybe pte_is_none?

OK, let's see how that looks in context.

Since you've not replied to the rest of the reviews I will assume implicit 'ack,
will do's or what not on those? ;)

--
Cheers, Lorenzo


  reply	other threads:[~2026-11-20 17:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 21:01 [PATCH v5 0/8] mm/gup: walk and batch whole PTE tables in slow GUP Rik van Riel
2026-11-16 21:01 ` [PATCH v5 1/8] mm/gup: break out gup_fill_pages() helper Rik van Riel
2026-11-16 21:01 ` [PATCH v5 2/8] mm/gup: break out gup_flush_pages() helper Rik van Riel
2026-11-16 21:01 ` [PATCH v5 3/8] mm/gup: convert follow_page_mask() to return a long Rik van Riel
2026-11-16 21:01 ` [PATCH v5 4/8] mm/gup: split out folio grab-and-store helper Rik van Riel
2026-11-16 21:01 ` [PATCH v5 5/8] mm/gup: break out gup_lookup_pte() helper Rik van Riel
2026-11-17 13:48   ` Lorenzo Stoakes (ARM)
2026-11-20  3:04     ` Rik van Riel
2026-11-20 17:33       ` Lorenzo Stoakes (ARM) [this message]
2026-11-20 18:10         ` Rik van Riel
2026-11-20 19:01           ` Lorenzo Stoakes (ARM)
2026-11-16 21:01 ` [PATCH v5 6/8] mm/gup: return a huge page's full count from follow_page_mask() Rik van Riel
2026-11-16 21:01 ` [PATCH v5 7/8] mm/gup: walk multiple PTEs per follow_page_pte() call Rik van Riel
2026-11-16 21:01 ` [PATCH v5 8/8] mm/gup: batch contiguous same-folio PTEs into one refcount grab Rik van Riel
2026-11-17 13:30 ` [PATCH v5 0/8] mm/gup: walk and batch whole PTE tables in slow GUP Lorenzo Stoakes (ARM)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awCD56Ncl5_Tjrl6@gremlin \
    --to=ljs@kernel.org \
    --cc=aa9736195201@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=hch@infradead.org \
    --cc=jgg@ziepe.ca \
    --cc=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterx@redhat.com \
    --cc=riel@surriel.com \
    --cc=surenb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox