From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C90ECC83F1A for ; Thu, 17 Jul 2025 11:57:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5927D8D0009; Thu, 17 Jul 2025 07:57:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 569E86B00B4; Thu, 17 Jul 2025 07:57:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 432308D0009; Thu, 17 Jul 2025 07:57:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 303746B00B3 for ; Thu, 17 Jul 2025 07:57:42 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C9E161A019F for ; Thu, 17 Jul 2025 11:57:41 +0000 (UTC) X-FDA: 83673607122.16.64C04D9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 731994000D for ; Thu, 17 Jul 2025 11:57:38 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Fc8GEiO5; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752753458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=My2AqXE4xnmmjEO4LZUU3V6WANGEj/YaFS6BHmYoDAk=; b=gy+x+4rMuFKThTAbrHwFswr1DP1kfM4J3Wfjeul1rtuX6W9D1claXJpihQ21R5a7NKI+Z8 JREMs6QJAAS08tFSkYJHyU74iIcYb4rYqHJpdZJJLN0Dk1ru73Ykbsyi0Xvsndbui96XeL QgX83AiY6xE/uE4Vw5OkBD3tPksrzCI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752753458; a=rsa-sha256; cv=none; b=jOarQgUEuYmgBwu79lsWJf2KoNiTtI1pcpKEBlGV5XBwWrV9ax7qYlngN4acOzg+P0vwsm 0tTXXjbs5L9bUpSJtibnTvz/xqXh7XRlewTLT1hCIgp872/ka7hKeEliQU/hmlc2Avc0wh mMw/PxS/caZrAnPxi7LPIoI/iMG+jYo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Fc8GEiO5; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752753457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=My2AqXE4xnmmjEO4LZUU3V6WANGEj/YaFS6BHmYoDAk=; b=Fc8GEiO528xESiXlTGjp5SxsO7mrPO/yAfGtPDsTYrlrSBYm9d6scwSCHw+5BiMdptIsag 8kIVDcyqQVh3TU/yH6TKMpP6QwuxtnEhePUOiuW8nRuDzsrxJbzuQZ/KGLgTWPmdndb1Md 42zIpXT5MJoKfo6bCvOXt5mPdEkK5Q8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-160-wkIkzK4zPsKM6vYr94QrNg-1; Thu, 17 Jul 2025 07:57:36 -0400 X-MC-Unique: wkIkzK4zPsKM6vYr94QrNg-1 X-Mimecast-MFC-AGG-ID: wkIkzK4zPsKM6vYr94QrNg_1752753455 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a50816ccc6so542364f8f.1 for ; Thu, 17 Jul 2025 04:57:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752753455; x=1753358255; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=My2AqXE4xnmmjEO4LZUU3V6WANGEj/YaFS6BHmYoDAk=; b=L6Cdc/zfj0YpaFGXMK281QECD6pH0FxfAx7yHRa/+msSHnTSyt6okTVrqBufX09L5X UAv0M1xBOg2TiYPXzbbOMMN0mc61GQLNKHv/l+w4Lfm26FthLmvawVxO7XA8RjZEoVOx vnbyM4eurY+kS9gUbvsB6v3vPK51b3vdKigRfCvtL757CNPku3ifet7ABywZNyI3elsi iPoIcEHGjUeiuwO8wQEyGvzIMIiJyR05QGWFlS/4hOUtvftcAbX5cfQFe98u/NuNXttv dB/4WZ2mvDXmhqlJFMfEJp44tCzN5a3DPAu/OQ1LXaKVKTb5KVENEBV6XddmHa4+KhDj hbsQ== X-Forwarded-Encrypted: i=1; AJvYcCW7GWJliK6iwWOSTUPX5ChhYq9RulMud4UcYdZqKaegjrjYilWxYTlqPuVpn2ZYZO1zJczAwXit0w==@kvack.org X-Gm-Message-State: AOJu0YyNXuobyAYTugqhwJ1ggiURMReeY43qgHIenlYq/mvO8BkZ2uCX IH58ZXc3F8HoojF/BFvWMssPKkimjOewnsPUv3l8Pu4rVOOtWkzD1FYWMbqcsHqRdNLL4Ld0w9z r6VwqxpSbkppQf1ZYNSIWdqnzWgZ5Mj7iluxW2NHnznTY3gQriI4i/VA0uA6qnYI= X-Gm-Gg: ASbGncuHMofwmWEIpBtW6hPgHH08EMWn/Ujg4k8dQ6MBC4jQQ7PGGuG6cJM1JQJ1Cwf L467yZiy1TmnMiWAlIrxTNBN83iPV8cFSXyo6S3sKtQUPfIBLV6iSo0Gx4q54nAOZzpFfJWrbvb KyLnpR1TYr+Y89cWwKSpqS3gTGPY22GgqxDgs6TXJSJd/VyuO1Vf/7FRTgPidMSnEdt5uEMIckz yJ4xZ8ohCKJcsCzQhB94hqltGHi0z9ucMhoQVXSJ6lytofTsm8jCzxTEDm3SVzNlWmyNbHyxemZ TyjflsphC2RZ1ojz6bmu6+p33cHP1flaOekUnFWrumqc8KZif5UiQpZgBl2/3VXH3eNPLrivCRj kdQ2dfz5F6zzy4stM/eWjwW5GWzNXO7KIXhHMkeFcKrg/OWsWb/KG3lYpEYrDMkJf X-Received: by 2002:a05:6000:2482:b0:3a5:5fa4:a3f7 with SMTP id ffacd0b85a97d-3b60e54a361mr4802405f8f.58.1752753455359; Thu, 17 Jul 2025 04:57:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGFWygPfQePaxc5Af1QzQYcoD1lpdZlquzmtHjuNy8dQxekIcXTIRigCRe1c08W3cr08QP6tg== X-Received: by 2002:a05:6000:2482:b0:3a5:5fa4:a3f7 with SMTP id ffacd0b85a97d-3b60e54a361mr4802383f8f.58.1752753454850; Thu, 17 Jul 2025 04:57:34 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1f:3600:dc8:26ee:9aa9:fdc7? (p200300d82f1f36000dc826ee9aa9fdc7.dip0.t-ipconnect.de. [2003:d8:2f1f:3600:dc8:26ee:9aa9:fdc7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e0d872sm20718261f8f.60.2025.07.17.04.57.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 04:57:34 -0700 (PDT) Message-ID: Date: Thu, 17 Jul 2025 13:57:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] selftests/mm: put general ksm operation into vm_util To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, Lorenzo Stoakes , Rik van Riel , "Liam R . Howlett" , Vlastimil Babka , Harry Yoo References: <20250716082710.2801-1-richard.weiyang@gmail.com> <20250716082710.2801-3-richard.weiyang@gmail.com> <5cadce02-cd80-4aa2-a078-6335beeb8a92@redhat.com> <20250717024504.3b4q3i6uuzd4nr2w@master> <20250717033031.rts7keqjrt6jc77t@master> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250717033031.rts7keqjrt6jc77t@master> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uYu8beeBcxzprisfF88L9yYz7fHJ-g_vxRIOeHAAEC4_1752753455 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 731994000D X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: tkmimr6fec7f5m7169fp4x9mg11yo49j X-HE-Tag: 1752753458-76121 X-HE-Meta: U2FsdGVkX1/gmyBzjfQ6cSwg97EtVI+NV/aJd20Umh22oDoy5e9r03wkC7aRVY+9JMLiZFsesPjB+xRiU3Y+mIYiwjR4V54h/OLe9q0r+6oYx3ZeZmjiLKVmDsLzBC4Mh1x2fpHjgi4ru3/FN/i6Mfk82tX1R28DplQHKt94DOyM8HI1/uvte1TuxwpuleZWCCRzpxuGQEw9iyQDzqTPL1Bok2w6sQo6QsXQZWStmHQ7Rbe105zdor5NsrNbPvi44ClpdKjY/LkxViVUTq2IduwLkcKeQm9Q6cIknM9UEXPQjEv6UOyGBraOf7usYH9v7CNWfc5x/POXN9JaLp60LrAjfsHuyCxuxfrcFU8DgjhOqw3uc4c/zlku6qCu/Z6mlMbqncE5e0H11UprXfKlthvvKFf40bAesniIXUZtYaoFppKgi8HibIJsRkqhSZMElVg6uk6a4w07Fd/UoNSYOnnuyCNM5v2D2Jb9Ra0HMFlFyv3sjOUhuvNeJWRTz46z5vrIPMhKylKIPUGh1kEY4Y57cSIPm4XEHqHJGEWhzQ/BBVMbniTP+i9oyH1jgXSwLTKKlN0Z4vvJKPvPorhuatw6ZnF9eW4fj1zhZxbztx6jlKT3Mi536hfi4h0lwR+2B5nNmPUZg6iQvxxrX2KxsDMIF9y/mIcloh02uo3jejiIuQbCIk/1WC86dse1A5ygce78F/xyVQGAL/X+y5Ly5oPRgZyCocmcafVlw+w+lc/TE1mEpJaBr6ZydhbubbTR7AwulIy2CJMGmlMDumBfGg/+4E4TzLYqoSKWoJXmGBoUclVrKqmM83TRgcpUAVwQ85T3Aqn2e0bOSNpqbDkBcxcgAZs6Iral26KtNRjeIUAutsytT44cq8zljUPsy1PGbsxdvf4w7q0/0zbVC34agj2c/vL+cPF4ipeR+3I6i5IXOQ/cWJmnw+1SJZmcFriLGfdKI2jiL9wLnbxEd3m k1uRLivU XmctJGz1SRjFOC4ZMm6+qkpUz3XB+tRFyM1n4+VG932OefrgLxFerZllXr7YzMXgbzh5vWXSBnmylAqc80I/u9V4nyXddBauBKWIHNw11+miz7FXnznqqpl/OqAsWibxUI2DQcNiJCUvOE0FQcwOO6gjE73AKwMxcwQm4Hf3toNZuOxy5D0KsBg3a4akIT6qYVY5xBu6J/UGyNDVsM2eBBUVG+HKomrOy04mPY9C8XccYgH9+ZY/Ci6Kt0O41RE0fLWDJt6MqPwvfGZZQKtJhMjbNjq8F2ckKNaYNMIIwkOhgrY93d22FNRYwD3D4pnj1/sh3ZdRgkUI/9NQ/C0ge4OPd5cgOIP5E0mY5U+bBesUTTkx4nnO9YGOILsLRNZlWhWPwGbSXcWjK6OmA53twvLY3vGC2Cb8+qKIN7vzfiFlEionb5p3eNKXMJkRWhojaP0X38TNDq7T1P6RHq9GkKXIHi1RXEMJHkiuOEhIG1IF17txPCV0uO9GCMHAMs5v/lv7cFO3zBFRhS27if2IhBk5aQBST3tcIrZNpK2I5MIFxnuYz22tZi4iSEvi3FGuqyCWZqyqsIou9+qg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.07.25 05:30, Wei Yang wrote: > On Thu, Jul 17, 2025 at 02:45:04AM +0000, Wei Yang wrote: > [...] >> >> Looks reasonable, will remove it. >> >> So how about leave three helpers: >> >> ksm_merge() >> ksm_start() >> ksm_stop_and_unmerge() >> >> Would this be better? > > Or maybe we just export ksm_merge() and ksm_unmerge(). Leave ksm_start() as an > internal function, since only ksm_merge() use it. Either that or start/stop. Whatever you think is best. -- Cheers, David / dhildenb