From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zps35.corp.google.com (zps35.corp.google.com [172.25.146.35]) by smtp-out.google.com with ESMTP id lAA1Y9Wp003905 for ; Fri, 9 Nov 2007 17:34:09 -0800 Received: from rv-out-0910.google.com (rvbg11.prod.google.com [10.140.83.11]) by zps35.corp.google.com with ESMTP id lAA1Y9UL010204 for ; Fri, 9 Nov 2007 17:34:09 -0800 Received: by rv-out-0910.google.com with SMTP id g11so590121rvb for ; Fri, 09 Nov 2007 17:34:08 -0800 (PST) Message-ID: Date: Fri, 9 Nov 2007 17:34:08 -0800 From: "Ken Chen" Subject: Re: [patch] hugetlb: fix i_blocks accounting In-Reply-To: <20071109171613.3b11b581.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1194617837.14675.45.camel@localhost.localdomain> <1194631797.14675.49.camel@localhost.localdomain> <20071109171613.3b11b581.akpm@linux-foundation.org> Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: aglitke , linux-mm@kvack.org List-ID: On Nov 9, 2007 5:16 PM, Andrew Morton wrote: > On Fri, 09 Nov 2007 12:09:57 -0600 > aglitke wrote: > > > Thanks for that explanation. It makes complete sense to me now. > > We have a distressing number of hugetlb patches here: > > hugetlb-follow_hugetlb_page-for-write-access.patch > hugetlb-allow-sticky-directory-mount-option.patch > hugetlb-split-alloc_huge_page-into-private-and-shared-components.patch > hugetlb-split-alloc_huge_page-into-private-and-shared-components-checkpatch-fixes.patch > hugetlb-fix-quota-management-for-private-mappings.patch > hugetlb-debit-quota-in-alloc_huge_page.patch > hugetlb-allow-bulk-updating-in-hugetlb__quota.patch > hugetlb-enforce-quotas-during-reservation-for-shared-mappings.patch > mm-hugetlbc-make-a-function-static.patch > hugetlb-fix-i_blocks-accounting.patch > > (all available at http://userweb.kernel.org/~akpm/mmotm/) > > Could we please put heads together and work out which of these need to go > into 2.6.24? And 2.6.23, come to that... I would vote all of it. If we really need to prioritize them, I would list them in the following order: 1. fs quota fix: hugetlb-split-alloc_huge_page-into-private-and-shared-components.patch hugetlb-split-alloc_huge_page-into-private-and-shared-components-checkpatch-fixes.patch hugetlb-fix-quota-management-for-private-mappings.patch hugetlb-debit-quota-in-alloc_huge_page.patch hugetlb-allow-bulk-updating-in-hugetlb__quota.patch hugetlb-enforce-quotas-during-reservation-for-shared-mappings.patch 2. i_blocks accounting hugetlb-fix-i_blocks-accounting.patch 3. follow_hugetlb_page (this is a rather nasty bug, I'm glad we haven't hit it in real world. Or maybe Adam did, and hence the patch?). hugetlb-follow_hugetlb_page-for-write-access.patch 4. others (these are really simple single line low risk patches, why not?) hugetlb-allow-sticky-directory-mount-option.patch mm-hugetlbc-make-a-function-static.patch oh, there are more bugs in hugetlb: sys_mincore isn't working on hugetlb range. I guess that can wait for 2.6.25. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org