From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B01ADD0D785 for ; Fri, 11 Oct 2024 12:38:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DE656B00AD; Fri, 11 Oct 2024 08:38:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38EAB6B00AE; Fri, 11 Oct 2024 08:38:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E11A6B00B0; Fri, 11 Oct 2024 08:38:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E9A936B00AD for ; Fri, 11 Oct 2024 08:38:42 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 872B5ACAD6 for ; Fri, 11 Oct 2024 12:38:33 +0000 (UTC) X-FDA: 82661275242.25.EA74EBF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 2FBD540005 for ; Fri, 11 Oct 2024 12:38:37 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uuC8Ej9X; spf=pass (imf04.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728650250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RASB9N27wokk9ch5PAXdoLriAMxRmUMZEmMMdBiK1XE=; b=ks/yyQ3YV9gbSc7kBBL8RoMgZPJCYer2MRN7ixSo77FOaR3lpbR0weZj+DmghKnWYsJVqf uuYSqoqj2o10JKc5pMG7tjyeexTIQ17tuLbtAV1linurdbWYPmL/sXmYASf1Sw9K8FvVOa rFkoDozXJP5vxIdoa9lvXz3MJknQi5M= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uuC8Ej9X; spf=pass (imf04.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728650250; a=rsa-sha256; cv=none; b=1KtBP5jkWCNtPthSFwkSqAWVky3GQ5GUoT7AtMyKH1uvKr2rM1HOLVGBgMdrS9xuTacXQ8 YBWTGZDho9YxCkPy8VTiFe3AXbDRI78BFPi11dUmgm0ee4upEbpvsg4kRyXJb7YqHZBS/M jiAkvPjLyrfT4SP3TvO9hkpu4LXVclo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EBF105C5C9D; Fri, 11 Oct 2024 12:38:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1251FC4CEC3; Fri, 11 Oct 2024 12:38:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728650319; bh=foG8+vckoR1mQ2glQADILcmJ6jiSNlJ3mZrxtgFpCKk=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=uuC8Ej9XJA65Q2h/HJ7zNH1oU8lvpVAtFtS48dryytT/XrVJ/LyW5MZ53lg49WCiw rNjfKelnOyschGSmq+wW+393y0CW/TtXYHJ5w4zFaWFzu/JN5pKUHG9lBgXsokOJue /CbTAfeXBbGyd4Cag+CJJAcbm0pzFf6wUDQmbzaCDZE8SYCc4R0mWWbgsXzrWm7/cn 90luO8XQv/Cs4CtQhJuM7ntW7ECPYnLit7Y0bJ2EnGxTpr2Qjb1v2FMftKZylYqWh0 C6zJUTpqis466BBsctvPlIsmXmhFZHRJEeWKrtHy8JMYGbAsrw9kDZ43uFanLr37wv p+pTGFdQz/X5g== Message-ID: Subject: Re: [PATCH v3 -next 11/15] sunrpc: use vfs_pressure_ratio() helper From: Jeff Layton To: NeilBrown Cc: Kaixiong Yu , akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, paul@paul-moore.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, dhowells@redhat.com, haifeng.xu@shopee.com, baolin.wang@linux.alibaba.com, shikemeng@huaweicloud.com, dchinner@redhat.com, bfoster@redhat.com, souravpanda@google.com, hannes@cmpxchg.org, rientjes@google.com, pasha.tatashin@soleen.com, david@redhat.com, ryan.roberts@arm.com, ying.huang@intel.com, yang@os.amperecomputing.com, zev@bewilderbeest.net, serge@hallyn.com, vegard.nossum@oracle.com, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Date: Fri, 11 Oct 2024 08:38:32 -0400 In-Reply-To: <172859659591.444407.1507982523726708908@noble.neil.brown.name> References: <>, <12ec5b63b17b360f2e249a4de0ac7b86e09851a3.camel@kernel.org> <172859659591.444407.1507982523726708908@noble.neil.brown.name> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 2FBD540005 X-Stat-Signature: jbgj9746myt4stts5cwaeeqxkzcom6b6 X-HE-Tag: 1728650317-130469 X-HE-Meta: U2FsdGVkX18ih3EnPi6IwD64vOPH/T+feGqbyB+gfOv6RCYXef9DlhdyFE+zWmJtlMCkH+tQDH8S6Q4d8gIBdlafYNKRSfaT7jEAKCfhYecMJDgiXAD+danhu2Q2HaPSnacxmRnCQxExGBEs3/W/ZBjGp2/Buj8q80tiEx9WNUH5MkfY+C2TzSXFoJgiV3uXrj5vGhLw0bIYsZezPnY8FlIKGR8VuFQRUQFexDkLYRrqqrSCcnyVZdWavFQvMpmX0KyGcGO27DBZJzuzswLkBKqpb37b7t/3cRTce3sGeAW2zFa9EuhIIxvPvk2cl47mn6paRzfveCwKSDuLj1Pwjj2mEbM607m6e/NDWbDrbg9UUhoc2j+xoJq1WGUS2n//NW5MBIfByIzRenMg/zKLmHotI3bPTbnQNXBx5pwFVdOANS4vMq16CXP3YXIQvRwa5t87aXEg/ZFOhxC7UEtMBh9476Xn7b6liSz5Y3ZittIelzLgOoF/pqdgCKNo5nzWa3V0oxKdJ0FwYl821Q6VL33Bpj3DrTzY0KDb1PfTfqcucorMy2UpjD5bqQS9NLyC9Ztfb8aYwhQEVcjGEZLv/5qnHIHawADDS+mcfVprx75lMp0e8z8qJHGtvVu8YI834OcuOq06N8JyzNlyB/YZmcY6N4RyKxnweqOawOY5sT8upUMBf9+Cbu/POXWa5ayhB2OthmqNFxVY0KXrde1sDE1lO8EK4/Rr+tLYumMmBMGvKv256x7AxpvGXP+KFTvqishY+sTugxNrSxXgm5/JhsmQ6aBqPFIqedQ+xcHjYFZOtUi+QHOuA0IscHA/+MBh8zkWDSART1PTA6/QIXINpkFtmk1/+kudPTCA6loB0nTWET5JIZG31rbdl4xEsrzGz5vQbqi56xKrZHLjxS/1OOTIDhd/syVdHV2BoVvpZswp4yvltaMSyVtX8ZhfPF40CYrSXxx7NtKSp+A4m87 y5TIKuXl HburKN0C1O+iOJYB4vcC1oTU9FYShnH3CRx6gQr1A7CRc0N7c9FFX6HRslYSYDt6HSibt86WKeaLUag5WwrAzwG21SigcCK/ZUCA6bMqmpdTksxFS+JCaK42hgc0ZoJwYe/2Ye8pbmwzb0veKHfwwNUCJw7p7VN0PmmlnXzRVMvn83aPDDMX87ZCGVRFuBFfNxqTsOub9wsJRECh9tDCDZY20LuVLfCEbEl21Me2X8DlOzFezlfZrHjxOpMyGSjyOmygOv3Pkx4YwsZ8sfUz3Vc7eE483WLFn6GLev9ErSCbtWexXdse7aTuy7bWmEQpcubuE3atYP6gjyHmz8h3u6g0QCw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2024-10-11 at 08:43 +1100, NeilBrown wrote: > On Fri, 11 Oct 2024, Jeff Layton wrote: > > On Thu, 2024-10-10 at 23:22 +0800, Kaixiong Yu wrote: > > > Use vfs_pressure_ratio() to simplify code. > > >=20 > > > Signed-off-by: Kaixiong Yu > > > Reviewed-by: Kees Cook > > > Acked-by: Anna Schumaker > > > --- > > > net/sunrpc/auth.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c > > > index 04534ea537c8..3d2b51d7e934 100644 > > > --- a/net/sunrpc/auth.c > > > +++ b/net/sunrpc/auth.c > > > @@ -489,7 +489,7 @@ static unsigned long > > > rpcauth_cache_shrink_count(struct shrinker *shrink, struct shrink_co= ntrol *sc) > > > =20 > > > { > > > - return number_cred_unused * sysctl_vfs_cache_pressure / 100; > > > + return vfs_pressure_ratio(number_cred_unused); > > > } > > > =20 > > > static void > >=20 > > Acked-by: Jeff Layton > >=20 >=20 > I realise this is a bit of a tangent, and I'm not objecting to this > patch, but I wonder what the justification is for using > vfs_cache_pressure here. The sysctl is documented as >=20 > This percentage value controls the tendency of the kernel to reclaim > the memory which is used for caching of directory and inode objects. >=20 > So it can sensibly be used for dentries and inode, and for anything > directly related like the nfs access cache (which is attached to inodes) > and the nfs xattr cache. >=20 > But the sunrpc cred cache scales with the number of active users, not > the number of inodes/dentries. >=20 > So I think this should simply "return number_cred_unused;". >=20 > What do others think? >=20 > NeilBrown >=20 -----------------8<------------------ * @count_objects should return the number of freeable items in the cache. = If * there are no objects to free, it should return SHRINK_EMPTY, while 0 is * returned in cases of the number of freeable items cannot be determined * or shrinker should skip this cache for this time (e.g., their number * is below shrinkable limit)... -----------------8<------------------ number_cred_unused does sound like a better way to report this. --=20 Jeff Layton