From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C34BC61D85 for ; Thu, 23 Nov 2023 04:12:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9376D8D0010; Wed, 22 Nov 2023 23:12:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BF388D0002; Wed, 22 Nov 2023 23:12:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 760C08D0010; Wed, 22 Nov 2023 23:12:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5F8B78D0002 for ; Wed, 22 Nov 2023 23:12:26 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 31D07160AC4 for ; Thu, 23 Nov 2023 04:12:26 +0000 (UTC) X-FDA: 81487897092.02.64F0CB0 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf22.hostedemail.com (Postfix) with ESMTP id 03263C0005 for ; Thu, 23 Nov 2023 04:12:22 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700712744; a=rsa-sha256; cv=none; b=U5Fbgd0ghXq7oVTXcA+0Zl9/ro6/5RGN5OgELMOkqEpsWcaHjIAHv+4MdQPzp4ikLfh2CM jeR/NgCtR8mRStYCDGRpU7LDVIOqQB/qgUSJ2xnP25M+8Hd0uEIoFon3X24JtbCJzMh3yX QJONr7jpBPdqlFan0jMXjL9bofNEyts= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700712744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WlYYa1Kwfh7VUqPVhH7zVgQCQBQPD0/WJuN4zETEerE=; b=3jItr6e8gQuyGy1zU1PduOl6KkFpcEbQUgC9nCi2fZgnEwPg0fX/wFFeqwIey/KnPuU72b 40fHaU1YzfE80D/goe505OY3aDI2odXpVtAkVBAV6438wB4BROdV4Vg6RTwYX3i7DW5bKX V80TLk9ln6A/BMOySIRC0h6WRhF2kGQ= Received: from kwepemm000020.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4SbPk45m7Bz1P8qS; Thu, 23 Nov 2023 12:08:44 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm000020.china.huawei.com (7.193.23.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 23 Nov 2023 12:12:13 +0800 Message-ID: Date: Thu, 23 Nov 2023 12:12:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RFC PATCH] mm: filemap: avoid unnecessary major faults in filemap_fault() To: Yin Fengwei , , CC: , , , , , , , , References: <20231122140052.4092083-1-zhangpeng362@huawei.com> Content-Language: en-US From: "zhangpeng (AS)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm000020.china.huawei.com (7.193.23.93) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 03263C0005 X-Stat-Signature: d9dodskib58wp5z75g3qzo1ogx9mnfy5 X-Rspam-User: X-HE-Tag: 1700712742-204528 X-HE-Meta: U2FsdGVkX1/Vlhj2V81u7zlOUZQenhtk7l2EGZPkeNoPp/7SvNlfZMMz1SbS86TgM5z8+DMe73ZqCEEfQqqKVMp+ZRBiWWhMRxO0ajWLolXqp2OTbnyl6s4+dJnify5bTMUOSLfFCN75Lx4nV/doZoZbpJsL3LOLoPIedfJ+PWeTLV2eaF8/UREnw0SZrAJqocIXKC3SxdkMnfUqmr2o+DM7Uflh92zj+gwl424/OQnFiIeqAD7kd9eRsm5LJ40HVvva36PSyzetcAfPqhK73yRDw637Y2me1khZoO0LzZ6OeCpuW58b884D/TSc89v7wpvsbITdi1xM4ArZc2epOWOTznoxf1m6Bp2mynQpoMMP5+1BuENlpFOjYLe0zACKsR3pGyIUNDtHXgEnykeGoplk4LkyxUUOgOidyWsl0dKnUejaz3TssHmX5rNUW3B2vR5uVJRgsxHVnP8U5AzSWJGbndUrB8zW6t8vUt5ax83Wt+zhcSXYEhWIuJZGbmXqHXKoiH8JaFjbeEjkHIXO4tegPO79F7FnaBJE1ex14f6C0tqbuYWoSmPDNNoQiR6lDg1anyjSpeXfrSgO422AEQLJ/NekzihPpi+FeM6hsEBjAu+8FnJUtAIJJxYR9mvCiYrOIN1H1kQn/uVdWnZ0PVKP4DkCvF0oT+bhwZr0n++a+b/2C5kwSL9MVgDm80WS+N8dUIRzLOfvTIHbVHF/Y4v2Mrtt4GcMakE7cjdbVDMP20mN4D/o+iuXTH5/tRdN+dXcbG3/KBGqbBbHwWzUEQ2opBrxo8lMJJbYEAqFO08vdrupfn+8C+VKbTp708vsAkThzwqNS0ALoAyDaApQuma3oXe2bO0Nhj286DJM5C5pW6gnvIrX+oiLC7uHG0mI74jRy/FXuB6EHdWPMxZs3qB3g1UxmQDMJO5ZXscsR4r5pCm4S+oDKfg22cfdOTbUyh7SELDGeDSr26LTO8b b3t0Qjd1 97/2aRO/xOw7wtrTBNAhRX1zci7VZpZJF3lev0C+fZh5rsjKQyvYpnZR+/N/Zogtap7LNhVGOV1k73CMZYuKvtvovgVLw2+sDFUlgXIKzyohV33Zu6p7MXOmFP/jaEo4PiN688VV5n2nuNpefM3EeAp85Pjxo2AstANV5OUQfsfXrP/ASAVjSXcZxtiI8HbQULbRG0Ou5uW7g6r/oFjHbF4gdXtGkH2zfB0zvXd79DeQRDPxZaOsYdIGsY355yP65lFWho5Pv/09e14Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/11/23 9:09, Yin Fengwei wrote: > Hi Peng, > > On 11/22/23 22:00, Peng Zhang wrote: >> From: ZhangPeng >> >> The major fault occurred when using mlockall(MCL_CURRENT | MCL_FUTURE) >> in application, which leading to an unexpected performance issue[1]. >> >> This caused by temporarily cleared pte during a read/modify/write update >> of the pte, eg, do_numa_page()/change_pte_range(). >> >> For the data segment of the user-mode program, the global variable area >> is a private mapping. After the pagecache is loaded, the private anonymous >> page is generated after the COW is triggered. Mlockall can lock COW pages >> (anonymous pages), but the original file pages cannot be locked and may >> be reclaimed. If the global variable (private anon page) is accessed when >> vmf->pte is zeroed in numa fault, a file page fault will be triggered. >> >> At this time, the original private file page may have been reclaimed. >> If the page cache is not available at this time, a major fault will be >> triggered and the file will be read, causing additional overhead. >> >> Fix this by rechecking the pte by holding ptl in filemap_fault() before >> triggering a major fault. >> >> [1] https://lore.kernel.org/linux-mm/9e62fd9a-bee0-52bf-50a7-498fa17434ee@huawei.com/ >> >> Signed-off-by: ZhangPeng >> Signed-off-by: Kefeng Wang >> --- >> mm/filemap.c | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/mm/filemap.c b/mm/filemap.c >> index 71f00539ac00..bb5e6a2790dc 100644 >> --- a/mm/filemap.c >> +++ b/mm/filemap.c >> @@ -3226,6 +3226,20 @@ vm_fault_t filemap_fault(struct vm_fault *vmf) >> mapping_locked = true; >> } >> } else { >> + pte_t *ptep = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, >> + vmf->address, &vmf->ptl); >> + if (ptep) { >> + /* >> + * Recheck pte with ptl locked as the pte can be cleared >> + * temporarily during a read/modify/write update. >> + */ >> + if (unlikely(!pte_none(ptep_get(ptep)))) >> + ret = VM_FAULT_NOPAGE; >> + pte_unmap_unlock(ptep, vmf->ptl); >> + if (unlikely(ret)) >> + return ret; >> + } > I am curious. Did you try not to take PTL here and just check whether PTE is not NONE? Thank you for your reply. If we don't take PTL, the current use case won't trigger this issue either. In most cases, if we don't take PTL, this issue won't be triggered. However, there is still a possibility of triggering this issue. The corner case is that task 2 triggers a page fault when task 1 is between ptep_modify_prot_start() and ptep_modify_prot_commit() in do_numa_page(). Furthermore,task 2 passes the check whether the PTE is not NONE before task 1 updates PTE in ptep_modify_prot_commit() without taking PTL. > > Regards > Yin, Fengwei > >> + >> /* No page in the page cache at all */ >> count_vm_event(PGMAJFAULT); >> count_memcg_event_mm(vmf->vma->vm_mm, PGMAJFAULT); -- Best Regards, Peng