From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 352D2C52D7C for ; Fri, 9 Aug 2024 16:20:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E5C56B007B; Fri, 9 Aug 2024 12:20:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96D0C6B00B4; Fri, 9 Aug 2024 12:20:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BF896B00AB; Fri, 9 Aug 2024 12:20:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 59F026B00B4 for ; Fri, 9 Aug 2024 12:20:17 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BC376C12D2 for ; Fri, 9 Aug 2024 16:20:15 +0000 (UTC) X-FDA: 82433219190.09.47B1CE9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 6981EA0024 for ; Fri, 9 Aug 2024 16:20:13 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="SFsKe/ZP"; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723220380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zm5EAdsOXCZvMyPDQvIBSQFNRt+tuy0GlLgmv3TFe5I=; b=7/BHL0J0ZujCjvTsohsed9JDbN4GJHjibA53nCO/gUVBjcqP6t9itAPPVzTNxvYiKRklTS nPgapavN3YdAjLeFo3NMGTnTc0gub7A51HekoqSnuXK8UHCbSnhCYA/hf9N+vZIetEIj4d /v87c2BEd2FH/VxeMqTVq3QfuwYgaV8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="SFsKe/ZP"; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723220380; a=rsa-sha256; cv=none; b=BUp0/kn7ZjvblV4w6ImhFUZuZqQXElbonrD3lWZy5XBs8BNTBrssNuhhXgjCBzIAkEntET 0l9CG7Qc/ngC9txXDUxJUAsWIdTYvYqvoO4+msCsCvpSAMRF8Nd5PpEqduORrgyJbGV1+Y YWK8BeACoktsZ/or5JlYfF4g6q0Vwfs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723220412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Zm5EAdsOXCZvMyPDQvIBSQFNRt+tuy0GlLgmv3TFe5I=; b=SFsKe/ZPYClHhSWrlAtRoXv7CX3sbmgo0bdqW0DBRfHqlXFNrQXEa3JAJ6Ay0fGeiHqSSj TsVlYFQrUR/jfWiLLQayAzL1EWtX/vtzFEqYUtfNKAMxtoNDIBZNRPlpanPdIaCJtEekbc HQlyy/yBLgHMs09Q/Poa7Y9qICkGJe4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-24f2tgrIOZGMgjkN-vDmLQ-1; Fri, 09 Aug 2024 12:20:10 -0400 X-MC-Unique: 24f2tgrIOZGMgjkN-vDmLQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3686658856fso1176533f8f.0 for ; Fri, 09 Aug 2024 09:20:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723220409; x=1723825209; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Zm5EAdsOXCZvMyPDQvIBSQFNRt+tuy0GlLgmv3TFe5I=; b=KLEaA8+rBwln7VdavRqb2umJxIXEl3ou2deo+zqO8qhtYArphI1OeA0kJ+a5CdvOkW rIMHyqEA5rrX8ZnZ0Vfhmd3JIBZ8Dv5GU+lKEH7TYyxV2m8ayYQLToUgs3hmrModxiAJ VDf+hLhec1mouV6IeUHuFa5meisETQbsFNg6Dz2dUlZ0mbuw/IP+pIsBR9c1VNiKQiE4 beY/OGr/5nnEuwzOFuVaIVPd/AVQOKIfRrWzl5HH4lrglSq6mXD6b5aYrilr74MujTEY PrBkEwjNA7e+vAStrTErZws6YxIvi14IFOnKU35/+8y0dMIy63ale9E79WvHidTh8U+u EO0g== X-Forwarded-Encrypted: i=1; AJvYcCVALcsf3tD6F5Kely/xU03CFyP2Xsx85ZjEpvvea0WnXC1OeOotXTQb/CCObxUZ4JNXeq3WnfY/5RRtIizkcp2Dtuo= X-Gm-Message-State: AOJu0YzqlEni6Df6BaF4WqPx7751VfUraSaThzNM6xKpvGjEDw5D1XR6 fnaYpftAnpaBj1Vk9N7QfdYmNQts3YoWBIw8obI2ZD7V1OwUY8T/Djx//hwNZ2HYz1kjnyt8ZPD waxIH1ODBWkUMKo5Kgbmbhj/Ij+zIwMCl5oyuz9xKrTfHs6TB X-Received: by 2002:a5d:694c:0:b0:367:94a7:12cb with SMTP id ffacd0b85a97d-36d5fe77778mr1563506f8f.43.1723220409015; Fri, 09 Aug 2024 09:20:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG199tNHrasXyWylAho8FwcYUzg97ydDg4FbqU1Td01GP7GqR4CztpyDD4hV0dMDBM1OiMjuA== X-Received: by 2002:a5d:694c:0:b0:367:94a7:12cb with SMTP id ffacd0b85a97d-36d5fe77778mr1563481f8f.43.1723220408476; Fri, 09 Aug 2024 09:20:08 -0700 (PDT) Received: from ?IPV6:2003:d8:2f09:3f00:d228:bd67:7baa:d604? (p200300d82f093f00d228bd677baad604.dip0.t-ipconnect.de. [2003:d8:2f09:3f00:d228:bd67:7baa:d604]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36d27209a69sm5763536f8f.79.2024.08.09.09.20.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 09:20:08 -0700 (PDT) Message-ID: Date: Fri, 9 Aug 2024 18:20:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/19] mm/pagewalk: Check pfnmap early for folio_walk_start() To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Sean Christopherson , Oscar Salvador , Jason Gunthorpe , Axel Rasmussen , linux-arm-kernel@lists.infradead.org, x86@kernel.org, Will Deacon , Gavin Shan , Paolo Bonzini , Zi Yan , Andrew Morton , Catalin Marinas , Ingo Molnar , Alistair Popple , Borislav Petkov , Thomas Gleixner , kvm@vger.kernel.org, Dave Hansen , Alex Williamson , Yan Zhao References: <20240809160909.1023470-1-peterx@redhat.com> <20240809160909.1023470-7-peterx@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240809160909.1023470-7-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 6981EA0024 X-Stat-Signature: fnsp5ncqcc3iiqhdbnx1ti9jw6n73oz6 X-HE-Tag: 1723220413-805296 X-HE-Meta: U2FsdGVkX1/toMhXJgd54xorVyDV2WZ+rk8qzLxvmtYyfdbrQ5egRJSD8G7/4qC9A9jbw7I1ECFwGum8izJaTZWoGP4TtEgtyBB4NIvRfwIePQW7AzaKY21F8bYEhAsZYK6v5QCARSwbnQjsfRl+vXybG2Dmn7pjx/HkR/V7bdYHb2jqKlsCYr0nIE2TgjvpXPFMWocLx400ukvE2I9s9ohzYxH8WwsEMhpTjDQhONDG2YyO9dOjhfG4RauG3HHUSuCjQXN6kp2Mko3rDfbxyKcD7UlFAP5IUmjSwgDISXbK5fgCReMX+T8tE2VrCpRz/1BmpQvWvZanoW7P5xsx1a9mpYH14r1GJvee+0l4YEIBmAfEbwBhIBMXfzghVD/3FhVJWvAjjPJkG2onL7FUDwYekAhgMVuIInyMPj6Qe6f0+ZvSxTHvZgNgCxj/zsRSnrRrjmzimmDMUwbqWWxAN9MdVoVkktXbgdZ6I+K5QjYt2BW/2Zi0C7c+ow2XnbG9ohC+KNNJkMwd4bj3THsh+bPBUbzftpwT9R2bPHMxXeDJS6/Z+Tao6QHIn4BabusiIpZpbxpcVmFgCuEnzbR33tfnLhUDUsyaqlHdOBmGwa2S0uHXnEOyAiDRW5WF12z+ZBpDpCv7SWkZ1SxHsRbHdweeWb++Q0f379LG2BgGfR5m19I6M7DsQE/SnryZZIiKPQ6pbD0au5B4JiVdyyxFiEFo3GBRE48QWt6yddVYnij5WfKVC00rPx2K8Yghpk3QZtdumEuF+Vg7LELFgD15kNitdIpWMJi1HasWO6FZJSFRdZse2UJUqsgumMZw0utWDaAbMk1YfRsWSqXmMvcZOP5Key8x18qAjQihqw0IKyWcVApDydmqmoFZRJofyQB2NvI0KVYtu7rOndvxk636z09Pz2DWqIf0qnP+qNJHGMFBtaKNFDwglvDriH1Mk5oPfOiDYlwNJHrBzVa87AK ImU1w5ko Q0jl/I8sODnYUqg3Z8LXSEXfD9+hUXQmxte1SgyVkKgQWKYi5Kt74vyTlLVwBC3xxX2wmxHjcXQZDPcwpv2W82ET3lqDKGGWy8b7vQCO7X/mo9Y7UP42Gp8KOsIk62WMxdyHYL9M8mZYAkpPp5zqXsKayION3vX9kDt4413ItAVSRthw9MQ3LQ5Sf8odCH6E9XZUHgvYB8mhLqlxJVJPSlsQ5Lk77JuoWtvgLlVQhRDtjB0BDl3gdcA/FGjUNLBVrFAYtH8CJVY0pQ41nBuDw7ftPLgLzsc0Sw5DPTMAZb8OW/WnLqkmRxkJgCf3tZzykvmXzsnYtC1RNULeddgTubiO4wN2dvpwdnpgUWDLW3V+rKL8cVDEkQMiNJZmip9o1MzyCBDgiRtxHEAPk2FIhpOyUX0l25ZYShYAq7o78kId5HDyo10R4nRxzCurCDX0riuJA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.08.24 18:08, Peter Xu wrote: > Pfnmaps can always be identified with special bits in the ptes/pmds/puds. > However that's unnecessary if the vma is stable, and when it's mapped under > VM_PFNMAP | VM_IO. > > Instead of adding similar checks in all the levels for huge pfnmaps, let > folio_walk_start() fail even earlier for these mappings. It's also > something gup-slow already does, so make them match. > > Cc: David Hildenbrand > Signed-off-by: Peter Xu > --- > mm/pagewalk.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/pagewalk.c b/mm/pagewalk.c > index cd79fb3b89e5..fd3965efe773 100644 > --- a/mm/pagewalk.c > +++ b/mm/pagewalk.c > @@ -727,6 +727,11 @@ struct folio *folio_walk_start(struct folio_walk *fw, > p4d_t *p4dp; > > mmap_assert_locked(vma->vm_mm); > + > + /* It has no folio backing the mappings at all.. */ > + if (vma->vm_flags & (VM_IO | VM_PFNMAP)) > + return NULL; > + That is in general not what we want, and we still have some places that wrongly hard-code that behavior. In a MAP_PRIVATE mapping you might have anon pages that we can happily walk. vm_normal_page() / vm_normal_page_pmd() [and as commented as a TODO, vm_normal_page_pud()] should be able to identify PFN maps and reject them, no? -- Cheers, David / dhildenb