From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18F84C00528 for ; Tue, 1 Aug 2023 16:38:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76C09940024; Tue, 1 Aug 2023 12:38:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F0EE940010; Tue, 1 Aug 2023 12:38:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5912C940024; Tue, 1 Aug 2023 12:38:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 46986940010 for ; Tue, 1 Aug 2023 12:38:17 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D95F180572 for ; Tue, 1 Aug 2023 16:38:16 +0000 (UTC) X-FDA: 81076093392.23.E3DF08D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 31039165745 for ; Tue, 1 Aug 2023 16:17:07 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BKSl+3kZ; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690906630; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eXJy6R2O1N6NpbXl3Zkyt7SvhrIHr98fxs9gYSY7xq0=; b=G1gSfsZ3OKDWiimGqWeaNG9Ej8nFadnO9TimjusCk9WgIEihVi93vFPDAyYcF2VQ0H+9pj 8pjOyga45IrCGEzwqxeZkLzvGDfNurPetzy1jQcwFSEiWjAGScj/L05a6F1WNEZra8jLPX DAXzFwMcEDpN3x9UOFDZcOn8n6ye/6c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690906630; a=rsa-sha256; cv=none; b=XJx8g+qRHBnet1oorp0riCrDDCpwSgSE7Cw8v9GKXjX4+tPCKhQcHG4P85EVf6HWhs5XiV i625mhmEAhr5WLbZ1OoYV2DeLacdltVj5cM1Ls3nyqjfPP9XCI+n3ZUdBH5uxOflOTw+/W WvA90cqUUZxK2cjtbnhBC5vUPmRrIIM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BKSl+3kZ; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690906625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eXJy6R2O1N6NpbXl3Zkyt7SvhrIHr98fxs9gYSY7xq0=; b=BKSl+3kZhAP1KV+eqo2nJOwDdIA2W85XAnR7nVz/VAATJhRg0vDbWsXJg8xYYop1volZT1 8QcW8JND0tO5Sm2iTqjkQ3AY2w6QRQ+s1dphfexSuKKfsYaLGnTxzQc7YGmyQYP5XOYh76 yAWND+vOue3dI+5aAX9AEXB/DU1p2Jo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-141-JRKiECIgOh65HYDTeFjlYw-1; Tue, 01 Aug 2023 12:17:03 -0400 X-MC-Unique: JRKiECIgOh65HYDTeFjlYw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-30e3ee8a42eso2742337f8f.1 for ; Tue, 01 Aug 2023 09:17:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690906622; x=1691511422; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eXJy6R2O1N6NpbXl3Zkyt7SvhrIHr98fxs9gYSY7xq0=; b=Tp1CtSzgj4+2YO4RyRJDqlBPJfkNW5inaYeqHtV4fhdULQxwS505mqsj+Nbv+DSqgh SbqazdPFMRVlxqf4IW2KjtEVFtAyi4O/hZHdAUQ/g9zfScXwwp0MQYrFIyQbUaIZAIaG ssz9ScDbAhJbEQvE2oE4+yU1M6h/aGHMma1yGn0CWHZJUCMkW0QSFaECpgnJJaN1+caZ nRUHZQwLzD8IMH8KeXOd+ydB3SELv9bPwUf7gENm/0Eak6IhJmF1/PT+hET+3ie5jlRH G1BNk10ESNx3QfPFXixW1Zq/JomjSvpGETEAOB2A4FWqQuGLAAx0GPG5xDXMlVx3arh6 Izqw== X-Gm-Message-State: ABy/qLYVMU1ISL0/CLQIeMTtcucd/1XNQmrVb2APlNdZyRFS2hMD20ci c9s9bmurNtieZhFX1Gdwu5nAgWVao5E2zve3d88/9uBHYrzyojMH2pzPq+4QK+1NwlC28szg2je juJeEnyQifvs= X-Received: by 2002:adf:ef8b:0:b0:314:2ea7:af4a with SMTP id d11-20020adfef8b000000b003142ea7af4amr2822137wro.13.1690906621793; Tue, 01 Aug 2023 09:17:01 -0700 (PDT) X-Google-Smtp-Source: APBJJlEGH0Ulw/x64O87fJEpYxoKABrDKtvZU+QbrtOdpDe0pNVnkFsl/Bu4qmZb7dXZ1ZmPNNOp/w== X-Received: by 2002:adf:ef8b:0:b0:314:2ea7:af4a with SMTP id d11-20020adfef8b000000b003142ea7af4amr2822111wro.13.1690906621380; Tue, 01 Aug 2023 09:17:01 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:d100:871b:ec55:67d:5247? (p200300cbc705d100871bec55067d5247.dip0.t-ipconnect.de. [2003:cb:c705:d100:871b:ec55:67d:5247]) by smtp.gmail.com with ESMTPSA id s6-20020a5d6a86000000b003143add4396sm16471132wru.22.2023.08.01.09.17.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 09:17:00 -0700 (PDT) Message-ID: Date: Tue, 1 Aug 2023 18:16:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 6/8] mm/huge_memory: remove stale NUMA hinting comment from follow_trans_huge_pmd() To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Linus Torvalds , liubo , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard , Mel Gorman , Shuah Khan , Paolo Bonzini References: <20230801124844.278698-1-david@redhat.com> <20230801124844.278698-7-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 31039165745 X-Rspam-User: X-Stat-Signature: o189tcji1nao7g9c1b4mrxp3iq8w5qxo X-Rspamd-Server: rspam03 X-HE-Tag: 1690906627-760124 X-HE-Meta: U2FsdGVkX1+BgLWZI7Fcgd8NILbLq5y7iUvrUPQS3/zgO7f6yTadcts0iA3pSAcyYM0EPJqhJa3H3W9tTcBUfQbgKBzdiRRL0Pgwu+barjaVS+K/AoCTHGN/sJPmIWflRjQKPckGOg/sYDJ8oeBy5PCNZlGlxN2vA3EBat6DSHqa1WPt6LklJ04UibIDTS81nhpO60C5gCnL+bCSVtuGA4VGf9Z5DruC663ajHhScdx2gZWaN0gZweEJF7w5nrt75di3WGLxTi0Pt29TRCVKwghzZPZ6agPZ3NQbZ5JjSXndi8baocVwSOKFovvbAOHrN6//H65rumEZ3iS7HtQGLcCxVwtMvlS4zAZ9cjTAy1Mh8DryfSwPtS5HF3iPS2HxojaqtkbbHBBFPSqDxJ+aOiJYXY8QGMidQGQ8VpSwbzJjnh3JIpv8cLAbhPu/ROJLKnvUZlPqPYdcX/mRfastosnY31Vt8Xni4lTKHR2uH26Ui8rzZSayqYcG+nilZLO7ZPWGCBhlGiCV8Q8a6jPMCWiz7+faocPUZWYQHHDuPpMJNl/pN/KiZyBRrP+qj9rzduhn52DWCASQx+TMV8wKtgDEQPcOIPgNnqbm93vIQ0QsYCc9vr/lFmeMORdIxf09zuxohyROmoB89yqphMM26EStzjwjRTmkpqhoDmfIbFQ4yL5QfxiRhQbfmj/k9Xgwmo0IBIYYucy+/ddOyWlo0/FHootEuJU63/1y4BUN/yazvvIZ68cT39RONINbe6UmpJ0jkv4PUFbkpQmctSQzKDNVOVUtlE8ln3hDmKtSbjDRWGO8BZYlfhTSZCYsf6SSzOiWs0kG7dkSjuBXnocAKDFMtFT7yojuQ9GNHcVDdXCyIIH4fcAgP4wqfqXQsv19xdHe92Y7hs/k7CR59omPhHLA8tF/hrghUniTQ1mmdoAj1HXhygnsn/AusmsbdDBUyIdePWBZrY7nOlfAsgW FFMaPS6p JkLGQotJseXrPIAy7U0lMSx54xqndAMiL9KazrAScnOw8LG+pU1RALx19CKaPw6BG875KeLRam4tQrZuswH6DbxTyS2bgcJumdwYJUfdC1FILR2/2HOYzg01nlv5ykJHgtbmbi4eqeDlo55ZbyI7MvWekVbDTXlMZuacGTVAJV+i2aIJ50yMUtadMPFBw0moVeItpIpgCu4kE8UbDiEk2bQy3m1ALANvtTtkgWAt3QynsYXuvuKROH1TrfE4wJuvvwc59OUphOg/EFOUM4F+H1p0ehlsfpqforQErNsre9ojVLp4BCHBqdmOGROCKNheZMmMXuIXJPoEaQVENe4S28tMcuyRl1evMXSQn8aclYdrbpWo5Cm/l1zpPmDAaCL4cIaJvEenhCglH+jIWE8SAN7/fQ89raXnmTjdqvtl0SowmORBq7YutntalRg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.08.23 18:07, Peter Xu wrote: > On Tue, Aug 01, 2023 at 02:48:42PM +0200, David Hildenbrand wrote: >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index 2cd3e5502180..0b709d2c46c6 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -1467,7 +1467,6 @@ struct page *follow_trans_huge_pmd(struct vm_area_struct *vma, >> if ((flags & FOLL_DUMP) && is_huge_zero_pmd(*pmd)) >> return ERR_PTR(-EFAULT); >> >> - /* Full NUMA hinting faults to serialise migration in fault paths */ >> if (pmd_protnone(*pmd) && !gup_can_follow_protnone(vma, flags)) >> return NULL; > > Perhaps squashing into patch 1? Thanks, I decided against it so I don't have to make patch description of patch #1 even longer with something that's mostly unrelated to the core change. -- Cheers, David / dhildenb