From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC54BC5B552 for ; Tue, 10 Jun 2025 07:26:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65ED66B008A; Tue, 10 Jun 2025 03:26:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60F276B008C; Tue, 10 Jun 2025 03:26:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FE1E6B0092; Tue, 10 Jun 2025 03:26:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 324F56B008A for ; Tue, 10 Jun 2025 03:26:10 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CD8CC813DB for ; Tue, 10 Jun 2025 07:26:09 +0000 (UTC) X-FDA: 83538657258.14.B80ADF2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 30E9B10000E for ; Tue, 10 Jun 2025 07:26:06 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f1ihQrvg; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749540367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xiAped60M2xbB9Ds3ypGGB21HDmKyveMU93vjR1lu6k=; b=7jnQv87W9ESp6HxdyRn8+6/WnQbwIUk45XSCRuMabz1lCbc1M4mVcCc0m5//bhGUbg8rIA +3Bb4OEEQ9XDYDo2Kr2yA66HjQf9qKSPvGAWYt2Voen8ENQXn1ycUfkS1Pmz0IObC7tFXp avPg8LHpeCMmiiwCxwteX7Qf+yxrzOg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749540367; a=rsa-sha256; cv=none; b=4gr1qQN0bKU8OfyaOmaobMkhVAZVobwlDyP6hxHZ8mgEuJy8hsaHL+dXTU/1s3D12fzPPH Z8O7LdQAUZ7pSfhDCvVWa2fejCAX5H5or105UFfd8mzFunUjSrj+sMSvnsq+mWqA80uQpD GlHVcvs8Pp4qt5ZFJdA2danusql7uDo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f1ihQrvg; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749540366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xiAped60M2xbB9Ds3ypGGB21HDmKyveMU93vjR1lu6k=; b=f1ihQrvgjxFBHE1OnZ6w9Xp3PpAqxotTGoQ4jhbWHiPRQ0Dm7Dpz+524Y1lc4Jupe0LHvj Em8iIXIZniSN7KmXR3G3Q+f61Kim3I5gcyPI6gxlkjAVJjVkYLq1NlYWcfEof3Y14ykFEe ZQdWEcMyj3TcOdfb+oOQp5Dh8YB8AgY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-AxOgTFxHPUOaFbcmHrELjA-1; Tue, 10 Jun 2025 03:26:05 -0400 X-MC-Unique: AxOgTFxHPUOaFbcmHrELjA-1 X-Mimecast-MFC-AGG-ID: AxOgTFxHPUOaFbcmHrELjA_1749540364 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4f6cc5332so3036328f8f.2 for ; Tue, 10 Jun 2025 00:26:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749540364; x=1750145164; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xiAped60M2xbB9Ds3ypGGB21HDmKyveMU93vjR1lu6k=; b=RPMZTjADMFLQ+EXMELEN/rFXaDvL+daBU7gUqGmz8DzgOMI4+e6d/JSVbimWSkbPJ3 n1CiN+RuFwODqd303aJUod7ZsHQWMMJCEmr6V2YtQfWErbBPX8RcZ4RCMDEfudB/h4lV DNmA76W9aczcCfrk3mpX8scwvUe+AIAUsmGnF+4kqtHYe5LW41LEOqn0wQlrAEuxq6r5 dgww5V0FM3ELOr4gsxccO1gakplowgfVbA/BUCHx4+dQzAebBp7nT4o844ZSdJKxhj23 DcQFZmj7Tlb9zZnqu0zNWeJKDwhVu7d88RsqemK/kuaQbeDo6dOBj159eoMiAn1wEXeW XCbw== X-Gm-Message-State: AOJu0YwPDrGvWgUtl91AjFUPIRXvztugPNxNnYzHzUgUfHfWu5z1F0c1 fvV4MgXjY7RyfRA+o1VOGRwd9deiKQ0UcX5jDBc8hvjyJOuGDQVDjIQ444EFTECvOlAUlkH5jAW US/PMhWgrNekTXng37CXTIPjgWddA4T0FW163IhvcPkYHXYzV5+2Q X-Gm-Gg: ASbGnct5UunLJbJFMyrsHmHheU2Cqve5WzdFDrFc5P8MR2t/OfPo/itrbDkux1QG2kL OmU3GZ1HWNixpCnLySCrrKAWKBb0IwwMkGFZaOQEzBZ2gpHMMdUiBszId5MmP8MxWzRjMm1cSY1 Rgo3garZkTUOI4++G5ZB49VEjCpm3ByQxPHz/0LntcKuVAYu4A6E9TdN2jKMf8ATYrF02CWW7+I n4VnjBMu8eB/qi/mDXeakrTBTTOzcVJWwENgq1TBhNh38pDJXHxcfwOdQVTN1BSZj9F0iPpUcbE /gsTI4SYkNQeWCiPspwtxKfU/iUKnLaAcwyWyS27b/n+qiCOHE8AtNU= X-Received: by 2002:a05:6000:2909:b0:3a4:c713:7d8 with SMTP id ffacd0b85a97d-3a53188d936mr11898030f8f.16.1749540364060; Tue, 10 Jun 2025 00:26:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEGPrGcSB1/kH23tXQfTNaDTb9v4VAmSWZs9ZoyqIAu4kBrqCqQpO83zPHsUYOqTjovGhmHyA== X-Received: by 2002:a05:6000:2909:b0:3a4:c713:7d8 with SMTP id ffacd0b85a97d-3a53188d936mr11898001f8f.16.1749540363630; Tue, 10 Jun 2025 00:26:03 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-452730c66a1sm128378465e9.27.2025.06.10.00.26.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jun 2025 00:26:02 -0700 (PDT) Message-ID: Date: Tue, 10 Jun 2025 09:26:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] userfaultfd: remove (VM_)BUG_ON()s To: Tal Zussman , Andrew Morton , Peter Xu , "Jason A. Donenfeld" , Alexander Viro , Christian Brauner , Jan Kara , Andrea Arcangeli Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20250607-uffd-fixes-v2-0-339dafe9a2fe@columbia.edu> <20250607-uffd-fixes-v2-2-339dafe9a2fe@columbia.edu> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250607-uffd-fixes-v2-2-339dafe9a2fe@columbia.edu> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UfxzYPkrMGeaBGTApTsqZoKniBn1VHlgHMPpisUN4Dw_1749540364 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 30E9B10000E X-Stat-Signature: rgf4myhkai4js6pze3xqfpgpgk8rc9ib X-Rspam-User: X-HE-Tag: 1749540366-980315 X-HE-Meta: U2FsdGVkX18wge9YOqLVpIEFz0TolbQRAZQ4QWINFA4hyJBUyeazBBJcHOfd9eBvPRBeEcEUNar0Xoktc7yrTbLAMtFHMvew95GMs34+b8aMkeNpqqcdiymXA1kNc6oBqP6kxkP7r4AqDMKo3uLMDm96VSNUdJ12jHuirUkayQwE2GSe7FJB1rVWs2O2R0jv3DxidLZ28KzGg6ZO6K6fQA911IwA5+IKCEoW6N7Sc607Yfv6LtjpczSqpVC/EifkGjrR4/mpLxSRNB3v+cLOD7FQsShPCgTrSS84he9KbUpaiqXYvouf7+PUTri+I8OWErXNOx+JqFgRq4WKbE9OnkfMCAZf3jn+KcJxWNQR5pYnE9s3+ZpunRuMKDfsrIbKVPA2yJwYAF+BEaIikAIPyo18dy+ONeTdLzfFZIUaXnPYIHAAQHR7HkzourwHNHL3sqCQ/+siCVQHrLFI6NQtBjgi8vCqrZgWMr/1WiqzvtxhOuNfPookTMrWZUxffpbGzEvM3ixkwZX99hsbCdIaNssiamknLBJyt1DEYlW4tw22yBmF8DlSr3nZopLRAmb3NqO4q8FdHe6ZwOqpAxoVr9SsYfkrNXbL3mtHbmLB4EjHj87Zu8q0jDzPDOexpg6FLx6E6NHXJ5Bs5lA19qkctOAEzIVCrZzQzwUSLepO7kHXbm565njM7d6Xwre1ROe4K9buRvF3yxyYUVVAO2g/pe3l148ljgYJuHSoX/xegVRYVjTvjWAaQGVmMoa9Dv3G/zKLHB/fZBHi+bCXJrF+FcKPoUDiMPwrfTlWusEyQn8RdHNnZYMK9Nol0Xw3CYnyxDP038bnw+bShh4cvp/3+az43Osus5tGYsn2uNWjLTgwM4Oa3qqvYYoQhgKlIdF5WT3tODAJb1IaYqK6aLt85SVcR+xZ3MYbe1tCJZ2VgiokSdMhO6J8XO/birbrJjRBF108vezregk4+OQll0h s0sItLyL 6krgr2Il4qpyHR10wK2smpWdzkxIR6X9StaKMyAA3/nw3ZJeCHqVWSol0Jr8IN9xFtyK8dCe5jNlnTwvl97ajdr+n5K9FSnxebUpo6vH6/yoeapK7TnoqakUn3BjW0k5N8wvJBeKHu3XSyLr5tkD0w5fc5rvh3kuNsZPxNAlq7Y9aLNe8R83i/9xPUzURQmciuW+9FBo/um9ym4De9SKndZle80WJVYU8jJYqwGjkSYJUHTvREY3l9eVspB46oCgJY/u3HGZvYKjfxvwzyYu+hMYIerwTvpj4g+3LIRtZkbv8zW4+TIbAOmaV3GIF/LMZqTE4s0OiamiwydmEKwEHuwjjBk4vpg53Ia9AGHUnlkMSmO8L1QKy7/i7zu+AvqzQibNjfMgbNkxEyd43VyN+V1TUr04JuD86hTlX/85Ugd432wxSvhlK49HrFBPGpSsJlR9UMpz1yXsc+/sQX6141eS3Jk4xQ8D6iNECcoZdJOhebvn4vgKeVLFSRqhGsR/Swvuy9o9pRtcJKWoJLRvo65t1yxNc3rRk967rnVGamtcVWcu7Dv4Y8UNdOO+Daz8G6jdXrG2hLDpZhik= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.06.25 08:40, Tal Zussman wrote: > BUG_ON() is deprecated [1]. Convert all the BUG_ON()s and VM_BUG_ON()s > to use VM_WARN_ON_ONCE(). > > While at it, also convert the WARN_ON_ONCE()s in move_pages() to use > VM_WARN_ON_ONCE(), as the relevant conditions are already checked in > validate_range() in move_pages()'s caller. > > [1] https://www.kernel.org/doc/html/v6.15/process/coding-style.html#use-warn-rather-than-bug > > Signed-off-by: Tal Zussman > --- [...] > if (ctx->features & UFFD_FEATURE_SIGBUS) > goto out; > @@ -411,12 +411,11 @@ vm_fault_t handle_userfault(struct vm_fault *vmf, unsigned long reason) > * to be sure not to return SIGBUS erroneously on > * nowait invocations. > */ > - BUG_ON(vmf->flags & FAULT_FLAG_RETRY_NOWAIT); > + VM_WARN_ON_ONCE(vmf->flags & FAULT_FLAG_RETRY_NOWAIT); > #ifdef CONFIG_DEBUG_VM > if (printk_ratelimit()) { > - printk(KERN_WARNING > - "FAULT_FLAG_ALLOW_RETRY missing %x\n", > - vmf->flags); > + pr_warn("FAULT_FLAG_ALLOW_RETRY missing %x\n", > + vmf->flags); You didn't cover that in the patch description. I do wonder if we really still want the dump_stack() here and could simplify to pr_warn_ratelimited(). But I recall that the stack was helpful at least once for me (well, I was able to reproduce and could have figured it out differently.). [...] > err = uffd_move_lock(mm, dst_start, src_start, &dst_vma, &src_vma); > if (err) > @@ -1867,9 +1865,9 @@ ssize_t move_pages(struct userfaultfd_ctx *ctx, unsigned long dst_start, > up_read(&ctx->map_changing_lock); > uffd_move_unlock(dst_vma, src_vma); > out: > - VM_WARN_ON(moved < 0); > - VM_WARN_ON(err > 0); > - VM_WARN_ON(!moved && !err); > + VM_WARN_ON_ONCE(moved < 0); > + VM_WARN_ON_ONCE(err > 0); > + VM_WARN_ON_ONCE(!moved && !err); > return moved ? moved : err; Here you convert VM_WARN_ON to VM_WARN_ON_ONCE without stating it in the description (including the why). > @@ -1956,9 +1954,9 @@ int userfaultfd_register_range(struct userfaultfd_ctx *ctx, > for_each_vma_range(vmi, vma, end) { > cond_resched(); > > - BUG_ON(!vma_can_userfault(vma, vm_flags, wp_async)); > - BUG_ON(vma->vm_userfaultfd_ctx.ctx && > - vma->vm_userfaultfd_ctx.ctx != ctx); > + VM_WARN_ON_ONCE(!vma_can_userfault(vma, vm_flags, wp_async)); > + VM_WARN_ON_ONCE(vma->vm_userfaultfd_ctx.ctx && > + vma->vm_userfaultfd_ctx.ctx != ctx); > WARN_ON(!(vma->vm_flags & VM_MAYWRITE)); Which raises the question, why this here should still be a WARN -- Cheers, David / dhildenb