From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4481C83030 for ; Fri, 4 Jul 2025 07:48:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FBC46B8015; Fri, 4 Jul 2025 03:48:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1845E6B800A; Fri, 4 Jul 2025 03:48:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 024D86B8015; Fri, 4 Jul 2025 03:48:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DF1C76B800A for ; Fri, 4 Jul 2025 03:48:44 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3C5281A22FD for ; Fri, 4 Jul 2025 07:48:44 +0000 (UTC) X-FDA: 83625805368.30.F0F3347 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id A15E5C0002 for ; Fri, 4 Jul 2025 07:48:41 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Oruv6FuL; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751615321; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GAcn9HMHgN1oG7hwEfyLwwNI1NFV9qPDByGBJnAQD0s=; b=2PizAX+ZGXB8IF+TLNlHB0FdFFgNbgclh0l0lxzajXqiWMdvGrF8/e6rC3rQExT21d/iAl SAVTEeMa3LhgZz2+SPy9iAhmLkwRARBnpS0d+9ykHwvpc6UdisRRbckRbSVub8E3hQ0Osx 7IueX0/KelCF4tC7hreA1bQk4fyfoLo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Oruv6FuL; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751615321; a=rsa-sha256; cv=none; b=wwZbCGtWVXBE4Xuuub6/DeaiuGgc1OjSZ8t3lZ+S0s5+4TE2wBkcx0G4++toBDnqx3zuNH h/IxBmEIxScTmp1U43iFRMtB/DulWCpF1WFnFPRYfCzF/aIi6qWBjhtDtzwQfQO5iiJhEr c+M9n2i1aJEcOGLanVOBl9IEWeLU7sc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751615321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GAcn9HMHgN1oG7hwEfyLwwNI1NFV9qPDByGBJnAQD0s=; b=Oruv6FuLzcqYDeT2jDl0QBXqvkq0ORtw+cDBEOSoWyPqg2sWKL+TA9QJK3Xyszc3IuE2/S gkFH8754lRQE81wHCpUJyb5yaJHZf38RKR7WhzMuHJphXMy9zk30y6zAoxqTB3JBLLX2dy zh8JcQlVir9Bg/n2OEV7TiP2SzOcu+E= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-690-xZBUCS5ZPwef_KHU_3YRTQ-1; Fri, 04 Jul 2025 03:48:39 -0400 X-MC-Unique: xZBUCS5ZPwef_KHU_3YRTQ-1 X-Mimecast-MFC-AGG-ID: xZBUCS5ZPwef_KHU_3YRTQ_1751615318 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4f6ba526eso399607f8f.1 for ; Fri, 04 Jul 2025 00:48:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751615318; x=1752220118; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GAcn9HMHgN1oG7hwEfyLwwNI1NFV9qPDByGBJnAQD0s=; b=bSEEvbh7iKsZhXe02hgPaIFyy/vVkxQdBoPzE98d3XczMvFhpOg20X6u4WgYqBWTv9 QGqTBIt2p7OryypBqr6hIYkWQsphaIvuhdUvDc0wLcMRW3PpiIUg5ajteBBStXq0gwgc 0mAtAzWRqYd90ixdGUsKOJdebuXOuBZMrFvFLelL2TX2PtzlOeEqrCPdiqfYh7gsRp+a q8VU4NkvCWKXRjqngNVvdTXdcBDcjm7H9me1OBOn0bo0OloobVpy6Q1oxYISHc5OmQUz db54QNu0+QANxYiorSfSSMRwgICLPrQEvh6n9qIznCHlwW/+38L2LpVs/5fXSDSydg+b 3KKg== X-Forwarded-Encrypted: i=1; AJvYcCV8coLbQEdONzpswoBjqfa5CF5TmHZUeVe+NotJ21GZxu+Wvi4yEXB0JQg9NZOstlV4J1+W5O07og==@kvack.org X-Gm-Message-State: AOJu0YxY25X+kagMvR2ioZfbSfCHpYTLRO+b75n3qzdSft2rqVNirRAa y2ZGb3ESkx64u9UskVlZA54I5m5jVyu33i+3IA0cnmgSCtqHwmhAIXrB8hYholixiEHZUVbFQIR OGCZkrkx8OpLMYSUsttlQKOa3OIM4GsO9G0e27mcGkm69mD2c/TUp X-Gm-Gg: ASbGncvxrUYjIDrGE0Ykm8YnWYuZ6TVx0v+WLYJvTVGQKbK66Agrwo/TEPLqISDp5Nj 6KACe//3Zq8E+k3qKRRxXakWZBJgOzwvl6u/IE8ZBjXrmnk91h0yMTxy+lk0uDw/ItxQw8qj/mM /R93HfTynf9kwpkoYzeiUHc3YOw20HglrXwXHP59oWjJg8IKSePRXNLDrsOvLQI3lDPgf0xMA/u V//rPpONOYgVqAEMV/TkCSw0HKBfiA8qcG8eQHYjLnUHsqYW1uW16D1czfHX43EktV6kZhkx/xl q19zz4dUiIgTHIoy5gdVuP6RZrdpNHu3hqPvxn5s6CD38T28cJ2325EEAvJsmt5iiH7BUs+sed1 m8G2SiJLINzxIMdSdEpP9aFvDEGIAQD5fI8vDvDtaw0SxGZc= X-Received: by 2002:a5d:584c:0:b0:3a4:e68e:d33c with SMTP id ffacd0b85a97d-3b49661da3fmr1202587f8f.47.1751615317962; Fri, 04 Jul 2025 00:48:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGBTuMCuzQVahK7KBvt/AmkJ7K3/aqXHRyHReZnb9lTvoLbrWm/oKy9yAn73IGGyjbY6MnFZA== X-Received: by 2002:a5d:584c:0:b0:3a4:e68e:d33c with SMTP id ffacd0b85a97d-3b49661da3fmr1202562f8f.47.1751615317417; Fri, 04 Jul 2025 00:48:37 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:5500:988:23f9:faa0:7232? (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a9969f2asm49130405e9.8.2025.07.04.00.48.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 00:48:36 -0700 (PDT) Message-ID: Date: Fri, 4 Jul 2025 09:48:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] drivers/base: move memory_block_add_nid() into the caller To: Hannes Reinecke Cc: Oscar Salvador , linux-mm@kvack.org References: <20250704063404.27495-1-hare@kernel.org> <20250704063404.27495-4-hare@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250704063404.27495-4-hare@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wMtlkB5uaJCKSyvggWv6LzTaxild71wXc0MRBdD7uEY_1751615318 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: o63whju4noiskzk1cce74s7igf6tiqse X-Rspamd-Queue-Id: A15E5C0002 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751615321-700021 X-HE-Meta: U2FsdGVkX1+FEDDXLOWhavvgsGdLhA9g9JVG16CeH3t924oW798/J1UnqtCfHgMTdc8fzUR3GFS4tsJGimVuil2D/B/QC9NQ6iQTz3asNE2E5aPZG91PvpoT8x+zKohrj0xoEAt/AYM/IEkovwwr1drUQ3M++PgpnGL6Hd92/Ycyflay2c9uj/vW7qsIdz4DGYT2PCqU1LL0iHhEBMRRnuucYtVaKNKSjAq4ZzD8N5yPdxttqstXt07ITMoV98JfSRl95c64PhU49Y4yFUTCGRlRDe4X/vZvhOnqiLvlP9+CjBqHMleExEjKpK+4hLIRcaOCFIJFgY+X5ACwAOt6ZoFKaFevRo379dyw9RNJmoSH98f6rxRpV9qsoJQWX0lriX9lxeEMvGU+JN9dPbPTCVdE1KqB5YpPTnyw1q0R07FDfvJ6KMEx56+VwrWBDKrLE0S0b3DqLKSonCKtJfUZws9VEK9VhrCuphOhBR+fzZgp9hxpYSHA5M3vdbqmTO9kmn++xMs37OBe6jPK4T0I1GgSQCW2szeyUNKkdTzDWWCwfYn3b6qHkTNQmgK1Wtv3L2S7t0mgq9qOi97RHlhEFFP60hiXlwOlPpA9zo92OVCEACMp1N31Vfo6uv8hbjmkEJ5UO6DZdNKJdc6J69cuhDO+c9dNd67m189+aex+kxXzeDREUMuKn5TQ393hxPHmnQ+0jDQTBS8e8T3I0y31T20eOdqwGRzmnUZbKT0tKPL7GUpX1sru9OgRVw6atFk40Yv+tDaaw/rO7fV3Ze0wCjMouHLl/OyEiIl07HBAEiDFxgrNoWzswExdlEBKoHhJt8bqIotbEPALTjS9zkjN/nQ9BJyKiLzqm487+LIY9R3/dGgWeoqOWbaO1HUwCHvwymfxS2BGIyh4xooly19FmpNdFGNBxwdNN2D2fGs/CtfmjBbVmL07sgguzDMf4HKT6Igf6Ko0usUTCK5THQJ azxrQ+aa xPhahrgBNUmB+yIuMFV5Bi1txmbHC+jV30TPF0wMzpPozr35QhQQ4E2Pbm87VvbYANXRUn0wzYIoHWMXcMZFwurmrsRGt/iJhBWvk1+FNboB8IThI3cUwN2kR6oIHmGzXStH6vtg76SWbFY44YZAc74TK/EJg3rZke1c35vL/X6tTtQd3Kc/JABiEkC8SPwzH5QL6rjN0JxfOZDFuMppvXiOCzNue9yn3w1dbRPmprV96FDC5WNRUZWdbTF0vhUhu8Dpx+9T3kf1QEr3AWxi5lFMEbH80C3fVd87zBc2jE4smCl3CfCt3j6PXi0IMm8C2/zboo7pVOKIKM1GyFFjKiZRaaLkQbf6uuBonDbKpzfvztbOrKpSAGtZ5192u131pG+RNT/haE+HqAPwWCu4QeYiyokWBg9ZvpnMuEj31osZ65R9iCxvzOxcMfc3g0Zmm7KBYw0eC1VE10WhXOVx3wcmG7VZn1hcwM7KcemB3T9nnGh4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.07.25 08:34, Hannes Reinecke wrote: > Now the node id only needs to be set for early memory, so move > memory_block_add_nid() into the caller and rename it into > memory_block_add_nid_early(). This allows us to further simplify > the code by dropping the 'context' argument to > do_register_memory_block_under_node(). > > Suggested-by: David Hildenbrand > Signed-off-by: Hannes Reinecke > Acked-by: David Hildenbrand > --- > drivers/base/memory.c | 36 ++++++++++++++++++------------------ > drivers/base/node.c | 10 ++++------ > include/linux/memory.h | 3 +-- > 3 files changed, 23 insertions(+), 26 deletions(-) > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index 4ce93fb54525..5fb275d7ed7d 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -782,21 +782,22 @@ static struct zone *early_node_zone_for_memory_block(struct memory_block *mem, > > #ifdef CONFIG_NUMA > /** > - * memory_block_add_nid() - Indicate that system RAM falling into this memory > - * block device (partially) belongs to the given node. > + * memory_block_add_nid_early() - Indicate that early system RAM falling into > + * this memory block device (partially) belongs > + * to the given node. > * @mem: The memory block device. > * @nid: The node id. > - * @context: The memory initialization context. > * > - * Indicate that system RAM falling into this memory block (partially) belongs > - * to the given node. If the context indicates ("early") that we are adding the > - * node during node device subsystem initialization, this will also properly > - * set/adjust mem->zone based on the zone ranges of the given node. > + * Indicate that early system RAM falling into this memory block (partially) > + * belongs to the given node. This will also properly set/adjust mem->zone based > + * on the zone ranges of the given node. > + * > + * Memory hotplug handles this on memory block creation, where we can only have > + * a single nid span a memory block. > */ > -void memory_block_add_nid(struct memory_block *mem, int nid, > - enum meminit_context context) > +void memory_block_add_nid_early(struct memory_block *mem, int nid) > { > - if (context == MEMINIT_EARLY && mem->nid != nid) { > + if (mem->nid != nid) { > /* > * For early memory we have to determine the zone when setting > * the node id and handle multiple nodes spanning a single > @@ -810,15 +811,14 @@ void memory_block_add_nid(struct memory_block *mem, int nid, > mem->zone = early_node_zone_for_memory_block(mem, nid); > else > mem->zone = NULL; > + /* > + * If this memory block spans multiple nodes, we only indicate > + * the last processed node. If we span multiple nodes (not applicable > + * to hotplugged memory), zone == NULL will prohibit memory offlining > + * and consequently unplug. > + */ > + mem->nid = nid; > } > - > - /* > - * If this memory block spans multiple nodes, we only indicate > - * the last processed node. If we span multiple nodes (not applicable > - * to hotplugged memory), zone == NULL will prohibit memory offlining > - * and consequently unplug. > - */ > - mem->nid = nid; I'll note that this change is not required, but also doesn't hurt. Thanks Hannes! -- Cheers, David / dhildenb