From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>, Chunyu Hu <chuhu@redhat.com>
Cc: shuah@kernel.org, linux-mm@kvack.org, ljs@kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
mhocko@suse.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com,
npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
baohua@kernel.org, lance.yang@linux.dev
Subject: Re: [PATCH v6 0/6] selftests/mm: skip several tests when thp is not available
Date: Fri, 27 Mar 2026 14:24:58 +0100 [thread overview]
Message-ID: <b28ebf0c-c10e-4e1a-9e8e-30e6925d0da8@kernel.org> (raw)
In-Reply-To: <20260324090927.eeacb7987d22ed8ba13fada2@linux-foundation.org>
On 3/24/26 17:09, Andrew Morton wrote:
> On Tue, 24 Mar 2026 09:33:10 +0800 Chunyu Hu <chuhu@redhat.com> wrote:
>
>> There are several tests requires transprarent hugepages, when run on thp
>> disabled kernel such as realtime kernel, there will be false negative.
>> Mark those tests as skip when thp is not available.
>
> Thanks, I updated mm.git's mm-unstable branch to this version.
>
>> Chagnes in v6:
>> - patch 3 add reviewed-by from Lorenzo
>> - patch 4 handle the errno before and after close(), suggested by AI
>
> Here's how v6 altered mm.git:
>
>
> tools/testing/selftests/mm/vm_util.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> --- a/tools/testing/selftests/mm/vm_util.c~b
> +++ a/tools/testing/selftests/mm/vm_util.c
> @@ -785,15 +785,23 @@ int unpoison_memory(unsigned long pfn)
>
> void write_file(const char *path, const char *buf, size_t buflen)
> {
> - int fd;
> + int fd, saved_errno;
> ssize_t numwritten;
Empty line? :)
> + if (buflen < 1)
> + ksft_exit_fail_msg("Incorrect buffer len: %zu\n", buflen);
--
Cheers,
David
prev parent reply other threads:[~2026-03-27 13:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 1:33 [PATCH v6 0/6] selftests/mm: skip several tests when thp is not available Chunyu Hu
2026-03-24 1:33 ` [PATCH v6 1/6] selftests/mm/guard-regions: skip collapse test when thp not enabled Chunyu Hu
2026-03-27 7:43 ` Lorenzo Stoakes (Oracle)
2026-03-24 1:33 ` [PATCH v6 2/6] selftests/mm: soft-dirty: skip two tests when thp is not available Chunyu Hu
2026-03-24 1:33 ` [PATCH v6 3/6] selftests/mm: move write_file helper to vm_util Chunyu Hu
2026-03-24 1:33 ` [PATCH v6 4/6] selftests/mm/vm_util: robust write_file() Chunyu Hu
2026-03-27 6:03 ` Andrew Morton
2026-03-27 7:46 ` Lorenzo Stoakes (Oracle)
2026-03-27 12:32 ` Mike Rapoport
2026-03-24 1:33 ` [PATCH v6 5/6] selftests/mm: split_huge_page_test: skip the test when thp is not available Chunyu Hu
2026-03-24 1:33 ` [PATCH v6 6/6] selftests/mm: transhuge_stress: skip the test when thp " Chunyu Hu
2026-03-24 16:09 ` [PATCH v6 0/6] selftests/mm: skip several tests when thp is " Andrew Morton
2026-03-27 13:24 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b28ebf0c-c10e-4e1a-9e8e-30e6925d0da8@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chuhu@redhat.com \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox