From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EC88C46CD2 for ; Tue, 30 Jan 2024 09:33:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D82F36B009C; Tue, 30 Jan 2024 04:33:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D31926B00A0; Tue, 30 Jan 2024 04:33:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD3436B00A3; Tue, 30 Jan 2024 04:33:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A3AC76B009C for ; Tue, 30 Jan 2024 04:33:27 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4E6361A07CE for ; Tue, 30 Jan 2024 09:33:27 +0000 (UTC) X-FDA: 81735464454.03.B09344D Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 8AF9240009 for ; Tue, 30 Jan 2024 09:33:25 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706607205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xSDa3k3llucP+kzXBjsbwyjMQIqmAC0VNysunWF4sss=; b=TdbZ4olgrYGr8CEdTjrJA9BM3Iz4GZaS7WoHflzOwujXuPtGLY4Nive9S87JI3PGf0B1yg iFrB8AgAD+KVix3PQ9VIcfqmJ5AvcjVGDA41A6aqRsNDW82ylZRrFhGxc9qU1CrHzVa9l6 Tl8iVK4eVOg1kxCtgDE9mtoNdK92uM4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706607205; a=rsa-sha256; cv=none; b=PVOvot6MYcnuEcZXaC+Y7jwWNcVdrfwEpfyQOt1IgPxF38qv4+PQVmpZeoBBf3OZ31t+Ly 3L60amo0WsjTthiLM6jhHOUAsr02L7rh51/nWHLlXCZHuxuMb+JChLEn6ky11kh1X6gCAt 82ARYiJZlbdCyaMJQsL1s03SYrMo3yw= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 54663DA7; Tue, 30 Jan 2024 01:34:08 -0800 (PST) Received: from [10.57.79.54] (unknown [10.57.79.54]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A8A173F738; Tue, 30 Jan 2024 01:33:21 -0800 (PST) Message-ID: Date: Tue, 30 Jan 2024 09:33:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 8/9] mm/mmu_gather: add tlb_remove_tlb_entries() Content-Language: en-GB To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Catalin Marinas , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Michael Ellerman , Christophe Leroy , "Naveen N. Rao" , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Arnd Bergmann , linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org References: <20240129143221.263763-1-david@redhat.com> <20240129143221.263763-9-david@redhat.com> From: Ryan Roberts In-Reply-To: <20240129143221.263763-9-david@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: b35ddkxxjn8mhuhwntr55xeebfr9rn5s X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8AF9240009 X-HE-Tag: 1706607205-32421 X-HE-Meta: U2FsdGVkX1+r1MtHABKoYC82ryQmf7b3NcVosuPLnv72ZZw5DdrzbkULm2DED3plvmrvCgHTCosIxQUo9ezrnY0LOvcjlgeF4aZwZ7cRCzr2uU3KraRXCPn3DCLzkvp3oXRw4Ei8SGwtESXbYIfdrqF+pUTxTPquAgzGY2gtMjRFmKcy7o5KoBQvBByVQ56c6LrbdZYNC+XhKiqCcPZ/j6HTHNhYCLe9DUioExIAg9T2d2uquKYQDQaZ19k8d9iu48CLnK8NKqRDnMbRdAZbrmWTn+HAKOr8mIlnDW+5b2J3VfzNkqANs/KFY4QWukUaVOV6F3/iru5ICB/siqf00J2yJAFj6zFy5whMP0KM6O7aKKFJF+O3M7+0RBvHxz8eY7W5RpbBsagM+64T783PNHxTmYZubd/sdCYfwX0UwRggxUDQIn1sbryyEXbIQdJqmtGvjYPj3gHCya/7fcGRRmeTz0pK4RsOtOZWXg90Z2RY8U2XIz26jU0kkxaxm/KAUASc+Po67V+CHkoeo3DR8TZoPdb0QmOvXIqVQWDdfu4umNKRxwUUs0qPNAP1Fb/DF5rI6fyUujJ+knlETCib0NCBklvdhwU9qddZmnvOy+kgn7dpjJnsJxMdK8q3HFmxChtsOqLoNv/WjdtRlOmhr8QlcedV59c3Kfose5ugFT4FvzDMwDpMOzy0UW5vTY91iz1xH8CBNpFn0wtjejyoSYeO+9MQ5QqxO/xq7AtLDQZpJMvZUfT2AdVfYQnltVoiqn6mgL0cSniykRJHipMi+R8RyfhfRTX/SAq85VzgYiElPua+DK0qiTMRdKuRBCfY6nyqMmeA7GZVTqz0W0KsS7dsVYSGjGqwNqs059KlsL+I0CWA3dDTl2JmrYpo5puSgy724bv39PSUJOFRndEu93y7jUUdkGuK6kp13xFfWEIerxtiXWJkOgqYdcW2JKajMiY4WOYqGt3Qs4Bb7OW m3G6+qxt 2wbsi38EXE92LaxY0g9l5GUqhaW+ajpA+bmUpvsDjSfWYflg3RpSvjYiCvcEjoR9OFb7gg47x8k/WD6/sjrq70ksftgMshmaoiFAjEh1b1VJ+Qw8zeWYA6dRmvLKPqk3BNJi6HY19nQgq7qrKue8zKNznyFq7ogeCZPgn0R8uAtUkPmwlTrcVeX/LfsKStv/NnY9hc5qh5FZZEPZZ7A4vZ6p6B4yc7ehPLVCyhuKLjVaV0GOTKRw5G0qrhsZ3OwfjBnkJOJyLrDsPF7U7L1ZKZajTIA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29/01/2024 14:32, David Hildenbrand wrote: > Let's add a helper that lets us batch-process multiple consecutive PTEs. > > Note that the loop will get optimized out on all architectures except on > powerpc. We have to add an early define of __tlb_remove_tlb_entry() on > ppc to make the compiler happy (and avoid making tlb_remove_tlb_entries() a > macro). > > Signed-off-by: David Hildenbrand Reviewed-by: Ryan Roberts > --- > arch/powerpc/include/asm/tlb.h | 2 ++ > include/asm-generic/tlb.h | 20 ++++++++++++++++++++ > 2 files changed, 22 insertions(+) > > diff --git a/arch/powerpc/include/asm/tlb.h b/arch/powerpc/include/asm/tlb.h > index b3de6102a907..1ca7d4c4b90d 100644 > --- a/arch/powerpc/include/asm/tlb.h > +++ b/arch/powerpc/include/asm/tlb.h > @@ -19,6 +19,8 @@ > > #include > > +static inline void __tlb_remove_tlb_entry(struct mmu_gather *tlb, pte_t *ptep, > + unsigned long address); > #define __tlb_remove_tlb_entry __tlb_remove_tlb_entry > > #define tlb_flush tlb_flush > diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h > index 428c3f93addc..bd00dd238b79 100644 > --- a/include/asm-generic/tlb.h > +++ b/include/asm-generic/tlb.h > @@ -616,6 +616,26 @@ static inline void tlb_flush_p4d_range(struct mmu_gather *tlb, > __tlb_remove_tlb_entry(tlb, ptep, address); \ > } while (0) > > +/** > + * tlb_remove_tlb_entries - remember unmapping of multiple consecutive ptes for > + * later tlb invalidation. > + * > + * Similar to tlb_remove_tlb_entry(), but remember unmapping of multiple > + * consecutive ptes instead of only a single one. > + */ > +static inline void tlb_remove_tlb_entries(struct mmu_gather *tlb, > + pte_t *ptep, unsigned int nr, unsigned long address) > +{ > + tlb_flush_pte_range(tlb, address, PAGE_SIZE * nr); > + for (;;) { > + __tlb_remove_tlb_entry(tlb, ptep, address); > + if (--nr == 0) > + break; > + ptep++; > + address += PAGE_SIZE; > + } > +} > + > #define tlb_remove_huge_tlb_entry(h, tlb, ptep, address) \ > do { \ > unsigned long _sz = huge_page_size(h); \