From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCB4ECD4855 for ; Tue, 12 May 2026 08:45:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 417276B0088; Tue, 12 May 2026 04:45:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3ED286B008A; Tue, 12 May 2026 04:45:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 303C86B008C; Tue, 12 May 2026 04:45:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1FC9B6B0088 for ; Tue, 12 May 2026 04:45:13 -0400 (EDT) Received: from smtpin20.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BCB6116040F for ; Tue, 12 May 2026 08:45:12 +0000 (UTC) X-FDA: 84758133264.20.6EEA101 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf20.hostedemail.com (Postfix) with ESMTP id AC56D1C000B for ; Tue, 12 May 2026 08:45:10 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rmGlIY7P; spf=pass (imf20.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1778575510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GhZDGLrqA0RMRHfvgJ0WVkUHleupN5cnWPNepexFB/4=; b=IEG5tWeAY8twiDplhCI43AWRBWiaKBVDZvhnycdo+OZKINTcaLJMvbuFI9rP4A0JyGISFD UdplbmcxsEckL0jcXu8B5hhO7Tic8dC9voRUgGBZ6VWuFk5RR6iu+QkvhUiQgOfzwtrFej vFRqnha4hwQGjKM/bCE2bbM9XZ7S6L0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rmGlIY7P; spf=pass (imf20.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1778575510; a=rsa-sha256; cv=none; b=0SilagTZXzYownIOXJPLBLUMWkVUqGqa9I4jtC1P3fgFC781c3qpvIzTxr13ZHfQCvVPYN BhrIAC4llGbLfVcZD0hcxzfRNkS3mRQAXp5+9eFBFJ3+KCFCzQg3oLSpjEgr6i3W5kQ2pK oQccfiecU+w4uOq+XpWILyUdyTHR36Q= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id C766242A85; Tue, 12 May 2026 08:45:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E8BCC2BCB0; Tue, 12 May 2026 08:45:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778575509; bh=x5sv3cUvc0EnVzqsB5pARpKxSMhXeMprjYxwjLxFI4A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rmGlIY7PfdC6lhhdT+wXAUp3cD6jQUc2MfcH1Hzz4FK42KP1SS+duKfUDwwVzJYjt jCGQUdxWw834Vsk4Ca/+iynRSICvsqKqidNB3PjY2hIewrgmlQvVvP900Lj55EDCbF YNkPyUVnwIxqbg3/FI8+UsFbgb8hpQebDYN+B/SciBNi0BitAZ4peUHMXShauEyxHT YAF7JZ4lzb9YPaKjNIB6PIKGi8r/LxZmLABNTGeJ3/LmTeT+a9CZsPzftd2JWj97sv 7uCTS5qmpKR7YKLsghY2KbIEDDRnq1acHacCNvAnkAsIC1gbgyvCfhAMKAlWYXTLbP hKJiPIvYP9g1g== Message-ID: Date: Tue, 12 May 2026 10:45:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] mm/bootmem_info: remove call to kmemleak_free_part_phys() To: Oscar Salvador Cc: "David S. Miller" , Andreas Larsson , Mike Rapoport , Andrew Morton , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <20260511-bootmem_info_prep-v1-0-3fb0be6fc688@kernel.org> <20260511-bootmem_info_prep-v1-4-3fb0be6fc688@kernel.org> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 1m98m1rw4ginb6n7r74tx1nyjhsnra3o X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: AC56D1C000B X-Rspam-User: X-HE-Tag: 1778575510-284318 X-HE-Meta: U2FsdGVkX19i9bZfmpVDwXoK61zGX52tTERB7NJIMkRey3eOcIkOlh4r8s8bNKCLDSqo5md7mNldX6qCh8PKb9YteIFCMTrrZnt7j9HBZhOiN9TokraUEzZ7z50SIH9FOMnYAjXNbv/I/RNMXtcWS78n/WIP53D2/6W4TDBIay1eIoWMuYg3Z0Xl05qiHgEQEAyt/vsA7mN1q41Rjtoogc2UlbV5s0e6ILJQ0b8zF5c4f71RiiGCtvyU1NmDnGDPmjnbqkz1hHyn+cPbnmU9/Qx/Jqqftd/6fWit9+zU3EhHRw8ORxPquc4IDZD81mvyN7HeTZQXEWEnwyZwegibUTy2ULMjknLzMNtpw5c8PQYhvNXB0e438etdj0N9oqfWIm/FYiWeJfD7bj/lHX6tac7vE4ID0eQtZrp20zQlowiMvYEmfAhjxipX58WUCQm9nG+4iza7c8GKXhxuDTysTIU6zuF2+cUzA52yWqPJp6LvZNNqFtXZSOevnlAcaSIhPuDIX3YD3pNySTDhxaHRdaYMOnIgVx29GtnaDwPHBTSvgqX3NDGp/EDbFdkTjiE8Nm+hJ+5PUfXEjoZFfxbvTcywdGZjEIEQWLD7nDhRfEkooE/egeKf6ZXn88ZtXcqKyr1dUbvqjzXUCQWaHXvl+gKL263MC1eGr2GyHMvMviRDqVvSi3CSxcqklhbHDSMarezKfJ1hatsUjlJsioQOcn/u/6f47lLoVSw3ONpIVwsjA7K1HiMuUDuqPQ0wWARZ2oCYQvt5Azh0To/b3dnx6OwpMlD/96pfhpHO2qQ1GlRlIolf/UpdV/3ji9oqVwnNQvGTVMIT/PSn6PGKFBv2nxjqurbUxawqib/cxcBBCly5vw+6SQ81dlhk9XKkJMq8lIweKOJwZ3xM0YpvR0PRJXVPQlNuXC2nNqotjJsknpHdTPFe6HAC1zU9oSFqioGzF7kPSwMGio61LD7Vajx WLZa0z3t lPZxzJ6i6SuUI4EzQuaEyC+s67SH/ZXqi8LQ3bVEjFrObOXHjQcH+1bua7dRbTlCHfcvMZXMen+XBQxD2QYhalyDb0XMMLsdCJcvQxgOBEdATst7ynxoSEacutegNZFn/5rshZ+6Bp961gPSB8ZR+omP8m+f1XYmctQgy2NNZ3Zkh/Y7OnB5b9HtU5JUb/H9JuIEZDdEompwbvADzSGyyte6EnMhq7ecWLWX+nrof8OGZ/Ma49Hn2XX0Ro5k/3YBMoeyyDAOPR76LL9laF9TDZGDt2EeGEpXNgSwZ Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/12/26 10:34, Oscar Salvador wrote: > On Mon, May 11, 2026 at 04:05:32PM +0200, David Hildenbrand (Arm) wrote: >> The call to kmemleak_free_part_phys() was added in 2022 in >> commit dd0ff4d12dd2 ("bootmem: remove the vmemmap pages from kmemleak in >> put_page_bootmem"). >> >> In 2025, commit b2aad24b5333 ("mm/memmap: prevent double scanning of memmap >> by kmemleak") started to use MEMBLOCK_ALLOC_NOLEAKTRACE when allocating >> the memmap to skip the kmemleak_alloc_phys() in the buddy. >> >> So remove the call to kmemleak_free_part_phys(). If this would still >> be required for other purposes, either free_reserved_page() should take >> care of it, or selected users. >> >> Signed-off-by: David Hildenbrand (Arm) > > Reviewed-by: Oscar Salvador > >> --- >> include/linux/bootmem_info.h | 1 - >> mm/bootmem_info.c | 1 - >> 2 files changed, 2 deletions(-) >> >> diff --git a/include/linux/bootmem_info.h b/include/linux/bootmem_info.h >> index 492ceeb1cdf8..f724340755e5 100644 >> --- a/include/linux/bootmem_info.h >> +++ b/include/linux/bootmem_info.h >> @@ -82,7 +82,6 @@ static inline void get_page_bootmem(unsigned long info, struct page *page, >> >> static inline void free_bootmem_page(struct page *page) >> { >> - kmemleak_free_part_phys(PFN_PHYS(page_to_pfn(page)), PAGE_SIZE); >> free_reserved_page(page); >> } >> #endif >> diff --git a/mm/bootmem_info.c b/mm/bootmem_info.c >> index 6e2aaab3dca9..74c1116626c8 100644 >> --- a/mm/bootmem_info.c >> +++ b/mm/bootmem_info.c >> @@ -32,7 +32,6 @@ void put_page_bootmem(struct page *page) >> >> if (page_ref_dec_return(page) == 1) { >> set_page_private(page, 0); >> - kmemleak_free_part_phys(PFN_PHYS(page_to_pfn(page)), PAGE_SIZE); > > A bit odd that kmemleak_free_part_phys() did not complain if we never > did kmemleak_alloc_phys() for these pages? delete_object_part() calls __find_and_remove_object() and essentially just skips if it didn't find anything. Maybe the kmemleak_warn() would trigger, but it's guarded by "#ifdef DEBUG" ... -- Cheers, David