From: David Hildenbrand <david@redhat.com>
To: Matthew Wilcox <willy@infradead.org>, Yajun Deng <yajun.deng@linux.dev>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/rmap: convert __page_check_anon_rmap() to folio
Date: Fri, 15 Sep 2023 17:26:43 +0200 [thread overview]
Message-ID: <b3d9f64a-1661-10c0-0e20-06d91b54bb80@redhat.com> (raw)
In-Reply-To: <ZQRg89X67vKL8Q4d@casper.infradead.org>
On 15.09.23 15:49, Matthew Wilcox wrote:
> On Fri, Sep 15, 2023 at 06:17:31PM +0800, Yajun Deng wrote:
>> @@ -1176,8 +1175,8 @@ static void __page_check_anon_rmap(struct folio *folio, struct page *page,
>> */
>> VM_BUG_ON_FOLIO(folio_anon_vma(folio)->root != vma->anon_vma->root,
>> folio);
>> - VM_BUG_ON_PAGE(page_to_pgoff(page) != linear_page_index(vma, address),
>> - page);
>> + VM_BUG_ON_FOLIO(folio_pgoff(folio) != linear_page_index(vma, address),
>> + folio);
>
> No, this is not equivalent. You haven't hit any problems testing it
> because you don't have large anonymous folios.
Right, the address would have to be adjusted as well by the caller.
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2023-09-15 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 10:17 [PATCH] mm/rmap: convert __page_check_anon_rmap() to folio Yajun Deng
2023-09-15 13:49 ` Matthew Wilcox
2023-09-15 15:26 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3d9f64a-1661-10c0-0e20-06d91b54bb80@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).