From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88D39EED60B for ; Fri, 15 Sep 2023 15:26:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7FC16B0378; Fri, 15 Sep 2023 11:26:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2EFD6B037A; Fri, 15 Sep 2023 11:26:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF74B6B037B; Fri, 15 Sep 2023 11:26:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AC47C6B0378 for ; Fri, 15 Sep 2023 11:26:51 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 801F84019C for ; Fri, 15 Sep 2023 15:26:51 +0000 (UTC) X-FDA: 81239209422.15.35B1C6B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 17A8A100011 for ; Fri, 15 Sep 2023 15:26:48 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JNALSjDR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694791609; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cXJCz6BbI6aPCSAZn+qO6JUf8WIvxxBmFHYvub3SbQw=; b=pBZ8Oh+h1bcfMEho2BetsLKHemFSchsY74jgYhvmfA/rNN3FgXqhELjcpor032oRhwEvJK 02g83Jm8AOHUgzq72u9YC0j/Aixr4wx1D9N8pGfs66J4vyUv64WWKdhXQFJJCBx2clokPs 1PJMr5NjH9nDpXXoBqjr3PebsuaGQEc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JNALSjDR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694791609; a=rsa-sha256; cv=none; b=1VI5/8/R4N9FDT2KOExSKrttK0Evsvm0baB7PGogMbGUY1dDxL+LxN0ke5OPdN6RJMhV83 jdOj99Cu9+gHNGRTH/JvZSx1npaC8Xy0Qxl2S2ca03gKUkHA/WYjK/DwuufYsugwTp6TA2 lxMyvwxAk6rQ8Yf7vwzvOz0ZslzEhL4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694791608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cXJCz6BbI6aPCSAZn+qO6JUf8WIvxxBmFHYvub3SbQw=; b=JNALSjDRY2g0iV7M9KA5rDyFgw6zjAKldM6dBd34OxM86eWEq1/uKiIAI3ATViqLQG5fTp mCDxOJb/NkFrmUiB3HsKrpkrgggpBv6WFWmNB9RC6tjSg+4ZXxtoi9K3Y9/tcI+/Z1VU5U xfd2PbZEIu+1Ld6C0w/rlDATwl88XOc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-2x-hK4x1M223_Ws_wTZsVA-1; Fri, 15 Sep 2023 11:26:46 -0400 X-MC-Unique: 2x-hK4x1M223_Ws_wTZsVA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-31fb896a87aso1558343f8f.1 for ; Fri, 15 Sep 2023 08:26:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694791605; x=1695396405; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cXJCz6BbI6aPCSAZn+qO6JUf8WIvxxBmFHYvub3SbQw=; b=QDGJ5dNoimq/jSbvB5pD8NcsMWAFrwvh3v/kv77FgmHIaE5p9RmRMz3TlGeY12dzz1 XMbNHiqV2d28X61xNCJP9Q5uFWTD3l7hptSGpDOumOVkYdaHrXhIwSlt7Pv9y+PnjUOz 4G/KMoYLxBFU2l3WWisXU8PcE+N48gbfxkGhifK+4/WCkvPLlM92gC6dw9AfsmvBo11h 8Sw+R9dJwuE5SiSO1N+ekfWyGUrKGnZEOACMffzoVq+vnQNaP2+Jhdz+2IHMjlc6MkWC 3Dj8Ndyt5+qmx91jpH5uUPIA5qppUVSJ0eWrkzjrt5X8NQnUvxudKD5usxe/yUfqpXiB oqxg== X-Gm-Message-State: AOJu0YxLoG9SaRtDK1WM679qirEGlk2ryoa5gTdVRbW47ezBQyyztFrV vioF3DtIi3Y785rzxLgF7u/N+6pibQGEZTj3vPwfIRJRZGafac4jSDca75ltpDactmJN1PJnbWk BdU01E/2Dhgg= X-Received: by 2002:a5d:4705:0:b0:314:12c:4322 with SMTP id y5-20020a5d4705000000b00314012c4322mr1846937wrq.4.1694791605415; Fri, 15 Sep 2023 08:26:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcciUEO3Yzg/B/EH3LHnJHXESKC04F9L6yYC6mauISILfyLrs3Bv2tOaf8tetTfv85dpKLcA== X-Received: by 2002:a5d:4705:0:b0:314:12c:4322 with SMTP id y5-20020a5d4705000000b00314012c4322mr1846917wrq.4.1694791605012; Fri, 15 Sep 2023 08:26:45 -0700 (PDT) Received: from [192.168.3.108] (p5b0c6d49.dip0.t-ipconnect.de. [91.12.109.73]) by smtp.gmail.com with ESMTPSA id z9-20020adff1c9000000b0031f07d1edbcsm4729335wro.77.2023.09.15.08.26.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Sep 2023 08:26:44 -0700 (PDT) Message-ID: Date: Fri, 15 Sep 2023 17:26:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mm/rmap: convert __page_check_anon_rmap() to folio To: Matthew Wilcox , Yajun Deng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230915101731.1725986-1-yajun.deng@linux.dev> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 17A8A100011 X-Stat-Signature: az7d6e4ru5ihw7gac4raw5b1bdd6zgs8 X-Rspam-User: X-HE-Tag: 1694791608-512222 X-HE-Meta: U2FsdGVkX1/pmBTDPBru2IX2/1VcHSvBdVsXM/zADHasCXxkPRVZQEa+Fdqo6sXheh/+gsGspwF3r8jAjDs6Y2rrb1XFmGvN+if3SboUlux4UioPXCfzUQGXlDS2qZz1XCnLHVQNv4rGOQTGJ1tlygNQKvGsCBsptcc3WF6xMWfySDNdGP8icmlfV5EHXkLlSUSCuI4YhQmKfMbUtw4/3UZnR/ghJtB32Pph1zd0cKhDtF5LPrVfWWUNsDuEo3ajQ7t1dJlXP/qHALOjyu3Ze1BJjM9x6xuNGRMe8FjqGVIl5/WNyYeQ5gZki2VDlI9DSRwAFriN1KHAapGnnAAT6nwL/EM9dj5JpaA/9ZNf6x78sPJWLHtp75x2/8F6A7vj9vW6RzX1H+IwYQJWVlg29cR79ce6omBwIxSawnTi8G+OJ4DqoNhzpjgwZ+IhXdFriyjASDny/JIM39YuCMNa9D9Y/Nm+xJodG49esDQzRaIQUztGkgK2rMEB7TdZJAefJ9Hum2AzoD7nB6Z0HyQb1MvxQguNK503IfIfT0Rm6oZAFiEnsw3RyhUhSE5y0ZLBWcjtCXjk7pocuwXCtiu/O8JeCr/qkcWmGWYNejwdFE0/cg+W0n4bLxmhpwC9n6ByCskeNtaS8N0ovHzJ406rd1Aaph0CQchJiwJCDpGd1GgKxibqFL7tuAw7+kMf8fnnRZyLbAkCD/D9dA7Moa0z0bCqsUeiYzPeD4np764cMnMtOePecrFh/LFIFk9qRnp4zDdu2ykPMrsYruCiIfPAMEshPL9MY2NpWCCIdmbzHio6HcpKPEYLtuMGPh3s/2Vqu7i8yZv0UcSQO8QH8BDbCZPWOBBXCMMgjnLvuj+EwZhNlH73opMech/BPAAKNirgkwVS+AWN3cECDEwYTOTF2350ktOqCfvggqvHMNAn9fsOKO7xWqhCEcc0liYzbcioa0j81Hs3fOkRxg8Q9qY ZMANtCdw yY874blBs3kz1xiSM7R0m4pfNI4u6GD0vECt/zZYBoO+ijrbRZ8iXsyy04whcIpaR3hBsXXzRb3pP84v4Z1uVuyA29G3FNUwNjKnETGEPJtVIZ7AF/ojJW1GRZD76J/eNF979WOOYg4zFdj6xpSiCdDQqY0QJ7l8kFObKgt0SAmjJbxZzPpioClLPR+ld3tcqpJ8gpKJ9mmMiem3BnNLNQnHT4GrzIOL/Z82yAjaBLv/dIKpcOSN/PS2jzS2B+p3yaZSxIvniT+krNDs1pEjaNcfGoNNqWIAqQ7AA1nkqr/RzO64CQwolcX1cxqszOMXjKNbmuTQxdb4+VSLDriGMdABHRA+8EZ22bUXdkLNutjPvp1lruU0v6OXKyrA7gwROF5fc922oA5BgduveX1AckBShA6ip1+nr2rIzA5q/B7/VS6eJM7xOkXomjhgLJ4tO1MNc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.09.23 15:49, Matthew Wilcox wrote: > On Fri, Sep 15, 2023 at 06:17:31PM +0800, Yajun Deng wrote: >> @@ -1176,8 +1175,8 @@ static void __page_check_anon_rmap(struct folio *folio, struct page *page, >> */ >> VM_BUG_ON_FOLIO(folio_anon_vma(folio)->root != vma->anon_vma->root, >> folio); >> - VM_BUG_ON_PAGE(page_to_pgoff(page) != linear_page_index(vma, address), >> - page); >> + VM_BUG_ON_FOLIO(folio_pgoff(folio) != linear_page_index(vma, address), >> + folio); > > No, this is not equivalent. You haven't hit any problems testing it > because you don't have large anonymous folios. Right, the address would have to be adjusted as well by the caller. -- Cheers, David / dhildenb