From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8E51C27C47 for ; Sat, 28 Oct 2023 01:31:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CC8B6B00F3; Fri, 27 Oct 2023 21:31:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 085C36B0106; Fri, 27 Oct 2023 21:31:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E864F6B0113; Fri, 27 Oct 2023 21:31:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D66DA6B00F3 for ; Fri, 27 Oct 2023 21:31:42 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AF32740899 for ; Sat, 28 Oct 2023 01:31:42 +0000 (UTC) X-FDA: 81393143244.21.4A5A0EA Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) by imf22.hostedemail.com (Postfix) with ESMTP id B4A0DC0006 for ; Sat, 28 Oct 2023 01:31:40 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="rRUEy/vz"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.187 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698456701; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lvs+eTtJ66DLSNeg3WuDmtpcRjw+t6vm77/M+6Bl8Z4=; b=gPMGs6F8Q13uOn06xwpb2u3DiONvQEglhBwP3b/U1yfkZySAVN+kzbczO4Ga2GWyI8N6v8 djoN3qeK5EgfLYMYhBWbYzvuCf+Y0HZf6+eiXkTrZzgZ1XfWYfLfTJTTjA/4zlBNnzSg3I B3UPiH0dD+n3rbeMJkMRzACwj/QHNiU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="rRUEy/vz"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.187 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698456701; a=rsa-sha256; cv=none; b=ma2Qg7Yf3GviO4/4zldhoWvxPg88IF50QIb/5uSfy+cf2Ty2aEolFcCxqSg/NNAafhHxbl oXbgMc7sYagFMp+gaSQ32KtSU2MPOymCnTafmaQiKcaoV+b12O4xMhbqtutEieJvU0kiEq hLd33dNPBOHntl8RVXjo3b+qQGa1SSM= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698456698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lvs+eTtJ66DLSNeg3WuDmtpcRjw+t6vm77/M+6Bl8Z4=; b=rRUEy/vzoQOeLfVrTuptdU2ev1h2MguLRiuU6o8ZnW0z2OzfBJY0I2fjNOSyuIlDeUcq4i aQD6HgjVcsjnghs0+hNZ4TLcJpz9irVHmY8U3Epvn6ZInIYttIdbVTSTV3vLCPpP4cGvS3 DojuUxSerOM50VJNytmOsglYvUV32G4= Date: Sat, 28 Oct 2023 09:30:54 +0800 MIME-Version: 1.0 Subject: Re: [RFC PATCH v3 1/7] slub: Keep track of whether slub is on the per-node partial list Content-Language: en-US To: Vlastimil Babka , cl@linux.com, penberg@kernel.org Cc: rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou References: <20231024093345.3676493-1-chengming.zhou@linux.dev> <20231024093345.3676493-2-chengming.zhou@linux.dev> <6d054dbe-c90d-591d-11ca-b9ad3787683d@suse.cz> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <6d054dbe-c90d-591d-11ca-b9ad3787683d@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: w7couh39woa6emjkxn3ysgck44hhasft X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B4A0DC0006 X-HE-Tag: 1698456700-374044 X-HE-Meta: U2FsdGVkX18QRS6vjRLGxwOTxD2zp3Qaho26VVE0kd7DTKnIsUGS6LN3fbjdaOJPjnApX1fNSr7ATur3lLW2RW1jAtW+G8xR+SetcjgKeQj2hr8MahPepuYnE9E0H5pdMY/1n08eQtFnxTiPdhjrMZv2tg53/7rfc35O37hnD6B29Lmr1C5Xs/iQMgccoP7MVCBkZtqrJQB0VGDp6yCAn9Kwc27x3ejaliHupZ1d9tqvLY1GABCfTiGBopxZXsk1A5IYfdMjG9Qna9D9yM6lc+Jd1GPsKzuoOz6s0Y5/BCWiQdk0gH8USYeVvSksTFu/wFoUdSEG7ZBclAtEK7ZCVnlYKXiZ5yTmpwhONj46KLlVG3qVcN5ny+oH2ge+TQW3ARsqfqPCkg1OkcQPjGvia5WJRRMVIHCU8aTcutFU6eK8pA/qQGyUdrCFNufBswguGkkOTaQn5DiJcb4qblEcrQN6fohco3LUruEWDSuaIyLscxmCSDqQTWWJzr20+FCpoWsSgHoLQqQLrJAimm4bxlS11Ty0AphVLXXZWeWvJnqz5yRAAkXO82JGrbgkkLKb6lisTmPS3fMhk74bqCsNH4WdGo9TDPdJYHFRLrZqcH4EScwMOCvTgJtqJ0e6nx09wiwOKxAZCN50meF7RB90Xt9JMT75V6UvGKxLIMTjEHOCuajJnfY0KQaQxtthp91MuAyzuKjkJKPlIeLDF8HW8g27hG9mGzkFAuiV2JtwO/sFLToV8RCLg/u9FRu638qfkWiLUsv6KNnPX5uftB5vC/+daXtUaE+LrCSknGwDvC6yFD4B4Umnd99tbuYghReLT7E50nNzLFfDuPxTeW2GLxoqYxi1JJ9/YoC/8sfMN8FSxJpyYODSf5TNxQPnc/Dji8kjYaJzHeuhaOgos0H7IMcXrKM99YH1gjOgZUFFSZLf1EpQesckX1UeLRR5+6wtdRxfizw1Gkt9chWPOHL jFIuBrDE M6afDrJt14kBCnNIWroDh8eRGAyvwXSfR1k4NGrn/AdcC/kGVAt9A8M40Ud5k0sEDXAcvdTR8b4ZFNC7BwAh6dA2ZfrGKFsqtGbNPdwojZBpHGyvQlNDWhFDUpjyoxcS3w72isk0HUq0I6EaDBBJ+2igLKX7F3A9vHFBnzOJrZVA7eWFslc5+CBGQXGe8nTkus4knZd4uRP/v3JxmnlFWyhasfzJDfTY0CM5E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/10/27 23:09, Vlastimil Babka wrote: > On 10/24/23 11:33, chengming.zhou@linux.dev wrote: >> From: Chengming Zhou >> >> Now we rely on the "frozen" bit to see if we should manipulate the >> slab->slab_list, which will be changed in the following patch. >> >> Instead we introduce another way to keep track of whether slub is on >> the per-node partial list, here we reuse the PG_workingset bit. >> >> We use __set_bit and __clear_bit directly instead of the atomic version >> for better performance and it's safe since it's protected by the slub >> node list_lock. >> >> Signed-off-by: Chengming Zhou >> --- >> mm/slab.h | 19 +++++++++++++++++++ >> mm/slub.c | 3 +++ >> 2 files changed, 22 insertions(+) >> >> diff --git a/mm/slab.h b/mm/slab.h >> index 8cd3294fedf5..50522b688cfb 100644 >> --- a/mm/slab.h >> +++ b/mm/slab.h > > I think these helper might just go to mm/slub.c as nothing else would use them. > Ok. >> @@ -193,6 +193,25 @@ static inline void __slab_clear_pfmemalloc(struct slab *slab) >> __folio_clear_active(slab_folio(slab)); >> } >> >> +/* >> + * Slub reuse PG_workingset bit to keep track of whether it's on > > "SLUB reuses" ... > > Looks fine otherwise! > Will fix it. Thanks!