From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7097EC433EF for ; Fri, 28 Jan 2022 11:05:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03BDF6B0071; Fri, 28 Jan 2022 06:05:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F2DBB6B0072; Fri, 28 Jan 2022 06:05:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF6166B0073; Fri, 28 Jan 2022 06:05:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id CCB5F6B0071 for ; Fri, 28 Jan 2022 06:05:37 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 658018249980 for ; Fri, 28 Jan 2022 11:05:37 +0000 (UTC) X-FDA: 79079415114.25.F26C7E2 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf12.hostedemail.com (Postfix) with ESMTP id 0713B4000B for ; Fri, 28 Jan 2022 11:05:36 +0000 (UTC) Received: by mail-lj1-f180.google.com with SMTP id b14so8559413ljb.0 for ; Fri, 28 Jan 2022 03:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=W6NOesChZuwW+0urMmtMeZ98ITEecm90pqAZ1qyy3yA=; b=ouTGjraeJg14bd41iw0LYrvvVO9rX/SUMnntEOZL2Uy+1OGgywIb4ZUvVySFvjhMHp oUMUe9dS9FVyPIrQlQoVKr2LDSlWwd1/SEl8SL0qgvBVSZGyUfOrgDyGeLKUVJ32ZW+2 uk4c+Ccpdhg6iQe7eB0ComjUHjcw5oCBztI5+59/3DC6mNhUR+zw7FDaz7XbF8IyaNai 6Kog/OakGGDU5+o5UsroqOLduR9LtMSu0pPp4bV3IWIHCd17GLu/oOapsJxhmgoslIjW ST9xSZwqFl/nEsAKJr3xsbt9AS28A2TDG7OadrxJeKx7EacQlyKoQtLanDdwDd9SZuU1 Hgbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=W6NOesChZuwW+0urMmtMeZ98ITEecm90pqAZ1qyy3yA=; b=d6kWLw7YKxaCHxAfDMRWD4avXpS9o9V3Kqn1NQ2AquuMcaOdhv3zWTtkm/F0XDXx/v +g1QyeyV5R3jy8ZnNga/8HK/HcAIRrRdhUdWztVR/eSe4oLmNp0K22x96xia7DF9mFTH Onc9Vfs5aEwzLtssW373E0PbOL1uMhUSDRxcGrJUpiHoRWy0Rgjel5S4ctq2jsXVs/Rr shsHfXCGwO9DNAxSjXyI3bTwcVihocj2+7uwc/VJEQEq8oLfu99iywFaFHnksncICwD5 1xpO3eNzScfDjlp0brW2Lro300HH0VnDbNQSU10XR3RWy2KcsYAS14FBMDv+4q4EuS0W ZtfA== X-Gm-Message-State: AOAM5315HZFhqAHi7KrEZm4V/gXh7osapka+05xM/TAydycoOwMp3Ux7 WpF6kxtX788BT3Fe3s+8Yzijwt/tEPM= X-Google-Smtp-Source: ABdhPJzLrsJjH1icU0xvOMufiM3MyvLuJ9O/dhS2MiFtuLc9k15ISguOjY5depMRiXoXpp9z4/XBFw== X-Received: by 2002:a05:651c:23c:: with SMTP id z28mr5630107ljn.525.1643367935515; Fri, 28 Jan 2022 03:05:35 -0800 (PST) Received: from [10.3.154.43] (staticline-31-183-166-172.toya.net.pl. [31.183.166.172]) by smtp.gmail.com with ESMTPSA id q14sm746466lfm.120.2022.01.28.03.05.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 03:05:34 -0800 (PST) Message-ID: Subject: Re: [PATCH 03/16] tools/include: Add _RET_IP_ and math definitions to kernel.h From: Karolina Drobnik To: Matthew Wilcox Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mike.rapoport@gmail.com, linux-kernel@vger.kernel.org Date: Fri, 28 Jan 2022 12:05:33 +0100 In-Reply-To: References: <5baa036aadb6436c7c36589ce591baaf827aec0b.1643206612.git.karolinadrobnik@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0713B4000B X-Rspam-User: nil Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ouTGjrae; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of karolinadrobnik@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=karolinadrobnik@gmail.com X-Stat-Signature: c68rxga81eak6y8gd1xj3bo8myqx93m6 X-Rspamd-Server: rspam08 X-HE-Tag: 1643367936-251232 X-Bogosity: Ham, tests=bogofilter, spamicity=0.006689, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2022-01-27 at 13:54 +0000, Matthew Wilcox wrote: > On Thu, Jan 27, 2022 at 02:21:21PM +0100, Karolina Drobnik wrote: > > Add max_t, min_t and clamp functions, together with _RET_IP_ > > definition, so they can be used in testing. > > Rather than adding our own definitions of min/max/clamp, have > you considered using #include "../../../include/linux/minmax.h"? I tried doing it in the very beginning and couldn't get it to compile. Now, I see it's because in minmax.h we use __UNIQUE_ID, which is undefined because of "#ifdef __KERNEL__" in include/linux/compiler.h. > In my experience reusing this kind of "leaf" header works out > better than duplicating it. I like this approach as well, and I tried to use it in other memblock headers. Still, as it's not that straightforward here, and I went for duplication.