From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9767C433F5 for ; Wed, 27 Apr 2022 06:36:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A2D66B0073; Wed, 27 Apr 2022 02:36:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22B1C6B0075; Wed, 27 Apr 2022 02:36:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F3066B0078; Wed, 27 Apr 2022 02:36:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id EDE036B0073 for ; Wed, 27 Apr 2022 02:36:43 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id CB5FC81B44 for ; Wed, 27 Apr 2022 06:36:43 +0000 (UTC) X-FDA: 79401700686.28.F752CCC Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf18.hostedemail.com (Postfix) with ESMTP id 90F5F1C004E for ; Wed, 27 Apr 2022 06:36:38 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Kp8C56QRkzfbHl; Wed, 27 Apr 2022 14:35:45 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 27 Apr 2022 14:36:39 +0800 Subject: Re: [PATCH v3 3/6] mm/vmscan: activate swap-backed executable folios after first usage To: "ying.huang@intel.com" , Joonsoo Kim CC: Andrew Morton , Joonsoo Kim , Christoph Hellwig , Oscar Salvador , Linux Memory Management List , LKML References: <20220425111232.23182-1-linmiaohe@huawei.com> <20220425111232.23182-4-linmiaohe@huawei.com> <20220425140711.0c1898862fc817135bbbc56e@linux-foundation.org> <6b74e6f3799032d4f12bae0d97a453dc85d03028.camel@intel.com> <5a108252-4eb8-e353-da3d-a96b8799fadf@huawei.com> <75adcfe33483d5e30855226b6efcd8dcd2f52925.camel@intel.com> From: Miaohe Lin Message-ID: Date: Wed, 27 Apr 2022 14:36:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <75adcfe33483d5e30855226b6efcd8dcd2f52925.camel@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Stat-Signature: kbx45zuzo87q5jdm56nijqmsjkp7utww Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 90F5F1C004E X-HE-Tag: 1651041398-619434 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/4/27 14:10, ying.huang@intel.com wrote: > On Wed, 2022-04-27 at 13:08 +0900, Joonsoo Kim wrote: >> Hello, >> >> 2022년 4월 26일 (화) 오후 3:58, Miaohe Lin 님이 작성: >>> >>> On 2022/4/26 10:02, ying.huang@intel.com wrote: >>>> On Mon, 2022-04-25 at 14:07 -0700, Andrew Morton wrote: >>>>> On Mon, 25 Apr 2022 19:12:29 +0800 Miaohe Lin wrote: >>>>> >>>>>> We should activate swap-backed executable folios (e.g. tmpfs) after first >>>>>> usage so that executable code gets yet better chance to stay in memory. >> >> Missing activation for swap-backed executable page is the intended operation. >> So, I disagree with this patch until some numbers are provided. >> See following discussion. >> >> https://lore.kernel.org/all/20200316161208.GB67986@cmpxchg.org/T/#u > > Thanks for your pointer. Now I understood more about this. I agree to > keep the original behavior unless we can prove the change with numbers. > Many thanks both! I will keep the original behavior. :) > Best Regards, > Huang, Ying > > > . >