From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB949CFB440 for ; Mon, 7 Oct 2024 09:46:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 472176B00BC; Mon, 7 Oct 2024 05:46:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FAE36B00C0; Mon, 7 Oct 2024 05:46:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24DBB6B00ED; Mon, 7 Oct 2024 05:46:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 03D686B00BC for ; Mon, 7 Oct 2024 05:46:53 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A0DA01415AC for ; Mon, 7 Oct 2024 09:46:53 +0000 (UTC) X-FDA: 82646327106.18.82E544F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 71FCD1A0013 for ; Mon, 7 Oct 2024 09:46:51 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e1Qd9BsW; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728294277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=otqyaqz0zd2i/ALubyhMfBSmaeQz9pWZmVtHWamw7N8=; b=YLvO3C3DlsUiEJmW94mLe+mqDjz7VWfnMeyz02/Nwv/LPnFgXlhKvuC/2FxPIf7jvLhKGx 3T3KZmiidQ+z5HbOit9HzYKZP8piXqsX/y7NYygIosGStU6X8o2bW8zFVzh0hqjds0ncMF nIGkBhYQqCS8utnnP0XqkXmctr2iBMc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728294277; a=rsa-sha256; cv=none; b=m7e0VUn1x2h54Gh45d0x1ymO3IrG8qUolERlfffrrfKve8nWoQrorZPNEHszKxi7u3mi3i USm/l9scc3q9tvIyTtX/IPZ07FvGDHEvuPUfj9moxQFKA5ACH8jjyg9rkzF8shYcME2euF TkOEXOtSOT6xHfLkXblUisGYmuJMt4E= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e1Qd9BsW; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728294410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=otqyaqz0zd2i/ALubyhMfBSmaeQz9pWZmVtHWamw7N8=; b=e1Qd9BsW9ZpJODZfbBrXOLS1mJQqQC0H3QbIv+dImJQbTeUd0hIInzOk7as34soHwPrAXq YLvV9nvmhr0TOQn0GaIOuEFNWz40jQjz0DbvFsFvwUMJmlgYES20R2CsU2a4XiRV06VrNa NWMj7x2pMTiMfDdRpnFg/mgKMMko2zs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-157-NEi4hZKeMnGvuO-7cU_tQw-1; Mon, 07 Oct 2024 05:46:47 -0400 X-MC-Unique: NEi4hZKeMnGvuO-7cU_tQw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42f89a68c29so14907045e9.1 for ; Mon, 07 Oct 2024 02:46:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728294406; x=1728899206; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=otqyaqz0zd2i/ALubyhMfBSmaeQz9pWZmVtHWamw7N8=; b=tpxNs6J6HOr1p7gSw7qlW1R0DNViflm6XBlcKoNl8YZ8Qc1gqE1JZhQy8dIQmTFdI+ r3N797vhyf6dSEDUjIhfgYsoGR1pUsKwGNvCIzOOeeqzFJWGnEPE094Cukf3oMUSBP3t mDLMDkGkws00EFq36ovVZJRBI7ME+bPUIVhGNdxELgFgAe72bWL5J6xUj/0LAFqftsPc IaSTGPFeMwo9qQcti0FWhutuNqTUBovu2xlA7TA9aDFk2fQEBi3ocWy0rskfpmZ1eamK NCc4AnN3b7VYY0ADfkxWUU2I+ex65qsIaoP0LtM0uBm+DXNKrBZ05XpoB2w2JbRn2GH8 VmLQ== X-Gm-Message-State: AOJu0YwDNzZqWyEO9TJxuxs+Qm1vLrljYq/GDH5j0Gj22MBkD35y9Hqo pd0PgKBKNHlJdd5nW1MqzscDecTZi4B53CMUY2a00LynIS4Gxg/4zSs7SROPd7TewB81tONktPL rdIzk2ZIY0/mQ6Z/TsCCTEz7Yf0nTcJJowj2CNYQym926zZ1s X-Received: by 2002:a5d:5043:0:b0:37c:c80e:d030 with SMTP id ffacd0b85a97d-37d0e8f7758mr5444858f8f.53.1728294406496; Mon, 07 Oct 2024 02:46:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE+OUtaGBM7yNn3U3xdrE6niKJcB8LzJWajRfTsiDutpUx/33lRu9XvZ27HjKNIFkoGLc5vUA== X-Received: by 2002:a5d:5043:0:b0:37c:c80e:d030 with SMTP id ffacd0b85a97d-37d0e8f7758mr5444841f8f.53.1728294406028; Mon, 07 Oct 2024 02:46:46 -0700 (PDT) Received: from ?IPV6:2003:cb:c725:8700:77c7:bde:9446:8d34? (p200300cbc725870077c70bde94468d34.dip0.t-ipconnect.de. [2003:cb:c725:8700:77c7:bde:9446:8d34]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d1690f265sm5295726f8f.19.2024.10.07.02.46.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Oct 2024 02:46:45 -0700 (PDT) Message-ID: Date: Mon, 7 Oct 2024 11:46:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] mm: Add PageAnonNotKsm() To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, Alex Shi References: <20241002152533.1350629-1-willy@infradead.org> <20241002152533.1350629-5-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241002152533.1350629-5-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 71FCD1A0013 X-Stat-Signature: 499a64esiy4zi5ndmsqemuxt7job4upu X-HE-Tag: 1728294411-916482 X-HE-Meta: U2FsdGVkX1+s3M2GjO9YRDUkDfD9ELGIMlLV8bJgOCNCljTZC2lGGAXygbTLyYRhUGQfD9T4vSseughce2r0uWCSNzKXeGW002w1SmCaVRk0teOQ9/4lrxqP+FUpTONTS868uptD0lDwaYXGbqzP6CDs1S/2FSRE+HqIyn4mBFibCFGt07NOzNsFJCBy0nTL8oeCASdo2CPyi8ZG0FCOpt6NCS+p1rWE7wkGyU7qN165o8TSPXmSGUnN9J0qC5vF0q2H8A9LuDITc32k2mgbyxhztKy5XJFRnVCh85NzNYSimyp6VO6pB1IQziJtHmr53btPRSEy9ioKfIAOCBqyodtxQMd76urdIgFK3pmJ4PDEgz8ZWqL6XwH7LBuFCxC7Bnfj2k3vvegUZG/41bDPxubcYjEqgHDgPy0qT1Us1xr9ph1SXMe1SRSqv8XvFzUxApzvlILG1UvwW4aCyP5TF2a9/49pU0967Z5Mc5ppMFu42CPz8+gcZfP47SgT8jvRChtkL5g/qYuf2iBboNdtD9OO+KvSVprbupPIlolMcuerVLGGg2WQSaVK4I8kAjfs8Kp1LtaI2KW0lMHHI+5GnM5dFNRLnmD6Z5H3jJ1Z5ICJIjfJk/E2CNhNuRmuavjrDgkUrY6AaYC9g0CJS27HKLqLHdlPOfVP1OKRmtqUAH59or1UmI52n116V2Q9JbGJ2aMEdrA6dEaVY2fvKcZtE6pV36l53hZv/DOCO6oO2weCFr+r2NjKLX32COsl03SzZ90f7Eps+5pWToBwfRfsqE/Y360wzfp8bYI0/Ovv/y9x4I3/XaPFmGKMiZ6gDhrbDaCL3p9BYWdn+dBZRfCI/V2c07SuzArm88YKPwAEKoGa8V7GMmVRSdo84W1AXSu6rG4sni6oKqctvoDwpzHN0BRjBO552rM3nETTHaJXKGPQ8Fxwz6cSHfhbwcObNI26+GiwVd2bTjKBAKPvPCm dvN9xdaC kts/uuT13KQdFlrjW9NZKpIf2ceU0WN7rKkkqk9aZ/yIApixwvC/aBd0VrLsMkzS8BffaQ4Hc0Bku/zBmMIpyacjoVMlcCfgAv6UfWnIWecxjUJNTp05R8m0jBWeg4+ww5vqaupa3Wcu8XKpJUOcB7gKcV23BPCe7FeRrik4g8LxDKfNPAjUdxr1/PecYm6Y7JhoUIfyH1V/rj8YQDWLGLNWqOGrKUuMtppe3o3jfmX6vHUthN71JWZBfJr1X3QeDF7LKLBqBmdKNaH2oM+qxMfZ1XPQ+X4HOR0MEBezcQIPpRJMBLyTpFKO5Yw06Hv7SwRdcKgSeG8jjf3DPRvo1Pz7WcFsPIABbreMooJ7tl+y0BSf5lyRjRy+0sbZRlj/GltS2FeXnmumj8RAR9fj2m86R8lwj8g8CPMLDHyAFNdzTJgLJ/roIhQ4xaAJlyAOdXWZn6MDlT8pXepyLv5UDce6l9/sny5GHiZmZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.10.24 17:25, Matthew Wilcox (Oracle) wrote: > Check that this anonymous page is really anonymous, not > anonymous-or-KSM. This optimises the debug check, but its real purpose > is to remove the last two users of PageKsm(). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/page-flags.h | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 4c2dfe289046..157c4ffc2fdc 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -689,6 +689,13 @@ static __always_inline bool folio_test_anon(const struct folio *folio) > return ((unsigned long)folio->mapping & PAGE_MAPPING_ANON) != 0; > } > > +static __always_inline bool PageAnonNotKsm(const struct page *page) > +{ > + unsigned long flags = (unsigned long)page_folio(page)->mapping; > + > + return (flags & PAGE_MAPPING_FLAGS) == PAGE_MAPPING_ANON; > +} > + > static __always_inline bool PageAnon(const struct page *page) > { > return folio_test_anon(page_folio(page)); > @@ -1129,14 +1136,14 @@ static __always_inline int PageAnonExclusive(const struct page *page) > > static __always_inline void SetPageAnonExclusive(struct page *page) > { > - VM_BUG_ON_PGFLAGS(!PageAnon(page) || PageKsm(page), page); > + VM_BUG_ON_PGFLAGS(PageAnonNotKsm(page), page); > VM_BUG_ON_PGFLAGS(PageHuge(page) && !PageHead(page), page); > set_bit(PG_anon_exclusive, &PF_ANY(page, 1)->flags); > } > > static __always_inline void ClearPageAnonExclusive(struct page *page) > { > - VM_BUG_ON_PGFLAGS(!PageAnon(page) || PageKsm(page), page); > + VM_BUG_ON_PGFLAGS(PageAnonNotKsm(page), page); > VM_BUG_ON_PGFLAGS(PageHuge(page) && !PageHead(page), page); > clear_bit(PG_anon_exclusive, &PF_ANY(page, 1)->flags); > } With the "!" added in both cases Acked-by: David Hildenbrand -- Cheers, David / dhildenb