From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 970CDC433FE for ; Wed, 26 Oct 2022 06:18:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6A458E0002; Wed, 26 Oct 2022 02:18:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C19D78E0001; Wed, 26 Oct 2022 02:18:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE1D58E0002; Wed, 26 Oct 2022 02:18:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9C0D38E0001 for ; Wed, 26 Oct 2022 02:18:07 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 72F4C120202 for ; Wed, 26 Oct 2022 06:18:07 +0000 (UTC) X-FDA: 80062095414.13.75E09A6 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by imf22.hostedemail.com (Postfix) with ESMTP id BEF36C000F for ; Wed, 26 Oct 2022 06:18:06 +0000 (UTC) MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1666765084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F1h2nRHncW11E9hbd/qHDUawOsfI9aSjq5L1zDtP0vo=; b=XaHlgRjh0xMKIeZT1Iyrc7R4v2F3klDrIor2q8nv0TUmZP0JVdW58yMsP8/WTwMGH46IQE gLpjVLn7E93oTmKQVn3F3fS5Q/Fa7hSqTsiv3YQC+XMTbOkKNnWtQcrrV+unkExj/eb4cy RRZiPUYw5B/DYUNqXaNzTlniJt90LXg= Date: Wed, 26 Oct 2022 06:18:03 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Yajun Deng" Message-ID: Subject: Re: [PATCH] memblock: remove repeat round To: "Mike Rapoport" Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: References: <20221019120337.2098298-1-yajun.deng@linux.dev> <6cccd4cba4f8407d52815c68f60446fb@linux.dev> X-Migadu-Flow: FLOW_OUT ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666765087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F1h2nRHncW11E9hbd/qHDUawOsfI9aSjq5L1zDtP0vo=; b=Fw9Ty+LxJVcLX5zwtCPq4QYtHmy2q0pIOcwzNO4ULPseKUKXIHpVcjcn7wGEOylkxY2486 +zcZpegZrvVIMavIQryewEZ3rU6RSjBFdZPqqW+Q0c+sQMWtG/6oebPEmVJ4Q0+EcbZXMn PQA/4ANDZR8fXR3Xx6G95aBoigaGy54= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XaHlgRjh; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of yajun.deng@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666765087; a=rsa-sha256; cv=none; b=jUeGuWi/KpncydpvrutzYSYUA/v/fORWpXAzBOYIU+DXvREbmC9Y/M2bMIstb6p1HTBtfE k0b6vnbXIoZBJOOsZrT+EK1MwSAwIHUnaCiIvG7Y83A7Oz4g8itHBph0ewvd1gQHg1jAhj 9VKDUDO0udt3wTHH7hG8Zx9Phx/Rclk= X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: BEF36C000F X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XaHlgRjh; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of yajun.deng@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev X-Stat-Signature: j5h8rfiqqgqsh4j3mrbeh877b8hrpfdy X-HE-Tag: 1666765086-655928 X-Bogosity: Ham, tests=bogofilter, spamicity=0.075845, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: October 26, 2022 2:04 PM, "Mike Rapoport" wrote:=0A=0A>= On Tue, Oct 25, 2022 at 03:24:58AM +0000, Yajun Deng wrote:=0A> =0A>> Oc= tober 25, 2022 12:15 AM, "Mike Rapoport" wrote:=0A>> = =0A>> @@ -598,22 +597,6 @@ static int __init_memblock memblock_add_range(= struct memblock_type *type,=0A>> return 0;=0A>> }=0A>> =0A>> - /*=0A>> - = * The worst case is when new range overlaps all existing regions,=0A>> - = * then we'll need type->cnt + 1 empty regions in @type. So if=0A>> - * ty= pe->cnt * 2 + 1 is less than type->max, we know=0A>> - * that there is en= ough empty regions in @type, and we can insert=0A>> - * regions directly.= =0A>> - */=0A>> - if (type->cnt * 2 + 1 < type->max)=0A>> - insert =3D tr= ue;=0A>> -=0A>> -repeat:=0A>> - /*=0A>> - * The following is executed twi= ce. Once with %false @insert and=0A>> - * then with %true. The first coun= ts the number of regions needed=0A>> - * to accommodate the new area. The= second actually inserts them.=0A>> - */=0A>> base =3D obase;=0A>> nr_new= =3D 0;=0A>> =0A>> I believe nr_new variable is no longer needed, is it?= =0A>> =0A>> No, nr_new is needed before memblock_merge_regions() for retu= rn.=0A> =0A> Why?=0A> =0ASorry, nr_new was removed, and added ocnt variab= le for the original of type->cnt.=0A=0AI already sent another patch with = '[PATCH v2] memblock: don't run loop in =0Amemblock_add_range() twice' su= bject, you can see that.=0A=0A> --=0A> Sincerely yours,=0A> Mike.