From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC3B2C54E58 for ; Wed, 13 Mar 2024 13:52:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1932C8002B; Wed, 13 Mar 2024 09:52:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14374940010; Wed, 13 Mar 2024 09:52:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFEE38002B; Wed, 13 Mar 2024 09:52:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E0860940010 for ; Wed, 13 Mar 2024 09:52:32 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BD3B51C1256 for ; Wed, 13 Mar 2024 13:52:32 +0000 (UTC) X-FDA: 81892155744.03.B18FD03 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id 7701F40021 for ; Wed, 13 Mar 2024 13:52:30 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Maisu8p+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="IkYTQT/R"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Maisu8p+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="IkYTQT/R"; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710337950; a=rsa-sha256; cv=none; b=F3tGKamUGUbp8XxAvNgsEa6FFXeEDX984QEi8SSa+AJqrqzkbYgTPt5pee5Xj0svS9dGEA dEZ5u5jVjtnJBAiXhe6mIrGY3cgcjtJhtrIYDikq+TqGdp7dIbvXpINnaj13Yt4biihAKZ 7XQmyimgBkSls9xCIvKG8K2V0Y+ViZY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Maisu8p+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="IkYTQT/R"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Maisu8p+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="IkYTQT/R"; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710337950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XFhbbMRYCJAgLqELLxWLqfsH3hbHEF1BH4hx+bhAMaM=; b=G0vfrf1uWo//XwFglUsczZRO5Q8RbdttByuvTk66qO3eGlhBQNIWqicORGkyroFmDVIJqJ x28hbhTqgegBFl55pJcN7HgWPXBByqLMbghVIenvD6Rl/6bBLm1zZeR5Wi3Kux8YVjIQyz HDDWEtLDG3uBqQrLIimv4s4OG9Lg0Ho= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 20C701F7CD; Wed, 13 Mar 2024 13:52:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1710337948; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XFhbbMRYCJAgLqELLxWLqfsH3hbHEF1BH4hx+bhAMaM=; b=Maisu8p+8VOLtYY3TrJkR6rfS5B+biJ+LLvd8LzgWVs36+MO0dIgBYONhiDpj9BO0wU7As 5WBYSK4zyJyrGYI8oVkWNfm29jvIUlPG3mv1SaFBB4ETsn/Low2VGH0rrgxV/8AONovAQG lFNCUTxmHnFtwn6WdPREzN5h/FCJMs4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1710337948; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XFhbbMRYCJAgLqELLxWLqfsH3hbHEF1BH4hx+bhAMaM=; b=IkYTQT/R3aiB5aD7xFbTOmZOArH9iK+B5x3LUVlKBuTsf4vF+4u7JaIoaAkSErym3uJ5X+ FaW3DBH6chjv6vDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1710337948; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XFhbbMRYCJAgLqELLxWLqfsH3hbHEF1BH4hx+bhAMaM=; b=Maisu8p+8VOLtYY3TrJkR6rfS5B+biJ+LLvd8LzgWVs36+MO0dIgBYONhiDpj9BO0wU7As 5WBYSK4zyJyrGYI8oVkWNfm29jvIUlPG3mv1SaFBB4ETsn/Low2VGH0rrgxV/8AONovAQG lFNCUTxmHnFtwn6WdPREzN5h/FCJMs4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1710337948; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XFhbbMRYCJAgLqELLxWLqfsH3hbHEF1BH4hx+bhAMaM=; b=IkYTQT/R3aiB5aD7xFbTOmZOArH9iK+B5x3LUVlKBuTsf4vF+4u7JaIoaAkSErym3uJ5X+ FaW3DBH6chjv6vDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AAB161397F; Wed, 13 Mar 2024 13:52:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id E5Z1KZuv8WWIVAAAD6G6ig (envelope-from ); Wed, 13 Mar 2024 13:52:27 +0000 Message-ID: Date: Wed, 13 Mar 2024 14:53:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 03/37] mm/slub: Mark slab_free_freelist_hook() __always_inline To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240306182440.2003814-1-surenb@google.com> <20240306182440.2003814-4-surenb@google.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <20240306182440.2003814-4-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7701F40021 X-Stat-Signature: 4re4ap5bmr9tdj1fka3k7ceohzrbg5ho X-HE-Tag: 1710337950-956058 X-HE-Meta: U2FsdGVkX19zHtEmjT7iM6IYV6TCb0EhKGAJuqBc6h+fewchs1BPWDuBaHubsJlpArKrwnfQcaZ6i4um8/4kiwaaekViYK8aPJqaz9f4lXXosjN3sDSDYnWgdkUk4jbhRJeiJ2ay+pliAgch5S5EjlBIR9gfEsWD0sTx5mj8jrPxeGhSKpbumWnSrCfQH66rOw1kj3TLF5BWLl+9cs1RrI+8feuVBE/Tbj1t4y/jOyM/1vt1FQYUgSAgyYs2f5OqJsknd1SgzUn/hSb+6pUhFvlpifqcV8mBJZ0AyJACOGmwMrRZER36n5WM7bpiRwtyFvytY2ImouFaZlwnCx10gMy33QV15nQAnHbjlpEcUxTyHKjUyru7sE2Bv966DAoJY/8zSn9csamLJWy3InWKPKRXoGBQH55xJOcqkTClifYHFfHUDsCI3WGjVsQLYbSXMq/BKGGCgWyUswX4vJaF8tUkBEqw20Gtqe2xoQ5mqbY0GVS40Z9wD7TXcgBDZ5E9Crh9cHTFrFBaXf9yZUMwSviTmiHKl/zALGQSZHmkgHgYpqhKyExykncqC0m9a6SEwX1O77yPFd+2EV89ZHa1MhTx83sxj/yg1rjIh95ThYavu7TFX5wXAfZDy7mejbT/84ui0W84RK5wtSli5K2bO+XJTTiXTUo7mcODDubdjRvQOIM7zDpftrI2v0OK9mFCKbDrj68wl/7TZplQdPvKW73j6IpYELNyPOgJEvVAVuVi5u9GoRq04xSLDwp/bN1o+ZVmq0G6ZjxomQz6nZNxjNspgb3CVoBaOXmyvJO4yHVHyDlM89ILkaLImQiGK0+WTilV4lIK6XAimp1V6DYUbQ9vu4InV/5Nj4v6k+3zN4uMR2YgOrmpl44t1x/l5C1L8Uz/bUn9aEa6HjDzgX6H+KQbT4e8hLw/jgzORlvzVy4Hiylh8g8bYtEnVJ7LU7tN8kb3EIbH15mdj/1CwR0 Klzvn0y2 XO6pp3+26cRDzwkwg+UxZ4Y3z1FmxZjDLho2BzuCKcjnStyMcUO67K3CZrtdFvae/P4CepalZiI79mpjgam5bbRjFVg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/6/24 19:24, Suren Baghdasaryan wrote: > From: Kent Overstreet > > It seems we need to be more forceful with the compiler on this one. > This is done for performance reasons only. > > Signed-off-by: Kent Overstreet > Signed-off-by: Suren Baghdasaryan > Reviewed-by: Kees Cook > Reviewed-by: Pasha Tatashin Reviewed-by: Vlastimil Babka > --- > mm/slub.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 2ef88bbf56a3..0f3369f6188b 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2121,9 +2121,9 @@ bool slab_free_hook(struct kmem_cache *s, void *x, bool init) > return !kasan_slab_free(s, x, init); > } > > -static inline bool slab_free_freelist_hook(struct kmem_cache *s, > - void **head, void **tail, > - int *cnt) > +static __fastpath_inline > +bool slab_free_freelist_hook(struct kmem_cache *s, void **head, void **tail, > + int *cnt) > { > > void *object;