From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81B6BC433EF for ; Wed, 8 Jun 2022 08:25:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F15408D0015; Wed, 8 Jun 2022 04:25:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E77368D0009; Wed, 8 Jun 2022 04:25:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCA8B8D0015; Wed, 8 Jun 2022 04:25:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B72FE8D0009 for ; Wed, 8 Jun 2022 04:25:06 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8954E351B8 for ; Wed, 8 Jun 2022 08:25:06 +0000 (UTC) X-FDA: 79554383412.11.67E447B Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf07.hostedemail.com (Postfix) with ESMTP id D0B6340004 for ; Wed, 8 Jun 2022 08:25:05 +0000 (UTC) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25888rON020142; Wed, 8 Jun 2022 08:24:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=n8YORMICtcoEXTgTlEMkLLrxOJq2wW8tJfHevJnl+N8=; b=GDeKjKqoZhFWfT7mL5+blzBjwS5YYR/PJkUTQI7Ojn0bqEwz6YE4ZjjXZfNyv8rUKCCf k0nJKIwGT12MJNTdKP78ZyqOYsIyJFNuq37plndq6vdLweENV94CO8Hot07jMD2ajgH8 PXtmUbv/LNWPymo83ePbGVsisBFhC40JKz0ccp1DSX+soM497a16GH5Arau9avVEx4+g aTkizcib1++5WsKzOV9dg2IG4A/Gy+RyOpjGIzaQ5wmIhsIxe3l3Ycneh0FGgr3ye23n qPCl9Pox5Hb2i/okXz/MT1F32rOgIUE0zxWDuCshzWsWRxBOfABobvXXjHi4VIg6RrV2 SA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gjr0mra70-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jun 2022 08:24:50 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2588DT6L007042; Wed, 8 Jun 2022 08:24:50 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gjr0mra68-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jun 2022 08:24:49 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2588JwuB025071; Wed, 8 Jun 2022 08:24:47 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma03ams.nl.ibm.com with ESMTP id 3gfy19cv8w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jun 2022 08:24:47 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2588OSsL22741320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 8 Jun 2022 08:24:28 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 12A895204E; Wed, 8 Jun 2022 08:24:45 +0000 (GMT) Received: from [9.43.53.124] (unknown [9.43.53.124]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 78D5152050; Wed, 8 Jun 2022 08:24:39 +0000 (GMT) Message-ID: Date: Wed, 8 Jun 2022 13:54:38 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [RFC PATCH v4 1/7] mm/demotion: Add support for explicit memory tiers Content-Language: en-US To: Ying Huang , linux-mm@kvack.org, akpm@linux-foundation.org Cc: Greg Thelen , Yang Shi , Davidlohr Bueso , Tim C Chen , Brice Goglin , Michal Hocko , Linux Kernel Mailing List , Hesham Almatary , Dave Hansen , Jonathan Cameron , Alistair Popple , Dan Williams , Feng Tang , Jagdish Gediya , Baolin Wang , David Rientjes References: <20220527122528.129445-1-aneesh.kumar@linux.ibm.com> <20220527122528.129445-2-aneesh.kumar@linux.ibm.com> <604403db000ced33f997688ce82eaa43ed6c8bbe.camel@intel.com> From: Aneesh Kumar K V In-Reply-To: <604403db000ced33f997688ce82eaa43ed6c8bbe.camel@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: nmOCLq0ZUk4nnP_msbBOQTEgj7rag_i0 X-Proofpoint-ORIG-GUID: 7vBFHH2_ZDmACl9Qr52T_s72RjWl9TLR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-08_02,2022-06-07_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 mlxlogscore=999 clxscore=1015 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206080035 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D0B6340004 X-Stat-Signature: mhge7435opkixpjr7qawyo64aapukuz7 X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=GDeKjKqo; spf=pass (imf07.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com X-HE-Tag: 1654676705-222660 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/8/22 12:46 PM, Ying Huang wrote: > On Fri, 2022-05-27 at 17:55 +0530, Aneesh Kumar K.V wrote: > > [snip] > >> >> +static int __init memory_tier_init(void) >> +{ >> + int ret; >> + >> + ret = subsys_system_register(&memory_tier_subsys, memory_tier_attr_groups); >> + if (ret) >> + panic("%s() failed to register subsystem: %d\n", __func__, ret); > > I don't think we should go panic for failing to register subsys and > device for memory tiers. Just pr_err() should be enough. > So you are suggesting we continue to work with memory tiers with no userspace interface? >> + >> + /* >> + * Register only default memory tier to hide all empty >> + * memory tier from sysfs. >> + */ >> + ret = register_memory_tier(DEFAULT_MEMORY_TIER); >> + if (ret) >> + panic("%s() failed to register memory tier: %d\n", __func__, ret); >> + >> + /* >> + * CPU only nodes are not part of memoty tiers. >> + */ >> + memory_tiers[DEFAULT_MEMORY_TIER]->nodelist = node_states[N_MEMORY]; >> + >> + return 0; >> +} >> +subsys_initcall(memory_tier_init); >> + >> +#endif /* CONFIG_TIERED_MEMORY */ > >