From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CA22CDE001 for ; Thu, 25 Jun 2026 14:57:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06CBD6B00AA; Thu, 25 Jun 2026 10:57:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0449F6B00AB; Thu, 25 Jun 2026 10:57:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E50796B00AC; Thu, 25 Jun 2026 10:57:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B38A86B00AA for ; Thu, 25 Jun 2026 10:57:33 -0400 (EDT) Received: from smtpin25.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2CBA61C3BF3 for ; Thu, 25 Jun 2026 14:57:33 +0000 (UTC) X-FDA: 84918738786.25.16AC97A Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf02.hostedemail.com (Postfix) with ESMTP id 5288580007 for ; Thu, 25 Jun 2026 14:57:31 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=DL1K+Jv9; spf=pass (imf02.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1782399451; b=pqZWE+jYgAglbArvU4BEPxa05RJjnCmSR6gX3i1sD+AK7PFmRmgLo7wle/MoX96VF1yhCO 6OHYK/K05lGSJtzonGHwHyVbmYQ0k6kBNMCPuzQL67UagKvHSNup+Nfe1hvOKw262wuy6b 5hhEhQ/caJfsyRmNJjTzbOLgcxON0jU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1782399451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tqUUrJWMlnTxsZAmuCi7Oz0YuD8ibL81XGHYLTsNdR8=; b=iM7OFR7vScKw12WyLNciU02tU6HLwE+oWyrrqTXk33OAJZFL0Vc6ZLnnci9+Dp1GpSAsUw GqDs11bzOfwvdl/4W4zfQ6sgBFvI9vR/hAukQkghzgyFNoUPC8M+xdeY0J562Nl68EVCXt SGGXLbgZaxbvqCdx6xnPAMtUmOcJyvw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=DL1K+Jv9; spf=pass (imf02.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 4F0204060D; Thu, 25 Jun 2026 14:57:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D2BF1F00A3A; Thu, 25 Jun 2026 14:57:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782399450; bh=tqUUrJWMlnTxsZAmuCi7Oz0YuD8ibL81XGHYLTsNdR8=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=DL1K+Jv96MT0STD98/+fBEA4SYv29IHhKaFiC+RmpwELEsqKNGQsv/zck1jcHqfcM oJ97ezN5ImmlSNchaHCpXwWHJ6nx17ovfOWdak1r1eVacHbGY6Keg8yhKxOxWkOmo8 tRan2Dat0DRFm3421OF/ccb7ARrVS4UHX9JS9vKCvpOwLpbbnsPdAtaXp3aEzdgsm0 mQx0LitzsrW/V6CAMqNf8oZzCP4BNDZVWA4m6N/rR7UkMUCxm1aCc2p30p1KVCecR0 jNa23zu3G5AD+mZb2srrlLMfTJAqz3xx9JuNIJ/IVTU2w//K1JmVKXcQA+ZCz0Eyuy PzUJXnJ/D2q2Q== Message-ID: Date: Thu, 25 Jun 2026 16:57:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 5/9] mm/memory_hotplug: offline_and_remove_memory_ranges() To: Gregory Price Cc: linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, driver-core@lists.linux.dev, linux-kselftest@vger.kernel.org, kernel-team@meta.com, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, djbw@kernel.org, vishal.l.verma@intel.com, dave.jiang@intel.com, akpm@linux-foundation.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, shuah@kernel.org, alison.schofield@intel.com, Smita.KoralahalliChannabasappa@amd.com, ira.weiny@intel.com, apopple@nvidia.com References: <20260624145744.3532049-1-gourry@gourry.net> <20260624145744.3532049-6-gourry@gourry.net> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: myrijo3r93mfbe6ui4w8zbcbhro3tafq X-Rspamd-Queue-Id: 5288580007 X-Rspamd-Server: rspam06 X-HE-Tag: 1782399451-160870 X-HE-Meta: U2FsdGVkX1+6yh9Tu7LiefRiS7eMEqntyoTwWtviQ+tDDNZD7ohl+QCOXVmjyIKEwUEoNABx83qc/q1XQLY/3lxJnJ59eV64nMEqDMgoEKU3zKpD1l4dpUWHWLiiOwdFBjkhV5KuwphXR2ts1qX1BQP5NpNniq2F4BgkOGr9M5sCgcmDVoSvw7D670JFdtfggKcpLj8pvx9OpC7dmN4SBp5Gpi7f9sv6qjzNm4seqhaDLW0HxtMb/xevZFiSI8evN32tVdbcrvItULKdiHL13h5xpO1PXAFPwETfJhRU42gfkkFd/sCtkby7KRbfMoiQcG9EFKfXJkO9dJM0Bl+X/TMwhbOA83kxpk+Mfp98RYSmE2/FTBJBiA0TExpcigq2/IQ/li8AhJMaO9+QggV2/fqS96Fvd7JWdkBqT1Cb+9ogqaphQAOgwSqNHX/goRS2eq74NUt+FmLdzcbpq8ozcLQ0ZcVerTWvyL9NRR3DdMrPIXWir8YB5fn/FsdNqXUEqUqMtDQgIfLmt9bPJ+2sYv9jjzjLY3kqY6b64I/P8/KVhAlJd+8DGdaFw2Y135ssv7OHlTjbJmm6UP9rxGWEhHLCCWxs4jocdnSCKKIeKnHgXt2B1euuWvUyjlabcO8D49gTqK2S/IEjLmaACPWxlDB/t7v7ydevu4pLH1v9tdq6IGbviqy84i0bWEnkex2TOYVJsvy36+W2mhB1JazRIAWK1PoC+v9vY0glGXqWQJ1IcOJcv9kNPpjrxQdMcpH8CA5ZkXz2QXNbt8aefUnF26NSmblRFhUErzbIwwd0Umh0cHxdPytS5u9pUVqCGD39jFfZg1lbTYJVmoYYvUw+fbB5TFWQO/5K4jUMzDFvISBWB8DMm+6ra34+8mtX3llYLWgqKjWxFKyR1GouaLSFbxjZzZW5zpQn7UIaaqmZ+2RuONsL88JPM4DZcV+/uGpMm3lcijeoqBk7qP5BmZg 5b90QjJU IkuLZdQlXee5rIGos8BttmjkGDpPhMBx3EHhzgdLCbaV8rEYEA/iRuXOEq3m9D7AORgYY0kZJ8aGTFnow4gQW77fB4wehdxNZ50oVOUajk0PGTbCrkkVEBdxkXN/atEGuVt5jciHLfDZnn/OdHQwDNcwG1R5I4rEK0xWgEj7aKvpYaeusO0MZ4y49zWYpKwoblk93o3qF65KVrS1WzBOlTxVB14o8uDCxN4+KSLGgokcycTsCCHgU3b62PK6vncBL/wwE3791P9TAybQCX+HIemx31a1DIDhDYUNibKtiTICnssI7N6DW+g+k+g== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/25/26 15:51, Gregory Price wrote: > On Thu, Jun 25, 2026 at 09:22:01AM +0200, David Hildenbrand (Arm) wrote: >> On 6/24/26 16:57, Gregory Price wrote: >>> extern int offline_and_remove_memory(u64 start, u64 size); >>> +int offline_and_remove_memory_ranges(const struct range *ranges, int nr_ranges); >>> >>> #else >>> static inline void try_offline_node(int nid) {} >>> @@ -283,6 +284,12 @@ static inline int remove_memory(u64 start, u64 size) >>> } >>> >>> static inline void __remove_memory(u64 start, u64 size) {} >>> + >>> +static inline int offline_and_remove_memory_ranges(const struct range *ranges, >>> + int nr_ranges) >> >> Best to use "unsigned int" right from the start and use two tabs to indent. >> > > ack, ack. need to reprogram my brain to two-indent style, i keep doing > this reflexively. > >>> +int offline_and_remove_memory_ranges(const struct range *ranges, int nr_ranges) >>> +{ >>> + unsigned long mb_total = 0; >>> uint8_t *online_types, *tmp; >>> - int rc; >>> + int i, rc = 0; >>> >>> - if (!IS_ALIGNED(start, memory_block_size_bytes()) || >>> - !IS_ALIGNED(size, memory_block_size_bytes()) || !size) >>> + if (!ranges || nr_ranges <= 0) >> >> With "unsigned int" this will be !nr_ranges. >> >> Wondering whether we would WARN_ON_ONCE() here. >> > > Seems reasonable. Do we normally WARN when callers send dumb arguments? > Seems like sending -EINVAL is sufficient? We do it when we really expect no sane user to do that and doing it would indicate an actual problem. Like passing a nid to add_memory_resource() that doesn't even exist. But yeah, no strong opinion here, we can just keep it as is. -- Cheers, David