From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB966C54798 for ; Fri, 23 Feb 2024 23:46:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2805D6B0072; Fri, 23 Feb 2024 18:46:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2309C6B0074; Fri, 23 Feb 2024 18:46:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AB7B6B0075; Fri, 23 Feb 2024 18:46:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EBD2A6B0072 for ; Fri, 23 Feb 2024 18:46:38 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7B3D8A156D for ; Fri, 23 Feb 2024 23:46:38 +0000 (UTC) X-FDA: 81824705676.21.857E269 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf23.hostedemail.com (Postfix) with ESMTP id 6D5A7140004 for ; Fri, 23 Feb 2024 23:46:36 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=dWKgNgxw; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf23.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.218.45 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708731996; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NIAGIlOyfdPQGzUhuhBTCj1fg0Ra/brIZfOUyFxv3go=; b=AJ12b49MG/MKJFB7X10KgnwQyDeVloqr33gR1n1MK7aBsaAQPSbzZLKh+SXmoLG6Ej+T2s ANerJmbQz2z07crAUjsXdxXcu5S2VvRtUmVgsE1S2tDwWqHKvUlIVFKdjd9EbKPl8AD5GE VkR8IUxkLy4Kc4GJKSzrsJPh2ksB/Iw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=dWKgNgxw; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf23.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.218.45 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708731996; a=rsa-sha256; cv=none; b=xWA5jApbjJ2nKaZCG4yYHrWTgTWvH4C0ZsySTuovgDwg0UGoOztQlbw3yaXcczC1Q8i+/Q qRPUXxLT1PgHqNmTe1ndpEyPxEnoVRUjxK6ChE60P2aBRqQfiKyyOu67hD/15qbpQzAAPn pM6XpTkBlp9mkfNm9r8fFyZJHfUN7xA= Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a3f3d0d2787so111257966b.3 for ; Fri, 23 Feb 2024 15:46:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708731995; x=1709336795; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=NIAGIlOyfdPQGzUhuhBTCj1fg0Ra/brIZfOUyFxv3go=; b=dWKgNgxw9Hn+c99wbHmUIyR20cXqAcLHRRhvw/Ir1b1jTfkruCa2NEwRlRmUoAAcvM Pysa1mmp8SEA5G65FYKdJglfGcN1YBwuxBFq+yv5apCI2u59LIRdRCtPvEOwT1dXMEPC a9oyEA7b3IT5ZTN+mNlhsKdbFo+j+EighUjeNtpyR3StoWum8PWS872NWKfRiqyjSFyv 5exyCPwoWxmxyILliqt2XKQAnapPqEXtkrF31O8xIH1FcJekS3Rgd+9C2GZjon3skgbb 2r3Lx1wU2OwKGYLmTuAnOB+I8yb5DIqn1IynvkTbb7nTWlwtdmZrdN3fgvEmB43Vmj1V LpeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708731995; x=1709336795; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NIAGIlOyfdPQGzUhuhBTCj1fg0Ra/brIZfOUyFxv3go=; b=UgVZsMNgeX7mKh7RX0gCojvaTczxuy0vd5GcZHYYD3gjLjUlNPlm/j9L2g0NMUekjv XkiJ/Xv2TP8BD0LxZCuMURtfKKLC4kzNFMQSCBxQYEsLCAKmWUnazdDQt1VbvBCdQ8qH wyTSoAFzwGlVMv+Muew6wMyZw4/aGmO8BgdxaJObhszHNOFQc9MWirOoE0BDWjeA28fW 6C6WzUgVKv99iVtHthLTnaQzF09tUtpj394DOehndD5djrlr9J+hbnaUeZFuPG70S+my LTW6qoHf11sPj4Yu/lHF3jjqJ2hXQhel2xZjMUZoz2BYzECSMhYPAVo1pi/agDudtQJG FpBw== X-Forwarded-Encrypted: i=1; AJvYcCXwIQsEvUp/e0hNBf+QlowmWJONVya2UAzj8JrO79NaRb+8VAokigLI5WKKqxGtiV2vJ/tNmhCUNcUBTAAVLd9MxAU= X-Gm-Message-State: AOJu0YxGTWCwlPCBx/tU2OKyaS29NdRcbDy+kc00HmRP3EbYZMmUtdrV efCLWWKS6s0OtwW3O623aBuPfObY5pG7pATuJ/PS28+TNrM/MDQGQptaqkKv/nE= X-Google-Smtp-Source: AGHT+IE0+tL8hH0wqn2x+/epyE+ZkG3YGes2J0uLaDyxWp2Ro/Yw07l0+8CizphqXDIS10sDl1t62Q== X-Received: by 2002:a17:906:d923:b0:a41:30be:4a82 with SMTP id rn3-20020a170906d92300b00a4130be4a82mr677228ejb.61.1708731994017; Fri, 23 Feb 2024 15:46:34 -0800 (PST) Received: from [192.168.179.2] (078088045141.garwolin.vectranet.pl. [78.88.45.141]) by smtp.gmail.com with ESMTPSA id u22-20020a1709060b1600b00a3fbe13e2absm52810ejg.211.2024.02.23.15.46.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Feb 2024 15:46:33 -0800 (PST) Message-ID: Date: Sat, 24 Feb 2024 00:46:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v17 05/35] virt: gunyah: Add hypervisor driver To: Alex Elder , Srinivas Kandagatla , Murali Nalajal , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Philip Derrin , Prakruthi Deepak Heragu , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Bjorn Andersson , Dmitry Baryshkov , Fuad Tabba , Sean Christopherson , Andrew Morton , linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org References: <20240222-gunyah-v17-0-1e9da6763d38@quicinc.com> <20240222-gunyah-v17-5-1e9da6763d38@quicinc.com> <20240223144844667-0800.eberman@hu-eberman-lv.qualcomm.com> Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20240223144844667-0800.eberman@hu-eberman-lv.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6D5A7140004 X-Stat-Signature: t79hoy4sckr53xb9g318gzn8u71zxrbf X-HE-Tag: 1708731996-445609 X-HE-Meta: U2FsdGVkX1+T0sSYtmlJ9LLG35scznQyaAgxT/nSFuaW8o+nx+fAAWonsSfAjqclUd9/div5UA0I/xEG26jyn41SM82XHYUzKZnPcvde8Q51KGljRTAaI2q+msvJSHT37A2tTGpw9X6v+e/S7mR/EQozoQfwYWEgJaQViooJlUlsrhmouRMQUV1GGRG7WQy/OtICVD0RCkG8v19qkhuQrPKXYaRbTOM3WoffsVk0v3ZduNcor14bROZBqP0yV/3GYhnaVTUiU9sMkyRKxV8kneIxaz7iHplxgbuCMJrr1PB4IlvsutUByGGPCJfGOCZ3n2opQnWFk/LdshSTtamyteAg2M0yQ3hs8HlzA/fbFECypmhpqEFCm/CwEUU5YAinA08GzD+eaO1D5G/WeAoH/0z3GcYZ6YpCXwrI8/Cag23pzsqHTIVLLwahdWj4q+7Qu3QMFZQEYqLByoBdZXMpKbTdLb71ONC+1lf9h6160I/d8FFo/kWUaq583YvTKn/XGdCD0iDb66P8OIfOIfxIkcXLzn4zBOk1a+e9xXpkoCyIet+qbp7k1uGtgVPGVdI/PRpWDT59n8hyZ+2ODW339EMKceo022MiVMBAFnDHPljUeJ22mJpHKEyFLPHMvTzf0x/Oo3y3j7r7tYKc/tXJAe35uX4Nr7T9kjWsfWWbnqiVUFvo4Dn/sHkCn1vYfkhB1CxSDHd957qbos4KlspFzo7mWoyuHbpDfPTaTYG1Zr1iFqSsNAlmv6u4By677WyXIl/G3MbRmHnMdLIAQaVLefVBSccn6PPLuM1WtfUgUNhn4hwI8bKwGeUtGpvRcTvXN8ZzuIlJjkZFO02WUscaeF6Bz7ut2R0uemF2rEwZaSX4Km4zT6cbIx+K4Hc3jXtj6IUl3dcbB05AnJypsdIYChJZQnc4aW0he0kFQmErMbMR8YGaV2lr6eY1Xo/HVx7rBV8OP1Gva4LLNMfdIzY uwtiuFqo KLybvG1blYSYAohmGqxpaou54fw1bUYjvdsZpEAKAXdwW/7LsEaiJAyDDsiRIdM1IVrXHJv9BkZGhzH3Mn8+JsE5Mc8u+Qj1uYiHFTe3YAbJSQRYnNuLiyL/hMZNRpLo58TaMPdboZE+i+h5T6D2ZkvFAxgJjCx+LfocnVGIcHPRcAHKN92R9VVHXtQBbsaZrj1r3xnl0w1CpYwva0EJ1nQkqusiWW7LnT3hwTRX+pyUsaXGBH+ZqGh8zmPBhZ3ssdkobxlNF9alK/uLQaXVPShJOhUAAbCg/cawPTSQv5lsaK+bvj6kGIuBTmFGQUv2SmkBfupeO4hmutKvC/7V8rpu63UXEQdkQOghN/2agnppoGYSEL5Q0vn5inxmiU+PXaERNh+0+129cDMoJ81Czvh3+35P7nC3u1AVuGV1YrOpYqcBE/W6at8mwg+Aqwse7KLWidpAOxxQFmycDaPvms+QhfpGTIBJbKwzUM9SdXW0kE14IgUEYHbzM3A5bfwLdzFd0bxKCtsHdgrE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.02.2024 23:58, Elliot Berman wrote: > On Fri, Feb 23, 2024 at 10:10:47PM +0100, Konrad Dybcio wrote: >> On 23.02.2024 00:16, Elliot Berman wrote: >>> Add driver to detect when running under Gunyah. It performs basic >>> identification hypercall and populates the platform bus for resource >>> manager to probe. >>> >>> Signed-off-by: Elliot Berman >>> --- >> >> [...] >> >>> + >>> + /* Might move this out to individual drivers if there's ever an API version bump */ >>> + if (gunyah_api_version(&gunyah_api) != GUNYAH_API_V1) { >>> + pr_info("Unsupported Gunyah version: %u\n", >>> + gunyah_api_version(&gunyah_api)); >> >> Weird for this not to be an error, but it's probably not worth resending >> over if it's the only thing > > It is an error, but maybe I misunderstood: Sorry, I meant "pr_info might have been pr_err" Konrad > >>> + /* Might move this out to individual drivers if there's ever an API version bump */ >>> + if (gunyah_api_version(&gunyah_api) != GUNYAH_API_V1) { >>> + pr_info("Unsupported Gunyah version: %u\n", >>> + gunyah_api_version(&gunyah_api)); >>> + return -ENODEV; >>> + } >