From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAEA7C04A6A for ; Thu, 3 Aug 2023 14:12:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56FFD28025F; Thu, 3 Aug 2023 10:12:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5200D28022C; Thu, 3 Aug 2023 10:12:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C07928025F; Thu, 3 Aug 2023 10:12:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2AB5E28022C for ; Thu, 3 Aug 2023 10:12:00 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DFDBC161286 for ; Thu, 3 Aug 2023 14:11:59 +0000 (UTC) X-FDA: 81082982358.27.7E315C5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id AFE9B1C00DD for ; Thu, 3 Aug 2023 14:10:24 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DDYYlvlj; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691071824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LPNYecHu16O9Ut2w98fGEf3Yo08xy4t1WgY+3ixBHos=; b=sUEBWJpHeZGX2RKVtH0CI8ml4uAbrOu09cJN+gk7MYe/37Xj8y/H05bax/nRwsfgyLiuM5 M1Fl+3tpfm78Nk0wd2iR56FlQgG7Veu36ksUUBk0SASI/H8YZtW3g+/DXw9rDZN0pBERrj 3AP9X2QLAcIh4i5mQookFjAldKs7G3w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691071824; a=rsa-sha256; cv=none; b=qx9Zq3VOjsbXMkQ+5uJDPEBNQh2uR7FS3E5d3Lqi/opXQlfzjViLL7bAmS8TdE4oF9ddcO 5fmFoP0/p9SGXXePT3h9vrlO6OTR6RCORZVXqbEEbWbRrdQI2WgeYJj8oM2Zyqt86zYmNF 3MwiFUGS8VM4xThoZO1OTPe20SiQMJA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DDYYlvlj; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691071824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LPNYecHu16O9Ut2w98fGEf3Yo08xy4t1WgY+3ixBHos=; b=DDYYlvljVxptue3XjI8vwfi1JmSqIRVIPlodrt9zk7mlo12b4Ya0O49D+URMvlKmWwjMkt R8+s7j0XHqNAWQ8rL7tAQoKDRm/ITeil0OK8qrzAzvwgY/5QU6DEZnd+xX2I4Nw5YACA+c cb7iPBFtgXH+mgl1G4Y8+IhMELIzjBA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-gy0zHpoqMhCswqRRn6-M5g-1; Thu, 03 Aug 2023 10:10:20 -0400 X-MC-Unique: gy0zHpoqMhCswqRRn6-M5g-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3178e3f46b1so519411f8f.2 for ; Thu, 03 Aug 2023 07:10:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691071819; x=1691676619; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LPNYecHu16O9Ut2w98fGEf3Yo08xy4t1WgY+3ixBHos=; b=DknhPys+/4AlTPYEZjqLkPbwwnoprCsjrvLQGAbCfYiB5rXU7mnXBk+DwRON+RTLGB CJEKgqBxgrD7VF4qK/kyUZNyf6AWgutlRr2dXEOAp3+OKEY5K2FAPmnQZlpAchvSaORi fLrhWyU4BL9dsOvTHBIQReALexU88JclntA+uOPwX+qih4lfKBK7NATQCMDnW52DprYd FDckqqxvkE0paFmO4bukdlF3bezZZRptoF3jMZ92wQmCQGwpDtm3JQ42hdKjg6Jn5pgU lXt1bK9/COxEUk7qgqNctWrdEdQLetQLB45dvoPNRg9Kwp34FX1NUsOlvSmTKPWDkags UEkA== X-Gm-Message-State: ABy/qLZoxmMvcwJLKMXE0S5P/Lyzq7N/kM2Py6YXU9cuMRG+nLMd5KUN vdWEPuIPzRgHH0CLJNHZpTQBVJAWRyUK+7G7A4mq/maQB8TY5A9xYh6uI/9GRURjEq+s5qxQyTy m9xzm5YJcohs= X-Received: by 2002:adf:e505:0:b0:315:9ee6:132f with SMTP id j5-20020adfe505000000b003159ee6132fmr7302705wrm.68.1691071819423; Thu, 03 Aug 2023 07:10:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlFJfgJw/tqsvdJvQR/uuuE5dJvRmtkylfqqPX2lYImbVVHLI92KUgmsAn5xWjx+MJ1hZlfajA== X-Received: by 2002:adf:e505:0:b0:315:9ee6:132f with SMTP id j5-20020adfe505000000b003159ee6132fmr7302673wrm.68.1691071818968; Thu, 03 Aug 2023 07:10:18 -0700 (PDT) Received: from ?IPV6:2003:cb:c718:9a00:a5f5:5315:b9fa:64df? (p200300cbc7189a00a5f55315b9fa64df.dip0.t-ipconnect.de. [2003:cb:c718:9a00:a5f5:5315:b9fa:64df]) by smtp.gmail.com with ESMTPSA id o20-20020a5d58d4000000b0031762e89f94sm21894524wrf.117.2023.08.03.07.10.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Aug 2023 07:10:18 -0700 (PDT) Message-ID: Date: Thu, 3 Aug 2023 16:10:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Yang Shi , "Huang, Ying" , Zi Yan , Nathan Chancellor , Alexander Gordeev , Gerald Schaefer Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20230727141837.3386072-1-ryan.roberts@arm.com> <20230727141837.3386072-4-ryan.roberts@arm.com> <6cda91b3-bb7a-4c4c-a618-2572b9c8bbf9@redhat.com> <4255e71a-63c9-b2f9-5e97-e46834f7837c@arm.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v4 3/3] mm: Batch-zap large anonymous folio PTE mappings In-Reply-To: <4255e71a-63c9-b2f9-5e97-e46834f7837c@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: AFE9B1C00DD X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 7aomt4eqyodb7brpe5q1q9qjyidwkby5 X-HE-Tag: 1691071824-269475 X-HE-Meta: U2FsdGVkX1+305QJ41B0cDpo4Dp3wVf1fQx9ZOlQa5okJyPVyKUb53NSybrtapOJN6RKG+bScwzygipuK2ZT/b/R06Kks5nEKglCcH5e9REzC/Uv9m436Mh5kF6oJXraixzwCsHVGyYLg6SbDmLgP1VIPUc2fWUrwCeIuaPdKnn0xH4qSvdjCwU/9GauaqxvIFPqP26qOsbByE7mKcHQg55mOe7aZs1fg4hvuIBF/UYRtkkZwIVP8Fd5ydlDIjDAopu+Ckr1lDeXndl0D7Mf5L20LiZu49VHJsVxV67AyQyP3Kty8WdmDuFaLNEfxagt6KbeZppj83mhOEjBTC9qIF0t8YlOnhlV7uXg3LBq1EbRRCp8qIFwZqkdSDSXj0KQEfcv1agoCSNuY7H+1pBxeqC3qGdbRrio131q5aBla9Hq5+XBNj/FJxY1EClnkhkELwIHH6fL2sIXUshK2ll/KRYmXIFyIaY21hnnDYfN84Fwrf9DSYuDzf9dJttr2tJN+mVJjpp9chWRLfOz2JA5ythGeygrWdj5Z18KNP3nRMDbdfI7JbTf8Y8eyoix5BWpy5Ltsd2Tl0mFp3w4WhpqZg9Qv9+AlhtDFrLbKqGJQh7IOueP7H+oeMzB7jCC8vRYcpCbsgqEd1BZfzDzkp62Er3TWbQvfv5M0vKh/IoAqgO6dQI/eH7ZZFLhhRYhTGTFn1YlNGxRLd3nfEjkFf+w1tCg+R8qsrDM76xpiZR9Kg7E2F6RskjBXt9NOLNT2tltPlZTc3v+acImPVZ2c7yocBwIJKBiPgxhGNQvtBC83xtQmGpv3bK17+eLtO4ZTLtoJqO+EXr3xL5dux56BPZ1Fjuq7zBDY2d4qkSLNWbKk2viyWNjQ5rNSfwJC5Gcqh0zfYVKEyJHVoUby4ZZuYfOSfvZylEYNG5T4jeWeo45pVrKpiXLVRKuMVQ8Mrrt04DwPH7BitCCABJ76x/qWFt wf0vrnfq VfLHYr/rFUt8ymMhXht/b72CUaImHTXQ3jcazYabChbpdyDyTutBepzeS2CyN+1nIbDHpeaOzALNcMX29EERvXePap0vX4q0GWK9Uzju0cUxEZJvDmuPydJ07zjHjrp7My5JLL6+O3V/SRWH5OH7nsI3MFtNc5ynMicQVM1qxZxIS8H6U+OEWY6RpGbw9HJPHw6f983UMECwV/Bo2eL8tCyvZTxOJVgOQ26WyJxaipDS3ja6rvuqVMPPXTp3v/Pxy6o+WAmfIOCFL3kgIgySEao3fvtTG4ZJMT6Dv7puQhin9p7LIhTiU9TESuB6dU6sCNO/FiENpQAV8xKHgeKnPeOjjBAADa0u0vednjOXYFn/Ynzceq3vo0plm6GnkzghW5xq5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> >> With this patch, you'll might suddenly have mapcount > refcount for a folio, or >> am I wrong? > > Yes you would. Does that break things? > It is problematic whenever you want to check for additional page references that are not from mappings (i.e., GUP refs/pins or anything else) One example lives in KSM code (!compound only): page_mapcount(page) + 1 + swapped != page_count(page) Another one in compaction code: if (!mapping && (folio_ref_count(folio) - 1) > folio_mapcount(folio)) And another one in khugepaged (is_refcount_suitable) ... and in THP split can_split_folio() (although that can deal with false positives and false negatives). We want to avoid detecting "no other references" if there *are* other references. Detecting "there are other references" although there are not is usually better. Assume you have mapcount > refcount for some time due to concurrent unmapping, AND some unrelated reference. You would suddenly pass these checks (mapcount == refcount) and might not detect other references. >> >>> + >>> +    for (i = 0; i < nr_pages;) { >>> +        ptent = ptep_get_and_clear_full(mm, addr, pte, tlb->fullmm); >>> +        tlb_remove_tlb_entry(tlb, pte, addr); >>> +        zap_install_uffd_wp_if_needed(vma, addr, pte, details, ptent); >>> +        full = __tlb_remove_page(tlb, page, 0); >>> + >>> +        if (unlikely(page_mapcount(page) < 1)) >>> +            print_bad_pte(vma, addr, ptent, page); >> >> Can we avoid new users of page_mapcount() outside rmap code, please? :) > > Sure. This is just trying to replicate the same diagnstics that's done on the > non-batched path. I'm happy to remove it. Spotted it afterwards in the existing code already, so you're effetively not adding new ones. -- Cheers, David / dhildenb