From: Hao Ge <hao.ge@linux.dev>
To: sashiko-reviews@lists.linux.dev
Cc: kasan-dev@googlegroups.com, linux-mm@kvack.org,
Suren Baghdasaryan <surenb@google.com>,
Uladzislau Rezki <urezki@gmail.com>, Dev Jain <dev.jain@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
Marco Elver <elver@google.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Dennis Zhou <dennis@kernel.org>, Tejun Heo <tj@kernel.org>,
Christoph Lameter <cl@gentwo.org>
Subject: Re: [PATCH v5 07/11] mm/vmalloc: undo what __vmap_pages_range_noflush() mapped on failure
Date: Tue, 17 Nov 2026 15:27:53 +0800 [thread overview]
Message-ID: <b61ece54-4df8-4d4d-a64a-be7f56f380dc@linux.dev> (raw)
In-Reply-To: <sashiko-outbox-218305@kernel.org>
On 2026/11/17 15:15, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] mm/vmalloc: vmap_pages_range_noflush_walk() truncates nr into
> unsigned int
> --
>
> commit f06c1baff5ffda8b5f9a1dce600b9d716bd0c648
> Author: Hao Ge <hao.ge@linux.dev>
>
> mm/vmalloc: undo what __vmap_pages_range_noflush() mapped on failure
>
> This commit tracks the number of pages installed by
> vmap_pages_range_noflush_walk() and tears down those PTEs in
> __vmap_pages_range_noflush() when a mapping fails midway.
>
>> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
>> index 5c1eacc2a0ac3..4f3c320a48499 100644
>> --- a/mm/vmalloc.c
>> +++ b/mm/vmalloc.c
>> @@ -725,7 +725,8 @@ static int vmap_pages_p4d_range(pgd_t *pgd, unsigned long addr,
>> * may have contiguous chunks, as hinted by @shift.
>> */
>> static int vmap_pages_range_noflush_walk(unsigned long addr, unsigned long end,
>> - pgprot_t prot, struct page **pages, unsigned int shift)
>> + pgprot_t prot, struct page **pages, unsigned int shift,
>> + unsigned int *mapped_pages)
>> {
>> unsigned long start = addr;
>> pgd_t *pgd;
>> @@ -748,6 +749,7 @@ static int vmap_pages_range_noflush_walk(unsigned long addr, unsigned long end,
>> if (mask & ARCH_PAGE_TABLE_SYNC_MASK)
>> arch_sync_kernel_mappings(start, end);
>>
>> + *mapped_pages = nr;
>> return err;
>> }
>>
>> @@ -758,18 +760,36 @@ static int vmap_pages_range_noflush_walk(unsigned long addr, unsigned long end,
>> * The caller is responsible for calling flush_cache_vmap() after this
>> * function returns successfully and before the addresses are accessed.
>> *
>> + * On failure the PTEs installed by this call are torn down before
>> + * returning, so a retry sees a clean range; PTEs that were already
>> + * there when the walk failed are left alone. When @gfp_mask cannot
>> + * block, the teardown skips cond_resched(), it may run in atomic
>> + * context.
>> + *
>> * This is an internal function only. Do not use outside mm/.
>> */
>> int __vmap_pages_range_noflush(unsigned long addr, unsigned long end,
>> - pgprot_t prot, struct page **pages, unsigned int page_shift)
>> + pgprot_t prot, struct page **pages, unsigned int page_shift,
>> + gfp_t gfp_mask)
>> {
>> + int err;
>> + unsigned int mapped_pages = 0;
>> +
>> if (WARN_ON_ONCE(page_shift < PAGE_SHIFT))
>> return -EINVAL;
>>
>> if (!IS_ENABLED(CONFIG_HAVE_ARCH_HUGE_VMALLOC))
>> page_shift = PAGE_SHIFT;
>>
>> - return vmap_pages_range_noflush_walk(addr, end, prot, pages, page_shift);
>> + err = vmap_pages_range_noflush_walk(addr, end, prot, pages, page_shift,
>> + &mapped_pages);
>> +
>> + /* Undo the PTEs installed before the failure. */
>> + if (err && mapped_pages)
>> + __vunmap_range_noflush(addr, addr + (mapped_pages * PAGE_SIZE),
>> + gfpflags_allow_blocking(gfp_mask));
>> +
>> + return err;
>> }
>
> [Severity: Low]
> Should mapped_pages (and nr_mapped in vmap_pages_range_batched()) be
> unsigned long instead of unsigned int?
>
> vmap_pages_range_noflush_walk() tracks nr as an unsigned long across the
> page-table walk, so storing it into an unsigned int truncates the count to
> 32 bits and would leave the unmap range incomplete if a walk ever failed
> past UINT_MAX pages.
>
Sure, keeping them consistent does make sense.
I will hold this change and wait for more review comments on the rest of the patches.
next prev parent reply other threads:[~2026-11-17 7:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 7:13 [PATCH v5 00/11] mm/vmalloc: fix up vmap error handling Hao Ge
2026-11-16 7:13 ` [PATCH v5 01/11] mm/vmalloc: skip cond_resched() in the vmap unmap paths when atomic Hao Ge
2026-11-16 7:13 ` [PATCH v5 02/11] mm/kmsan: undo the shadow mapping when the origin mapping fails Hao Ge
2026-11-16 7:13 ` [PATCH v5 03/11] mm/vmalloc: reject an unaligned range in vmap_page_range() Hao Ge
2026-11-17 5:53 ` Dev Jain
2026-11-16 7:13 ` [PATCH v5 04/11] mm/vmalloc: reject an unaligned range in __vunmap_range_noflush() Hao Ge
2026-11-17 6:05 ` Dev Jain
2026-11-16 7:13 ` [PATCH v5 05/11] mm/vmalloc: only flush the cache after the vmap succeeded Hao Ge
2026-11-16 7:13 ` [PATCH v5 06/11] mm/vmalloc: undo what vmap_page_range() mapped on failure Hao Ge
2026-11-16 7:13 ` [PATCH v5 07/11] mm/vmalloc: undo what __vmap_pages_range_noflush() " Hao Ge
2026-11-17 7:15 ` sashiko-bot
2026-11-17 7:27 ` Hao Ge [this message]
2026-11-16 7:13 ` [PATCH v5 08/11] mm/vmalloc: drop the KMSAN metadata in vmap_pages_range_noflush() " Hao Ge
2026-11-16 7:13 ` [PATCH v5 09/11] mm/vmalloc: undo what vmap_pages_range_batched() mapped " Hao Ge
2026-11-16 7:13 ` [PATCH v5 10/11] powerpc: drop redundant unmaps of failed vmap mappings Hao Ge
2026-11-16 7:13 ` [PATCH v5 11/11] mm/percpu: stop unmapping the CPU that failed to map Hao Ge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b61ece54-4df8-4d4d-a64a-be7f56f380dc@linux.dev \
--to=hao.ge@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=chleroy@kernel.org \
--cc=cl@gentwo.org \
--cc=dennis@kernel.org \
--cc=dev.jain@arm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-mm@kvack.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=ritesh.list@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sshegde@linux.ibm.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox