From: Jesper Dangaard Brouer <hawk@kernel.org>
To: Waiman Long <longman@redhat.com>,
tj@kernel.org, cgroups@vger.kernel.org, yosryahmed@google.com,
shakeel.butt@linux.dev
Cc: hannes@cmpxchg.org, lizefan.x@bytedance.com,
kernel-team@cloudflare.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 1/2] cgroup/rstat: Helper functions for locking expose trylock
Date: Fri, 28 Jun 2024 14:13:34 +0200 [thread overview]
Message-ID: <b637705e-6a7c-4329-9109-50e9f568e64c@kernel.org> (raw)
In-Reply-To: <08062501-f3fb-4e4d-b72c-f1b0f964640f@redhat.com>
On 28/06/2024 00.22, Waiman Long wrote:
>
> On 6/27/24 17:18, Jesper Dangaard Brouer wrote:
[...]
>>
> Will it be cleaner to add a "bool *flushed" output parameter to
> __cgroup_rstat_lock() so that the caller can respond differently whether
> the flushed flag is set or not? In that way, you don't need to expose a
> separate trylock() API. Also your commit log is empty.
>
Dropping this API in V5 anyway.
But I do think it is more natural to follow the 'trylock' API as this is
something that people have seen before.
--Jesper
prev parent reply other threads:[~2024-06-28 12:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 21:18 [PATCH V4 1/2] cgroup/rstat: Helper functions for locking expose trylock Jesper Dangaard Brouer
2024-06-27 21:18 ` [PATCH V4 2/2] cgroup/rstat: Avoid thundering herd problem by kswapd across NUMA nodes Jesper Dangaard Brouer
2024-06-27 23:34 ` Shakeel Butt
2024-06-28 9:39 ` Jesper Dangaard Brouer
2024-06-28 22:15 ` Yosry Ahmed
2024-07-02 10:35 ` Jesper Dangaard Brouer
2024-07-02 12:00 ` Yosry Ahmed
2024-07-08 15:26 ` Jesper Dangaard Brouer
2024-07-16 21:54 ` Yosry Ahmed
2024-07-17 7:46 ` Jesper Dangaard Brouer
2024-07-17 16:04 ` Yosry Ahmed
2024-06-27 22:22 ` [PATCH V4 1/2] cgroup/rstat: Helper functions for locking expose trylock Waiman Long
2024-06-28 1:06 ` Waiman Long
2024-06-28 12:13 ` Jesper Dangaard Brouer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b637705e-6a7c-4329-9109-50e9f568e64c@kernel.org \
--to=hawk@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).