From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44538C2BD09 for ; Fri, 28 Jun 2024 12:13:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DACD6B0088; Fri, 28 Jun 2024 08:13:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48B1A6B0089; Fri, 28 Jun 2024 08:13:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 352516B008A; Fri, 28 Jun 2024 08:13:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1BDCE6B0088 for ; Fri, 28 Jun 2024 08:13:42 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9EE9A14022E for ; Fri, 28 Jun 2024 12:13:41 +0000 (UTC) X-FDA: 82280188242.20.9ECD11C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id D2F95140011 for ; Fri, 28 Jun 2024 12:13:39 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qVHi2VzL; spf=pass (imf23.hostedemail.com: domain of hawk@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=hawk@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719576806; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aKBmv1fNve1yE2rHw/o7zIS+dLFNzlbuw8nse1UPZDg=; b=QYluEP77IMR4sV3bWRiXD6yOzGzsHa9QtRBcj26lt9sTRw6WdJJFaitsJ6z87DeYMImLI1 UZGSy6onuP3s+rYzUO3Ca2zNlznfMbVoTQxCaPrjh4xrKgdK658skOm9nkC7e9EmCcn76e tIM8+/7+4/tHAyBKNGF3uLyJCP4dvK4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qVHi2VzL; spf=pass (imf23.hostedemail.com: domain of hawk@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=hawk@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719576806; a=rsa-sha256; cv=none; b=UqndBpM26zTnhhSJ4HPFsoD0DI9ju2bhJkq/Qs84cublMgOjikpGznphF7hDpqLffAUJKp QUkYFNEFmK1zLrFSnV5+1duEkbBpFdlGoUblsvbSyjQtCk86bYGAZKxml0XzIra2OJioR1 mv1829OTh+tC+Dl8dtZfO+dm8LS4KZk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A7C5961F3B; Fri, 28 Jun 2024 12:13:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73200C2BBFC; Fri, 28 Jun 2024 12:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719576818; bh=ewO2QXATiqIezNRUtR6i4nD/oZNLXvq3+JsgCScLqrw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qVHi2VzLA6QfYwM501xLUSpEOxpj/5LebBxcKl1K5XI6jrJPXefkLik8OIUYt1mrr wIgEkJsZsScISMwn0QGJVEqrU0cXxbREPhCPos3jfks8sjKXSymeICTvZEsD82sMKQ QvKOqeu1Kw0Kkyv5Cyk8Wdt20w/xN+xEGDZX0WuPWRfv4UX2rWl+Ex3GhSkdpkR4gz lxd9hOurLxuQ9JiAzRvIrpwBzCZSx8fRL0miWjVZDgGmIQHpgSvhJW1NitFJeb3/Mz vnZU/mUFwXVJN93mvSQggkbBQWDMjDg2jfgJxNSngUJS6BkQ673f2GOhdiaThcHRC2 fT+PCPnu9qqmA== Message-ID: Date: Fri, 28 Jun 2024 14:13:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V4 1/2] cgroup/rstat: Helper functions for locking expose trylock To: Waiman Long , tj@kernel.org, cgroups@vger.kernel.org, yosryahmed@google.com, shakeel.butt@linux.dev Cc: hannes@cmpxchg.org, lizefan.x@bytedance.com, kernel-team@cloudflare.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <171952310959.1810550.17003659816794335660.stgit@firesoul> <08062501-f3fb-4e4d-b72c-f1b0f964640f@redhat.com> Content-Language: en-US From: Jesper Dangaard Brouer In-Reply-To: <08062501-f3fb-4e4d-b72c-f1b0f964640f@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: cmz6dsc6nphnhja8ss91srcqooegdkmb X-Rspam-User: X-Rspamd-Queue-Id: D2F95140011 X-Rspamd-Server: rspam02 X-HE-Tag: 1719576819-715482 X-HE-Meta: U2FsdGVkX1/0F4Wpn7FmXw4SAY2OGV7ZieXAvm+MT1p9/9atfb/8JuTFiv3q6+ZzgzambRIPGecTbk/BfFoCBhTbq1FQlWdoSfsKatTRKsN0UNCF1MfU0/PD3k9NWUZIFEThSgg0QQvCUYtzkgiVhBGxdu8UzzHymZCJVgOT3oCfZ8cOANSMbnDHpkm7MbixCimGsR5XJFDaVcRz6BJJcs1bLy5PT71uXaHvDjLTqR49Acyu8DJfpwLulI7O1a4n8g4tmNQK/k7aJg+wPr4O3Hhu6UfydK8bccEjXn4IsjwGaRzHMn0kzNc1H/kFEeMfJj7+fFzOb4bWbg4rPAMKv5KtWeoYkIPDgn3/r7Bw65FEVqSjx+8lWw55s64bzrz600Fu3kLA93q5ZXm/9HGNx1k7/llkXoO96/C8SGTxiGCUlasL8OYG/nkGv7l280LRJBhFxBN8Yot0mt0iKNruyEuXHFV8tK7wpsbmFjDKjtnTkcvj4vRGLNYTDGGrQ0FWHbR8JVB1a40k+1NgP9d89AvgGQShf+ykHeW6qs003nalgvkjJwevkHj63c4OJ8T1ndgSrbVBEFSoNA0FphbUTVG6sOdYacccGqGGZDvsHjHgRqAOFCWE2lTRm6ZVnyL3WQZQ5fhKi1bXSHiiEnuJzkYPfC3l26EG/lsjXMUmOsK1gHP6YOtYWoLTKigxmsXJpjlXwYahYlXTN03xK0Wv+z1a6TH8ZGjkAyV+DpZRtQ30zg2QJHMOS762/BydkpK5HXLJYVQVmKY+0da6tJud3jfQlh+wf3jlyxRuDK6FoB1/XoMcFdwRgIBFjkCArDghABGx+BPV7qHSzk17S/emBfQ8luGyTQNebV2szizkMXXxFnqaKMDxJ/tsFlghu/3jtEbNfISAXcS3DCN47FNgDpxZQWkmj4qvOvMaLsVtbGXGR4enaCq+oVuaVVxLQxjIuN68nD78BvhFWHmd21B wJkhPZ2S XRibvAy8fw+2Qb1OnZFJQQckYjf0mCuuQ9diS13QCSDWHhfYcoDxMXJGdxS6i4MzOsT2P2jT+QCqDj1R92jiRuasU93SnCjZAl0wAx5+eZNG9Bcv1KWjjBMqdQ0LP1hGx0QV0BFrrXtJeMzms04dP7eSyexIInHKAlSFdssVk8kmj4A2DUN8B2vOc9rm4AJ45PdMcuU0KUenlQPs13FtzWIsWlHDXRYcWIm8M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28/06/2024 00.22, Waiman Long wrote: > > On 6/27/24 17:18, Jesper Dangaard Brouer wrote: [...] >> > Will it be cleaner to add a "bool *flushed" output parameter to > __cgroup_rstat_lock() so that the caller can respond differently whether > the flushed flag is set or not? In that way, you don't need to expose a > separate trylock() API. Also your commit log is empty. > Dropping this API in V5 anyway. But I do think it is more natural to follow the 'trylock' API as this is something that people have seen before. --Jesper