From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC704C432C0 for ; Tue, 26 Nov 2019 11:57:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 873612073F for ; Tue, 26 Nov 2019 11:57:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b="hAXBOH/w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 873612073F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xenosoft.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E4E946B02E1; Tue, 26 Nov 2019 06:57:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DFF556B02E2; Tue, 26 Nov 2019 06:57:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEE1F6B02E3; Tue, 26 Nov 2019 06:57:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0122.hostedemail.com [216.40.44.122]) by kanga.kvack.org (Postfix) with ESMTP id B912E6B02E1 for ; Tue, 26 Nov 2019 06:57:20 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 4587E2478 for ; Tue, 26 Nov 2019 11:57:20 +0000 (UTC) X-FDA: 76198278240.24.stew58_3fe4427b8d634 X-HE-Tag: stew58_3fe4427b8d634 X-Filterd-Recvd-Size: 6725 Received: from mo4-p02-ob.smtp.rzone.de (mo4-p02-ob.smtp.rzone.de [81.169.146.168]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Nov 2019 11:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1574769437; s=strato-dkim-0002; d=xenosoft.de; h=In-Reply-To:Date:Message-ID:From:References:Cc:To:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=OiXIPkAa+jo3JWZau1B2Ey3v2wblVpCTuGCnmx5s9Rg=; b=hAXBOH/wmIty8n3AQThGec+ITEywgGoSjIlbVMQVHzc8T4N97bDbjl5TXFUMLNpoHw RMN7fhfuKmvdwIyrgZnJmVUePUxAdnOCu0GAQag2AkipLlRn9vT9l0mIDOf6xM5APruN 4UAXwDqFauzIzVgbw6HbHdWIbYYA7UigzXAYZgVRbgQAfR4KlnRRySr1Uquw47okKtY4 6i5kPvJxTUyPgBReqKrvDdvpnednJsspyiGfn+WYPZX4A2seIrhVBDlWZ66NRvOpq+E+ v4ovVL7HKpl2Gt5568y4Znu/MPl24A6Xnv4ZRVsIiXyl6s1k/LXtNyVX2BN+YxSJjdkX X4Yg== X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGM4l4Hio94KKxRySfLxnHfJ+Dkjp5DdBJSrwuuqxvPhSIh0PhkEvMsMre1rbZ/xz+jsR" X-RZG-CLASS-ID: mo00 Received: from [IPv6:2a02:8109:89c0:ebfc:14bb:b5af:17db:dc1] by smtp.strato.de (RZmta 45.0.2 AUTH) with ESMTPSA id x0678cvAQBv38le (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Tue, 26 Nov 2019 12:57:03 +0100 (CET) Subject: Re: Bug 205201 - Booting halts if Dawicontrol DC-2976 UW SCSI board installed, unless RAM size limited to 3500M To: Mike Rapoport , Christoph Hellwig Cc: Robin Murphy , linux-arch@vger.kernel.org, darren@stevens-zone.net, mad skateman , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Rob Herring , paulus@samba.org, rtd2@xtra.co.nz, "contact@a-eon.com" , linuxppc-dev , nsaenzjulienne@suse.de References: <20191121072943.GA24024@lst.de> <6eec5c42-019c-a988-fc2a-cb804194683d@xenosoft.de> <20191121180226.GA3852@lst.de> <2fde79cf-875f-94e6-4a1b-f73ebb2e2c32@xenosoft.de> <20191125073923.GA30168@lst.de> <20191125093159.GA23118@linux.ibm.com> From: Christian Zigotzky Message-ID: Date: Tue, 26 Nov 2019 12:57:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191125093159.GA23118@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25 November 2019 at 10:32 am, Mike Rapoport wrote: > On Mon, Nov 25, 2019 at 08:39:23AM +0100, Christoph Hellwig wrote: >> On Sat, Nov 23, 2019 at 12:42:27PM +0100, Christian Zigotzky wrote: >>> Hello Christoph, >>> >>> Please find attached the dmesg of your Git kernel. >> Thanks. It looks like on your platform the swiotlb buffer isn't >> actually addressable based on the bus dma mask limit, which is rather >> interesting. swiotlb_init uses memblock_alloc_low to allocate the >> buffer, and I'll need some help from Mike and the powerpc maintainers >> to figure out how that select where to allocate the buffer from, and >> how we can move it to a lower address. My gut feeling would be to try >> to do what arm64 does and define a new ARCH_LOW_ADDRESS_LIMIT, prefera= bly >> without needing too much arch specific magic. > Presuming the problem is relevant for all CoreNet boards something like > this could work: > =20 > diff --git a/arch/powerpc/include/asm/dma.h b/arch/powerpc/include/asm/= dma.h > index 1b4f0254868f..7c6cfeeaff52 100644 > --- a/arch/powerpc/include/asm/dma.h > +++ b/arch/powerpc/include/asm/dma.h > @@ -347,5 +347,11 @@ extern int isa_dma_bridge_buggy; > #define isa_dma_bridge_buggy (0) > #endif > =20 > +#ifdef CONFIG_CORENET_GENERIC > +extern phys_addr_t ppc_dma_phys_limit; > +#define ARCH_LOW_ADDRESS_LIMIT (ppc_dma_phys_limit - 1) > +#endif > + > + > #endif /* __KERNEL__ */ > #endif /* _ASM_POWERPC_DMA_H */ > diff --git a/arch/powerpc/platforms/85xx/common.c b/arch/powerpc/platfo= rms/85xx/common.c > index fe0606439b5a..346b436b6d3f 100644 > --- a/arch/powerpc/platforms/85xx/common.c > +++ b/arch/powerpc/platforms/85xx/common.c > @@ -126,3 +126,7 @@ void __init mpc85xx_qe_par_io_init(void) > } > } > #endif > + > +#ifdef CONFIG_CORENET_GENERIC > +phys_addr_t ppc_dma_phys_limit =3D 0xffffffffUL; > +#endif > diff --git a/arch/powerpc/platforms/85xx/corenet_generic.c b/arch/power= pc/platforms/85xx/corenet_generic.c > index 7ee2c6628f64..673bcbdc7c75 100644 > --- a/arch/powerpc/platforms/85xx/corenet_generic.c > +++ b/arch/powerpc/platforms/85xx/corenet_generic.c > @@ -64,7 +64,7 @@ void __init corenet_gen_setup_arch(void) > mpc85xx_smp_init(); > =20 > swiotlb_detect_4g(); > - > + ppc_dma_phys_limit =3D 0x0fffffffUL; > pr_info("%s board\n", ppc_md.name); > =20 > mpc85xx_qe_init(); Hello Mike, My PCI TV card works also with your patch! Before I had to add "#include=20 " to the file "arch/powerpc/platforms/85xx/corenet_generic.c"=20 because of the following error: ------ =C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 arch/powerpc/platforms/85xx/core= net_generic.o =C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ipc/util.o =C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ipc/msgutil.o arch/powerpc/platforms/85xx/corenet_generic.c: In function=20 =E2=80=98corenet_gen_setup_arch=E2=80=99: arch/powerpc/platforms/85xx/corenet_generic.c:77:2: error:=20 =E2=80=98ppc_dma_phys_limit=E2=80=99 undeclared (first use in this functi= on); did you=20 mean =E2=80=98cpu_to_phys_id=E2=80=99? =C2=A0 ppc_dma_phys_limit =3D 0x0fffffffUL; =C2=A0 ^~~~~~~~~~~~~~~~~~ =C2=A0 cpu_to_phys_id arch/powerpc/platforms/85xx/corenet_generic.c:77:2: note: each=20 undeclared identifier is reported only once for each function it appears = in scripts/Makefile.build:265: recipe for target=20 'arch/powerpc/platforms/85xx/corenet_generic.o' failed make[3]: *** [arch/powerpc/platforms/85xx/corenet_generic.o] Error 1 scripts/Makefile.build:509: recipe for target=20 'arch/powerpc/platforms/85xx' failed make[2]: *** [arch/powerpc/platforms/85xx] Error 2 scripts/Makefile.build:509: recipe for target 'arch/powerpc/platforms'=20 failed make[1]: *** [arch/powerpc/platforms] Error 2 Makefile:1652: recipe for target 'arch/powerpc' failed make: *** [arch/powerpc] Error 2 ------ After that I was able to compile the latest Git kernel with your patch. Thanks, Christian